[PATCH] kmsan: fix missed kmsan_handle_dma() signature conversion

0 views
Skip to first unread message

Leon Romanovsky

unread,
Sep 17, 2025, 2:38:23 AM (7 days ago) Sep 17
to Marek Szyprowski, Leon Romanovsky, Jason Gunthorpe, Alexander Potapenko, Andrew Morton, kasa...@googlegroups.com, kernel test robot, linu...@kvack.org
From: Leon Romanovsky <leo...@nvidia.com>

kmsan_handle_dma_sg() has call to kmsan_handle_dma() function which was
missed during conversion to physical addresses. Update that caller too
and fix the following compilation error:

mm/kmsan/hooks.c:372:6: error: too many arguments to function call, expected 3, have 4
371 | kmsan_handle_dma(sg_page(item), item->offset, item->length,
| ~~~~~~~~~~~~~~~~
372 | dir);
| ^~~
mm/kmsan/hooks.c:362:19: note: 'kmsan_handle_dma' declared here
362 | EXPORT_SYMBOL_GPL(kmsan_handle_dma);

Fixes: 6eb1e769b2c1 ("kmsan: convert kmsan_handle_dma to use physical addresses")
Reported-by: kernel test robot <l...@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202509170638...@intel.com/
Signed-off-by: Leon Romanovsky <leo...@nvidia.com>
---
mm/kmsan/hooks.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/mm/kmsan/hooks.c b/mm/kmsan/hooks.c
index fa9475e5ec4e9..90bee565b9bc2 100644
--- a/mm/kmsan/hooks.c
+++ b/mm/kmsan/hooks.c
@@ -368,8 +368,7 @@ void kmsan_handle_dma_sg(struct scatterlist *sg, int nents,
int i;

for_each_sg(sg, item, nents, i)
- kmsan_handle_dma(sg_page(item), item->offset, item->length,
- dir);
+ kmsan_handle_dma(sg_phys(item), item->length, dir);
}

/* Functions from kmsan-checks.h follow. */
--
2.51.0

Jason Gunthorpe

unread,
Sep 17, 2025, 7:22:48 AM (7 days ago) Sep 17
to Leon Romanovsky, Marek Szyprowski, Leon Romanovsky, Alexander Potapenko, Andrew Morton, kasa...@googlegroups.com, kernel test robot, linu...@kvack.org
On Wed, Sep 17, 2025 at 09:37:36AM +0300, Leon Romanovsky wrote:
> From: Leon Romanovsky <leo...@nvidia.com>
>
> kmsan_handle_dma_sg() has call to kmsan_handle_dma() function which was
> missed during conversion to physical addresses. Update that caller too
> and fix the following compilation error:
>
> mm/kmsan/hooks.c:372:6: error: too many arguments to function call, expected 3, have 4
> 371 | kmsan_handle_dma(sg_page(item), item->offset, item->length,
> | ~~~~~~~~~~~~~~~~
> 372 | dir);
> | ^~~
> mm/kmsan/hooks.c:362:19: note: 'kmsan_handle_dma' declared here
> 362 | EXPORT_SYMBOL_GPL(kmsan_handle_dma);
>
> Fixes: 6eb1e769b2c1 ("kmsan: convert kmsan_handle_dma to use physical addresses")
> Reported-by: kernel test robot <l...@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202509170638...@intel.com/
> Signed-off-by: Leon Romanovsky <leo...@nvidia.com>
> ---
> mm/kmsan/hooks.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)

Reviewed-by: Jason Gunthorpe <j...@nvidia.com>

Jason

Alexander Potapenko

unread,
Sep 17, 2025, 8:01:27 AM (7 days ago) Sep 17
to Jason Gunthorpe, Leon Romanovsky, Marek Szyprowski, Leon Romanovsky, Andrew Morton, kasa...@googlegroups.com, kernel test robot, linu...@kvack.org
Reviewed-by: Alexander Potapenko <gli...@google.com>

Marek Szyprowski

unread,
Sep 17, 2025, 8:44:04 AM (7 days ago) Sep 17
to Leon Romanovsky, Leon Romanovsky, Jason Gunthorpe, Alexander Potapenko, Andrew Morton, kasa...@googlegroups.com, kernel test robot, linu...@kvack.org
On 17.09.2025 08:37, Leon Romanovsky wrote:
> From: Leon Romanovsky <leo...@nvidia.com>
>
> kmsan_handle_dma_sg() has call to kmsan_handle_dma() function which was
> missed during conversion to physical addresses. Update that caller too
> and fix the following compilation error:
>
> mm/kmsan/hooks.c:372:6: error: too many arguments to function call, expected 3, have 4
> 371 | kmsan_handle_dma(sg_page(item), item->offset, item->length,
> | ~~~~~~~~~~~~~~~~
> 372 | dir);
> | ^~~
> mm/kmsan/hooks.c:362:19: note: 'kmsan_handle_dma' declared here
> 362 | EXPORT_SYMBOL_GPL(kmsan_handle_dma);
>
> Fixes: 6eb1e769b2c1 ("kmsan: convert kmsan_handle_dma to use physical addresses")
> Reported-by: kernel test robot <l...@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202509170638...@intel.com/
> Signed-off-by: Leon Romanovsky <leo...@nvidia.com>

Applied to dma-mapping-for-next branch. Thanks!

> ---
> mm/kmsan/hooks.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/mm/kmsan/hooks.c b/mm/kmsan/hooks.c
> index fa9475e5ec4e9..90bee565b9bc2 100644
> --- a/mm/kmsan/hooks.c
> +++ b/mm/kmsan/hooks.c
> @@ -368,8 +368,7 @@ void kmsan_handle_dma_sg(struct scatterlist *sg, int nents,
> int i;
>
> for_each_sg(sg, item, nents, i)
> - kmsan_handle_dma(sg_page(item), item->offset, item->length,
> - dir);
> + kmsan_handle_dma(sg_phys(item), item->length, dir);
> }
>
> /* Functions from kmsan-checks.h follow. */

Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland

Reply all
Reply to author
Forward
0 new messages