[PATCH] mm: remove unnecessary pointer variables

[Xichao Zhao]

Simplify the code to enhance readability and maintain a consistent
coding style.

Signed-off-by: Xichao Zhao <zhao....@vivo.com>
---
mm/kasan/init.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/mm/kasan/init.c b/mm/kasan/init.c
index ced6b29fcf76..e5810134813c 100644
--- a/mm/kasan/init.c
+++ b/mm/kasan/init.c
@@ -266,11 +266,9 @@ int __ref kasan_populate_early_shadow(const void *shadow_start,
}

if (pgd_none(*pgd)) {
- p4d_t *p;

if (slab_is_available()) {
- p = p4d_alloc(&init_mm, pgd, addr);
- if (!p)
+ if (!p4d_alloc(&init_mm, pgd, addr))
return -ENOMEM;
} else {
pgd_populate(&init_mm, pgd,
--
2.34.1

[Anshuman Khandual]

Agreed that p4d_t pointer here is just redundant.

Reviewed-by: Anshuman Khandual <anshuman...@arm.com>

[Andrey Konovalov]

Reviewed-by: Andrey Konovalov <andre...@gmail.com>

[Vishal Moola (Oracle)]

On Mon, Aug 11, 2025 at 11:42:57AM +0800, Xichao Zhao wrote:
> Simplify the code to enhance readability and maintain a consistent
> coding style.
>
> Signed-off-by: Xichao Zhao <zhao....@vivo.com>
> ---
> mm/kasan/init.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/mm/kasan/init.c b/mm/kasan/init.c
> index ced6b29fcf76..e5810134813c 100644
> --- a/mm/kasan/init.c
> +++ b/mm/kasan/init.c
> @@ -266,11 +266,9 @@ int __ref kasan_populate_early_shadow(const void *shadow_start,
> }
>
> if (pgd_none(*pgd)) {
> - p4d_t *p;
>

Nit - Get rid of the empty line between the if statements.

Aside from that, LGTM.
Reviewed-by: Vishal Moola (Oracle) <vishal...@gmail.com>