[PATCH] kas-container: Move default variable initialization up in file

1 view
Skip to first unread message

Jan Kiszka

unread,
May 28, 2024, 1:36:49 AMMay 28
to kas-devel
From: Jan Kiszka <jan.k...@siemens.com>

When looking at downstream copies of kas-container in order to figure
out which version that project uses, it's inconvenient to first search
for KAS_IMAGE_VERSION_DEFAULT. Move it up to make that search easier.

No functional changes.

Signed-off-by: Jan Kiszka <jan.k...@siemens.com>
---
kas-container | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/kas-container b/kas-container
index a94107a..fdc75d4 100755
--- a/kas-container
+++ b/kas-container
@@ -2,7 +2,7 @@
#
# kas - setup tool for bitbake based projects
#
-# Copyright (c) Siemens AG, 2018-2022
+# Copyright (c) Siemens AG, 2018-2024
#
# Authors:
# Jan Kiszka <jan.k...@siemens.com>
@@ -27,6 +27,11 @@

set -e

+KAS_IMAGE_VERSION_DEFAULT="4.3.2"
+KAS_CONTAINER_IMAGE_PATH_DEFAULT="ghcr.io/siemens/kas"
+KAS_CONTAINER_IMAGE_NAME_DEFAULT="kas"
+KAS_CONTAINER_SELF_NAME="$(basename "$0")"
+
usage()
{
SELF="${KAS_CONTAINER_SELF_NAME}"
@@ -144,11 +149,6 @@ run_clean() {
fi
}

-KAS_IMAGE_VERSION_DEFAULT="4.3.2"
-KAS_CONTAINER_IMAGE_PATH_DEFAULT="ghcr.io/siemens/kas"
-KAS_CONTAINER_IMAGE_NAME_DEFAULT="kas"
-KAS_CONTAINER_SELF_NAME="$(basename "$0")"
-
set_container_image_var() {
KAS_IMAGE_VERSION="${KAS_IMAGE_VERSION:-${KAS_IMAGE_VERSION_DEFAULT}}"
KAS_CONTAINER_IMAGE_NAME="${KAS_CONTAINER_IMAGE_NAME:-${KAS_CONTAINER_IMAGE_NAME_DEFAULT}}"
--
2.43.0
Reply all
Reply to author
Forward
0 new messages