[PATCH 1/6] refactor: add function to check if running under pytest

0 views
Skip to first unread message

Felix Moessbauer

unread,
Oct 1, 2025, 6:21:20 AMOct 1
to kas-...@googlegroups.com, jan.k...@siemens.com, Felix Moessbauer
Signed-off-by: Felix Moessbauer <felix.mo...@siemens.com>
---
kas/kas.py | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/kas/kas.py b/kas/kas.py
index f17546b35..9440e34b1 100644
--- a/kas/kas.py
+++ b/kas/kas.py
@@ -51,6 +51,13 @@ __copyright__ = 'Copyright (c) Siemens AG, 2017-2018'
DEFAULT_LOG_LEVEL = 'info'


+def is_pytest():
+ """
+ True if we are invoked under pytest
+ """
+ return "PYTEST_CURRENT_TEST" in os.environ
+
+
def create_logger():
"""
Setup the logging environment
@@ -188,7 +195,7 @@ def kas(argv):

loop.add_signal_handler(signal.SIGTERM, interruption)
# don't overwrite pytest's signal handler
- if "PYTEST_CURRENT_TEST" not in os.environ:
+ if not is_pytest():
loop.add_signal_handler(signal.SIGINT, interruption)

try:
--
2.51.0

Jan Kiszka

unread,
Oct 2, 2025, 6:35:30 AMOct 2
to Felix Moessbauer, kas-...@googlegroups.com
On 01.10.25 12:20, Felix Moessbauer wrote:
> Signed-off-by: Felix Moessbauer <felix.mo...@siemens.com>
> ---
> kas/kas.py | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/kas/kas.py b/kas/kas.py
> index f17546b35..9440e34b1 100644
> --- a/kas/kas.py
> +++ b/kas/kas.py
> @@ -51,6 +51,13 @@ __copyright__ = 'Copyright (c) Siemens AG, 2017-2018'
> DEFAULT_LOG_LEVEL = 'info'
>
>
> +def is_pytest():
> + """
> + True if we are invoked under pytest
> + """
> + return "PYTEST_CURRENT_TEST" in os.environ
> +
> +

Can't we monkey-patch what we need? It's a bit ugly to carry such test
conditions in the production code.

Jan

> def create_logger():
> """
> Setup the logging environment
> @@ -188,7 +195,7 @@ def kas(argv):
>
> loop.add_signal_handler(signal.SIGTERM, interruption)
> # don't overwrite pytest's signal handler
> - if "PYTEST_CURRENT_TEST" not in os.environ:
> + if not is_pytest():
> loop.add_signal_handler(signal.SIGINT, interruption)
>
> try:


--
Siemens AG, Foundational Technologies
Linux Expert Center
Reply all
Reply to author
Forward
0 new messages