[PATCH] Dockerfile: install lz4

291 views
Skip to first unread message

Ross Burton

unread,
Aug 17, 2021, 5:20:57 PM8/17/21
to kas-...@googlegroups.com
OpemnEmbedded Core is about to depend on lz4c, pzstd, and zstd being on
the host. The Dockerfile was already installing zstd which provides
zstd/pzstd, so also install lz4 for lz4c.

Signed-off-by: Ross Burton <ross....@arm.com>
---
Dockerfile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Dockerfile b/Dockerfile
index 433fb3e..e8c8dc7 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -18,7 +18,7 @@ RUN apt-get install --no-install-recommends -y \
pylint3 xterm \
python3-setuptools python3-wheel python3-yaml python3-distro python3-jsonschema \
gosu lsb-release file vim less procps tree tar bzip2 zstd bc tmux libncurses-dev \
- dosfstools mtools parted \
+ dosfstools mtools parted lz4 \
git-lfs/buster-backports mercurial iproute2 ssh-client curl rsync gnupg awscli sudo && \
if [ "$TARGETPLATFORM" = "linux/amd64" ]; then \
apt-get install --no-install-recommends -y gcc-multilib syslinux; \
--
2.32.0

Jan Kiszka

unread,
Aug 18, 2021, 6:44:06 AM8/18/21
to Ross Burton, kas-...@googlegroups.com
On 17.08.21 23:20, Ross Burton wrote:
> OpemnEmbedded Core is about to depend on lz4c, pzstd, and zstd being on

Typo, fixing up.
Ok, so this will be the case with OE Core 2021.10.

Thanks, applied.

Jan

--
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux

Ross Burton

unread,
Aug 18, 2021, 6:58:27 AM8/18/21
to Jan Kiszka, kas-...@googlegroups.com

Is there an ETA for the next release?  When this change lands in oe-core master will be unbuildable with the current Kas docker images.

 

Ross

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

Jan Kiszka

unread,
Aug 18, 2021, 7:03:31 AM8/18/21
to Ross Burton, kas-...@googlegroups.com
On 18.08.21 12:58, Ross Burton wrote:
>
> Is there an ETA for the next release?  When this change lands in
> oe-core master will be unbuildable with the current Kas docker images.
>
>  
>

"Few weeks", I would say. With that perspective, we'll should make sure
that this happens before the OE release.

Jan

> Ross
>
>  
>
> *From: *Jan Kiszka <jan.k...@siemens.com>
> *Date: *Wednesday, 18 August 2021 at 11:44
> *To: *Ross Burton <Ross....@arm.com>, kas-...@googlegroups.com
> <kas-...@googlegroups.com>
> *Subject: *Re: [PATCH] Dockerfile: install lz4

Ross Burton

unread,
Aug 18, 2021, 7:11:33 AM8/18/21
to Jan Kiszka, kas-...@googlegroups.com

Can you roll a new docker image sooner?  Anyone using the Kas image for CI against master will be unable to build one this change lands in OE.

 

From: Jan Kiszka <jan.k...@siemens.com>
Date: Wednesday, 18 August 2021 at 12:03
To: Ross Burton <Ross....@arm.com>, kas-...@googlegroups.com <kas-...@googlegroups.com>
Subject: Re: [PATCH] Dockerfile: install lz4

On 18.08.21 12:58, Ross Burton wrote:
>

> Is there an ETA for the next release?� When this change lands in


> oe-core master will be unbuildable with the current Kas docker images.
>

> �


>

"Few weeks", I would say. With that perspective, we'll should make sure
that this happens before the OE release.

Jan

> Ross
>

> �


>
> *From: *Jan Kiszka <jan.k...@siemens.com>
> *Date: *Wednesday, 18 August 2021 at 11:44
> *To: *Ross Burton <Ross....@arm.com>, kas-...@googlegroups.com
> <kas-...@googlegroups.com>
> *Subject: *Re: [PATCH] Dockerfile: install lz4
>
> On 17.08.21 23:20, Ross Burton wrote:
> > OpemnEmbedded Core is about to depend on lz4c, pzstd, and zstd being on
>
> Typo, fixing up.
>

> > the host.� The Dockerfile was already installing zstd which provides


> > zstd/pzstd, so also install lz4 for lz4c.
> >
> > Signed-off-by: Ross Burton <ross....@arm.com>
> > ---

> >� Dockerfile | 2 +-
> >� 1 file changed, 1 insertion(+), 1 deletion(-)


> >
> > diff --git a/Dockerfile b/Dockerfile
> > index 433fb3e..e8c8dc7 100644
> > --- a/Dockerfile
> > +++ b/Dockerfile
> > @@ -18,7 +18,7 @@ RUN apt-get install --no-install-recommends -y \

> >��������� pylint3 xterm \
> >��������� python3-setuptools python3-wheel python3-yaml
> python3-distro python3-jsonschema \
> >��������� gosu lsb-release file vim less procps tree tar bzip2 zstd
> bc tmux libncurses-dev \
> > -������� dosfstools mtools parted \
> > +������� dosfstools mtools parted lz4 \
> >��������� git-lfs/buster-backports mercurial iproute2 ssh-client curl


> rsync gnupg awscli sudo && \

> >����� if [ "$TARGETPLATFORM" = "linux/amd64" ]; then \
> >��������� apt-get install --no-install-recommends -y gcc-multilib


> syslinux; \
> >
>
> Ok, so this will be the case with OE Core 2021.10.
>
> Thanks, applied.
>
> Jan
>
> --
> Siemens AG, T RDA IOT
> Corporate Competence Center Embedded Linux
>
> IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended
> recipient, please notify the sender immediately and do not disclose
> the contents to any other person, use it for any purpose, or store or
> copy the information in any medium. Thank you.

--
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux

Ross Burton

unread,
Aug 18, 2021, 1:11:05 PM8/18/21
to kas-devel
2021-08-18 16:02:51 - INFO - ERROR: The following required tools (as specified by HOSTTOOLS) appear to be unavailable in PATH, please install them in order to proceed:
2021-08-18 16:02:51 - INFO - lz4c

The changes have landed in master so the Kas docker image is now useless for anyone using it to build master.

Ross

Jan Kiszka

unread,
Aug 18, 2021, 1:15:39 PM8/18/21
to Ross Burton, kas-devel
On 18.08.21 19:11, Ross Burton wrote:
> 2021-08-18 16:02:51 - INFO - ERROR: The following required tools (as
> specified by HOSTTOOLS) appear to be unavailable in PATH, please install
> them in order to proceed:
> 2021-08-18 16:02:51 - INFO - lz4c
>
> The changes have landed in master so the Kas docker image is now useless
> for anyone using it to build master.


$ docker build -t ghcr.io/siemens/kas/kas:next .
$ KAS_IMAGE_VERSION=next kas ...

I'll push a new next version later today as well, currently hunter
(unrelated) bugs there.
Reply all
Reply to author
Forward
0 new messages