[PATCH] kas-container: Update new version variable on release

2 views
Skip to first unread message

Jan Kiszka

unread,
Jun 15, 2025, 12:21:38 PMJun 15
to kas-devel, Felix Moessbauer
From: Jan Kiszka <jan.k...@siemens.com>

This was forgotten when introducing KAS_CONTAINER_SCRIPT_VERSION,
causing the release of 4.8 to overwrite KAS_IMAGE_VERSION_DEFAULT again.
Fix up the variables and update the release script to use the right one
from now on.

Fixes: 99d9604f0c5b ("kas-container: pass script version to kas in container")
Signed-off-by: Jan Kiszka <jan.k...@siemens.com>
---

Means we need a 4.8.1 - too bad.

kas-container | 6 +++---
scripts/release.sh | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/kas-container b/kas-container
index 3e11669..b72c87b 100755
--- a/kas-container
+++ b/kas-container
@@ -2,7 +2,7 @@
#
# kas - setup tool for bitbake based projects
#
-# Copyright (c) Siemens AG, 2018-2024
+# Copyright (c) Siemens AG, 2018-2025
#
# Authors:
# Jan Kiszka <jan.k...@siemens.com>
@@ -27,8 +27,8 @@

set -e

-KAS_CONTAINER_SCRIPT_VERSION="4.7"
-KAS_IMAGE_VERSION_DEFAULT="4.8"
+KAS_CONTAINER_SCRIPT_VERSION="4.8"
+KAS_IMAGE_VERSION_DEFAULT="${KAS_CONTAINER_SCRIPT_VERSION}"
KAS_CONTAINER_IMAGE_PATH_DEFAULT="ghcr.io/siemens/kas"
KAS_CONTAINER_IMAGE_NAME_DEFAULT="kas"
KAS_CONTAINER_SELF_NAME="$(basename "$0")"
diff --git a/scripts/release.sh b/scripts/release.sh
index de60063..f41e508 100755
--- a/scripts/release.sh
+++ b/scripts/release.sh
@@ -31,7 +31,7 @@ fi

mv newchangelog CHANGELOG.md
sed -i "s,\(__version__ =\).*,\1 \'$NEW_VERSION\'," kas/__version__.py
-sed -i "s,\(KAS_IMAGE_VERSION_DEFAULT=\).*,\1\"$NEW_VERSION\"," kas-container
+sed -i "s,\(KAS_CONTAINER_SCRIPT_VERSION=\).*,\1\"$NEW_VERSION\"," kas-container

git add CHANGELOG.md
git add kas/__version__.py
--
2.43.0

Jan Kiszka

unread,
Jun 15, 2025, 12:35:14 PMJun 15
to kas-devel, Felix Moessbauer
From: Jan Kiszka <jan.k...@siemens.com>

This was forgotten when introducing KAS_CONTAINER_SCRIPT_VERSION,
causing the release of 4.8 to overwrite KAS_IMAGE_VERSION_DEFAULT again.
Fix up the variables and update the release script to use the right one
from now on.

Fixes: 99d9604f0c5b ("kas-container: pass script version to kas in container")
Signed-off-by: Jan Kiszka <jan.k...@siemens.com>
---

Changes in v2:
- make sure we only patch the original assignment, not the forwarding
index de60063..9e11099 100755
--- a/scripts/release.sh
+++ b/scripts/release.sh
@@ -31,7 +31,7 @@ fi

mv newchangelog CHANGELOG.md
sed -i "s,\(__version__ =\).*,\1 \'$NEW_VERSION\'," kas/__version__.py
-sed -i "s,\(KAS_IMAGE_VERSION_DEFAULT=\).*,\1\"$NEW_VERSION\"," kas-container
+sed -i "s,^\(KAS_CONTAINER_SCRIPT_VERSION=\).*,\1\"$NEW_VERSION\"," kas-container

MOESSBAUER, Felix

unread,
Jun 16, 2025, 4:15:46 AMJun 16
to Kiszka, Jan, kas-...@googlegroups.com
On Sun, 2025-06-15 at 18:35 +0200, Jan Kiszka wrote:
> From: Jan Kiszka <jan.k...@siemens.com>
>
> This was forgotten when introducing KAS_CONTAINER_SCRIPT_VERSION,
> causing the release of 4.8 to overwrite KAS_IMAGE_VERSION_DEFAULT
> again.
> Fix up the variables and update the release script to use the right
> one
> from now on.

Thanks. I successfully tested this locally.

Tested-by: Felix Moessbauer <felix.mo...@siemens.com>
Siemens AG
Linux Expert Center
Friedrich-Ludwig-Bauer-Str. 3
85748 Garching, Germany

Reply all
Reply to author
Forward
0 new messages