[PATCH] libkas: Properly convert error list to string prior to output

1 view
Skip to first unread message

Jan Kiszka

unread,
Apr 30, 2026, 3:50:11 AM (10 days ago) Apr 30
to kas-devel
From: Jan Kiszka <jan.k...@siemens.com>

This was missed while refactoring the code.

Fixes: ca7a34fbcc1d ("libkas: Consolidate and refactor error reporting of run_cmd*")
Signed-off-by: Jan Kiszka <jan.k...@siemens.com>
---
kas/libkas.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kas/libkas.py b/kas/libkas.py
index 5b4837d..f5f5c45 100644
--- a/kas/libkas.py
+++ b/kas/libkas.py
@@ -188,7 +188,7 @@ async def run_cmd_async(cmd, cwd, env=None, fail=True, liveupdate=False,
raise

if ret and fail:
- _report_cmd_error(ret, cwd, cmdstr, cmd, logo.stderr)
+ _report_cmd_error(ret, cwd, cmdstr, cmd, ''.join(logo.stderr))

return _filter_stderr(capture_stderr, ret,
''.join(logo.stdout), ''.join(logo.stderr))
--
2.47.3

MOESSBAUER, Felix

unread,
Apr 30, 2026, 4:52:47 AM (10 days ago) Apr 30
to Kiszka, Jan, kas-devel
On Thu, 2026-04-30 at 09:50 +0200, 'Jan Kiszka' via kas-devel wrote:
> From: Jan Kiszka <jan.k...@siemens.com>
>
> This was missed while refactoring the code.

Right.

Reviewed-by: Felix Moessbauer <felix.mo...@siemens.com>

>
> Fixes: ca7a34fbcc1d ("libkas: Consolidate and refactor error reporting of run_cmd*")
> Signed-off-by: Jan Kiszka <jan.k...@siemens.com>
> ---
> kas/libkas.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kas/libkas.py b/kas/libkas.py
> index 5b4837d..f5f5c45 100644
> --- a/kas/libkas.py
> +++ b/kas/libkas.py
> @@ -188,7 +188,7 @@ async def run_cmd_async(cmd, cwd, env=None, fail=True, liveupdate=False,
> raise
>
> if ret and fail:
> - _report_cmd_error(ret, cwd, cmdstr, cmd, logo.stderr)
> + _report_cmd_error(ret, cwd, cmdstr, cmd, ''.join(logo.stderr))
>
> return _filter_stderr(capture_stderr, ret,
> ''.join(logo.stdout), ''.join(logo.stderr))
> --
> 2.47.3
>

> --
> You received this message because you are subscribed to the Google Groups "kas-devel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to kas-devel+...@googlegroups.com.
> To view this discussion visit https://groups.google.com/d/msgid/kas-devel/03853d29-6fe3-4ea8-b7fe-207a5dcaf7dc%40siemens.com.

Reply all
Reply to author
Forward
0 new messages