[PATCH 2/3] kas-container: Move container engine after build system detection/check

0 views
Skip to first unread message

Jan Kiszka

unread,
Jun 18, 2026, 11:29:59 AM (21 hours ago) Jun 18
to kas-...@googlegroups.com, Felix Moessbauer
From: Jan Kiszka <jan.k...@siemens.com>

Allows to derive engine defaults from the effective build system.

Signed-off-by: Jan Kiszka <jan.k...@siemens.com>
---
kas-container | 54 +++++++++++++++++++++++++--------------------------
1 file changed, 27 insertions(+), 27 deletions(-)

diff --git a/kas-container b/kas-container
index db7f730..3e90326 100755
--- a/kas-container
+++ b/kas-container
@@ -453,35 +453,8 @@ while [ $# -gt 0 ]; do
esac
done

-KAS_CONTAINER_ENGINE="${KAS_CONTAINER_ENGINE:-${KAS_DOCKER_ENGINE}}"
-if [ -z "${KAS_CONTAINER_ENGINE}" ]; then
- # Try to auto-detect a container engine
- if command -v docker >/dev/null 2>&1 && docker -v 2>/dev/null | grep -q '^Docker'; then
- KAS_CONTAINER_ENGINE=docker
- elif command -v podman >/dev/null 2>&1; then
- KAS_CONTAINER_ENGINE=podman
- else
- fatal_error "no container engine found, need docker or podman"
- fi
-fi
-
KAS_RUNTIME_ARGS="--log-driver=none --user=root"

-case "${KAS_CONTAINER_ENGINE}" in
-docker)
- KAS_CONTAINER_COMMAND="docker"
- enable_unpriv_userns_docker
- check_docker_rootless
- ;;
-podman)
- KAS_CONTAINER_COMMAND="podman"
- KAS_RUNTIME_ARGS="${KAS_RUNTIME_ARGS} --security-opt label=disable"
- ;;
-*)
- fatal_error "unknown container engine '${KAS_CONTAINER_ENGINE}'"
- ;;
-esac
-
setup_kas_dirs

[ -n "${KAS_CMD}" ] || usage
@@ -576,6 +549,33 @@ else
sed 's/build_system:[ ]\+//')}
fi

+KAS_CONTAINER_ENGINE="${KAS_CONTAINER_ENGINE:-${KAS_DOCKER_ENGINE}}"
+if [ -z "${KAS_CONTAINER_ENGINE}" ]; then
+ # Try to auto-detect a container engine
+ if command -v docker >/dev/null 2>&1 && docker -v 2>/dev/null | grep -q '^Docker'; then
+ KAS_CONTAINER_ENGINE=docker
+ elif command -v podman >/dev/null 2>&1; then
+ KAS_CONTAINER_ENGINE=podman
+ else
+ fatal_error "no container engine found, need docker or podman"
+ fi
+fi
+
+case "${KAS_CONTAINER_ENGINE}" in
+docker)
+ KAS_CONTAINER_COMMAND="docker"
+ enable_unpriv_userns_docker
+ check_docker_rootless
+ ;;
+podman)
+ KAS_CONTAINER_COMMAND="podman"
+ KAS_RUNTIME_ARGS="${KAS_RUNTIME_ARGS} --security-opt label=disable"
+ ;;
+*)
+ fatal_error "unknown container engine '${KAS_CONTAINER_ENGINE}'"
+ ;;
+esac
+
if [ "${BUILD_SYSTEM}" = "isar" ] || [ "${BUILD_SYSTEM}" = "isar-privileged" ]; then
enable_isar_mode
elif [ "${BUILD_SYSTEM}" = "isar-rootless" ]; then
--
2.47.3

Reply all
Reply to author
Forward
0 new messages