[PATCH] Dockerfile: keep kas-container in the image

[Jose Quaresma]

The image is also a form of distribution and sometimes the image is directly
related to the helper kas-container. Both need to be synchronized for
proper functioning.

With this change, it might be possible to obtain the kas-container through
the officially distributed image:
| docker cp imageid:/usr/local/bin/kas-container localpath

Signed-off-by: Jose Quaresma <jose.q...@oss.qualcomm.com>
---
Dockerfile | 1 -
1 file changed, 1 deletion(-)

diff --git a/Dockerfile b/Dockerfile
index 91a520b..ceb792a 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -72,7 +72,6 @@ RUN --mount=type=bind,target=/kas,rw \
shtab --shell=bash -u kas.kas.kas_get_argparser --error-unimportable --prog kas \
> /usr/local/share/bash-completion/completions/kas && \
rm -rf $(pip3 cache dir) && \
- rm -f /usr/local/bin/kas-container && \
install -m 0755 /kas/contrib/oe-git-proxy /usr/bin/ && \
install -m 0755 /kas/container-entrypoint / && \
kas --version
--
2.55.0

[Jan Kiszka]

This reverts df7c05ce03d7 - adding Felix as original author of it.

I can follow the logic of this change, though.

Jan

--
Siemens AG, Foundational Technologies
Linux Expert Center

[Jose Quaresma]

I wasn't aware of df7c05ce03d7. It seems to me that at the time there was no

justification  for having the helper in the container, but I think my use case is viable.

Let's see what Felix thinks.

If he agrees with my change, I can revert df7c05ce03d7 and add my justification.

Jose

[MOESSBAUER, Felix]

Actually I did not think of the use-case you laid out here and just
tried to shrink the container. But as the script is really not that
big, I'm not against re-introducing it.

>
> If he agrees with my change, I can revert df7c05ce03d7 and add my justification.

Agree. Please just revert my commit.

Felix

[Jose Quaresma]

Thanks.
 

>
> If he agrees with my change, I can revert df7c05ce03d7 and add my justification.

Agree. Please just revert my commit.

Patch submitted.

Jose