Typesafe attributes refactoring

22 views
Skip to first unread message

Maxim Shafirov

unread,
Mar 14, 2013, 7:15:06 AM3/14/13
to karafr...@googlegroups.com
Hi, 

It would be great if someone took time reviewing the change I've just pushed https://github.com/TinyMission/kara/commit/49f09cf9fae7d2e1fc6e59956295559a4a120a73 (typesafe_attributes  branch).

Basic idea is to replace tag attribute properties and builder's functions parameter types from String to something more type safe. 
For the list of all available attributes please consult kara.views.Attributes object.

Unfortunately, I made all the changes by hand so ruby scripts, that generated original BodyTags.kt are obsolete now.

I'll merge the stuff to master as long as we all agree this refactoring makes sense.

Thanks!

Andy Selvig

unread,
Mar 15, 2013, 8:49:30 AM3/15/13
to Maxim Shafirov, karafr...@googlegroups.com
I think the changes are good. It's a bit unfortunate that they didn't make it into the ruby builder, since that would be much easier to allow future modifications and adding the remaining tags (last I checked, we're missing quite a few from the complete html5 spec). I might take a look to see if I can modify the script to take into account your changes.

Once you merge, we need a bunch of new documentation as well! 

--
You received this message because you are subscribed to the Google Groups "Kara Framework" group.
To unsubscribe from this group and stop receiving emails from it, send an email to karaframewor...@googlegroups.com.
To post to this group, send email to karafr...@googlegroups.com.
Visit this group at http://groups.google.com/group/karaframework?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

Reply all
Reply to author
Forward
0 new messages