Re: [VOTE] 2.8.1 RC1

[Randall Hauch]

Thanks for generating a new RC1 with the corrected site docs, David.

I was able to successfully complete the following:

- Installed 2.8.1 RC0 and performed quickstart for broker and Connect
- Verified signatures and checksums
- Verified the tag
- Manually compared the release notes to JIRA
- Build release archive from the tag, ran Connect tests, installed locally, and ran a portion of quickstart
- Manually spotchecked the Javadocs

- Verified the site docs at https://kafka.apache.org/28/documentation.html has corrected version references, except for the tar and cd commands in step 1 of the https://kafka.apache.org/28/documentation.html#quickstart. 

I think that last issue is minor and not worth another RC, since the other version references in https://kafka.apache.org/28/documentation.html do reference 2.8.1 and we can easily fix it on the website, optionally as part of the other post-vote changes to the site.

So I'm +1 (binding)

Best regards,

Randall

On Tue, Sep 14, 2021 at 8:39 AM David Jacot <dja...@confluent.io.invalid> wrote:

Hello Kafka users, developers and client-developers,

This is the second candidate for release of Apache Kafka 2.8.1.

Apache Kafka 2.8.1 is a bugfix release and fixes 49 issues since the 2.8.0
release. Please see the release notes for more information.

Release notes for the 2.8.1 release:
https://home.apache.org/~dajac/kafka-2.8.1-rc1/RELEASE_NOTES.html

*** Please download, test and vote by Friday, September 17, 9am PT

Kafka's KEYS file containing PGP keys we use to sign the release:
https://kafka.apache.org/KEYS

* Release artifacts to be voted upon (source and binary):
https://home.apache.org/~dajac/kafka-2.8.1-rc1/

* Maven artifacts to be voted upon:
https://repository.apache.org/content/groups/staging/org/apache/kafka/

* Javadoc:
https://home.apache.org/~dajac/kafka-2.8.1-rc1/javadoc/

* Tag to be voted upon (off 2.8 branch) is the 2.8.1 tag:
https://github.com/apache/kafka/releases/tag/2.8.1-rc1

* Documentation:
https://kafka.apache.org/28/documentation.html

* Protocol:
https://kafka.apache.org/28/protocol.html

* Successful Jenkins builds for the 2.8 branch:
Unit/integration tests:
https://ci-builds.apache.org/job/Kafka/job/kafka/job/2.8/80/
System tests:
https://jenkins.confluent.io/job/system-test-kafka/job/2.8/214/

/**************************************

Thanks,
David

[Manikumar]

Hi,

+1 (binding)

- verified the signatures
- ran the tests on the source archive
- verified the quickstart with binary
- verified the artifacts, javadoc

Thanks for running the release!

Thanks,
Manikumar

On Tue, Sep 14, 2021 at 10:36 PM Chris Egerton <chr...@confluent.io.invalid> wrote:

Hi David,

I took a look at the Javadocs and noticed a small issue. Using the search
bar at the top of the landing page (
https://home.apache.org/~dajac/kafka-2.8.1-rc1/javadoc/), I entered
"KafkaProducer" and clicked on the search item that came up. This brought
me to
https://home.apache.org/~dajac/kafka-2.8.1-rc1/javadoc/undefined/org/apache/kafka/clients/producer/KafkaProducer.html,
which displayed a 404 "Not Found" error.

This doesn't appear to be a regression as the same behavior occurs for me
when browsing the 2.8.0 Javadocs (
https://kafka.apache.org/28/javadoc/index.html?overview-summary.html), but
I wanted to bring it up just in case. Normally I don't use the search bar
but with the removal of sidebar frames from Javadocs I've had to start
relying on it a little bit more.

Cheers,

Chris

[Ismael Juma]

Josep,

This is fixed in 3.0.0, right?

Ismael

On Tue, Sep 14, 2021 at 11:32 AM Josep Prat <josep...@aiven.io.invalid> wrote:

Hi Chris and David,

Regarding the API search, this is a known bug in JDK 11 and prior. It can't
correctly generate URLs for projects not using the module system (Kafka)
that link to projects that use it (Java Standard Library). The bug has been
fixed in JDK 12 and higher.
To have the search work as expected, javadoc must be generated with JDK 12
or higher (for example JDK16 or the freshly released 17). For further info
check https://issues.apache.org/jira/browse/KAFKA-12782 or
https://github.com/apache/kafka/pull/10780

Best,
———
Josep Prat

Aiven Deutschland GmbH

Immanuelkirchstraße 26, 10405 Berlin

Amtsgericht Charlottenburg, HRB 209739 B

Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen

m: +491715557497

w: aiven.io

e: josep...@aiven.io

[Josep Prat]

Hi Ismael,

Yes the 'fix' was merged in the 3.0.0 branch (trunk at that time). I also checked the current 3.0.0 RC2 and the javadoc  search works as expected.

Best,

———
Josep Prat

Aiven Deutschland GmbH

Immanuelkirchstraße 26, 10405 Berlin

Amtsgericht Charlottenburg, HRB 209739 B

Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen

m: +491715557497

w: aiven.io

e: josep...@aiven.io

[Israel Ekpo]

Hi Community Members,

To encourage other community members to participate in the release candidate validations and voting, I have set up the following resource as part of the work for KAFKA-9861

It is a set of scripts and Docker images that allows community members to run local validations in a consistent manner.

https://github.com/izzyacademy/apache-kafka-release-party

Please take a look at the resource and share any feedback that you may have. I used it to perform my validation for the 3.0.0 Release Candidate.

I plan to create a video tutorial that walks community members through how it can be used soon. Stay tuned.

--
You received this message because you are subscribed to the Google Groups "kafka-clients" group.
To unsubscribe from this group and stop receiving emails from it, send an email to kafka-client...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/kafka-clients/CAOJ18G7pukzdy1ZAtg1ar2TSFfz7de20xXoPgj4Qr5XRQt0yrA%40mail.gmail.com.

[Josep Prat]

Hi David,

I agree with you, the faulty search shouldn't be a blocker for the release.

Best 

———
Josep Prat

Aiven Deutschland GmbH

Immanuelkirchstraße 26, 10405 Berlin

Amtsgericht Charlottenburg, HRB 209739 B

Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen

m: +491715557497

w: aiven.io

e: josep...@aiven.io

On Wed, Sep 15, 2021, 15:41 David Jacot <dja...@confluent.io> wrote:

Hi Israel,

Thanks! That seems pretty cool. You should bring it up in an independent

thread in order to give it more visibility. It might be lost in the middle of 

this vote thread.

Best,

David

On Wed, Sep 15, 2021 at 3:39 PM David Jacot <dja...@confluent.io> wrote:

Hi Chris, Josep,

Thank you for reporting the issue and explaining the fix. JDK11 was

indeed used to generate the javadoc. I don't consider this as a blocker

for the release as we can fix it independently.

Best,

David

> <https://groups.google.com/d/msgid/kafka-clients/CAOJ18G7pukzdy1ZAtg1ar2TSFfz7de20xXoPgj4Qr5XRQt0yrA%40mail.gmail.com?utm_medium=email&utm_source=footer>
> .
>

[Bill Bejeck]

HI David,

Thanks for running the 2.8.1 release!

I validated the release doing the following:

• built from source
• ran all the unit tests
• validated the checksums and signatures
• ran through the quick start
• ran through the quick start Kafka Streams application
  
• looked at the docs and javadoc

I noticed the same doc issues as Randall and I agree it's minor and can be fixed directly on the docs website

+1 (binding)

-Bill

On Wed, Sep 15, 2021 at 9:41 AM David Jacot <dja...@confluent.io.invalid> wrote:

Hi Israel,

Thanks! That seems pretty cool. You should bring it up in an independent
thread in order to give it more visibility. It might be lost in the middle
of
this vote thread.

Best,
David

On Wed, Sep 15, 2021 at 3:39 PM David Jacot <dja...@confluent.io> wrote:

> Hi Chris, Josep,
>
> Thank you for reporting the issue and explaining the fix. JDK11 was
> indeed used to generate the javadoc. I don't consider this as a blocker
> for the release as we can fix it independently.
>
> Best,
> David
>
> On Tue, Sep 14, 2021 at 11:37 PM Israel Ekpo <israe...@gmail.com> wrote:
>

>> https://groups.google.com/d/msgid/kafka-clients/CAOJ18G7pukzdy1ZAtg1ar2TSFfz7de20xXoPgj4Qr5XRQt0yrA%40mail.gmail.com?utm_medium=email&utm_source=footer
>> >
>> > .
>> >
>>
>

[Israel Ekpo]

No problem, David.

I will bring it up in a separate email thread later today.

On Wed, Sep 15, 2021 at 9:42 AM David Jacot <dja...@confluent.io.invalid> wrote:

Hi Israel,

Thanks! That seems pretty cool. You should bring it up in an independent
thread in order to give it more visibility. It might be lost in the middle
of
this vote thread.

Best,
David

On Wed, Sep 15, 2021 at 3:39 PM David Jacot <dja...@confluent.io> wrote:

> Hi Chris, Josep,
>
> Thank you for reporting the issue and explaining the fix. JDK11 was
> indeed used to generate the javadoc. I don't consider this as a blocker
> for the release as we can fix it independently.
>
> Best,
> David
>
> On Tue, Sep 14, 2021 at 11:37 PM Israel Ekpo <israe...@gmail.com> wrote:
>

>> https://groups.google.com/d/msgid/kafka-clients/CAOJ18G7pukzdy1ZAtg1ar2TSFfz7de20xXoPgj4Qr5XRQt0yrA%40mail.gmail.com?utm_medium=email&utm_source=footer
>> >
>> > .
>> >
>>
>

[Mickael Maison]

Hi David,

+1 (binding)
I checked the signatures, built from source, ran the tests and the quickstart.

Thanks for running this release!