GSoc 2011 - Undo Feature

[archie-sh]

Hi,
I'm Archibald Sheran from Univeridad Politecnica de Madrid in
Spain and I am enrolled in the Erasmus Mundus Master in Software
Engineering. I hope to participate with K-9 in the Google Summer of
Code 2011. I am proficient in Java and SQL and have both a SCJP and
Oracle SQL Expert certifications. Honestly, this would be my first
time working with Android but I am very eager to learn. I worked for
one and a half years in Mexico City on a project that involved Java,
Maven, Hibernate, SQL, Spring, DWR, JUnit, JasperReports, etc. on top
of a Weblogic Server running in SunOS 5.10. Most of the technologies I
had to work with I learnt on the go, so I have an idea of the
challenges and rewards of working in new areas.

As a start, I forked the code for K-9 from GitHub and imported it to
Eclipse. In the next couple of days I hope to at least fix a bug in
order to gain some experience working with K-9 and Android. In the
meantime, perhaps I can schedule a time to go on IRC to discuss about
the Undo feature and how it should be implemented. For example, when
selecting an e-mail on my phone there are 4 buttons (mark unread,
trash, star and close) that appear in the bottom of the phone's
screen, should Undo be included in the bar when the phone is not
connected to the internet (send messages from the trash back to
inbox), or when it is connected to the internet should Undo appear
after an action is executed and then disappear after a timeout?

It would be nice to discuss it so I can start looking at more or less
how the implementation would be and prepare a draft schedule for the
summer. I am very interested in K-9 and hope I can contribute to it.

Thank you in Advance for any time you can spare,

Archibald Sheran.

[Jesse Vincent]

On Mon 21.Mar'11 at 20:24:44 -0700, archie-sh wrote:
> As a start, I forked the code for K-9 from GitHub and imported it to
> Eclipse. In the next couple of days I hope to at least fix a bug in
> order to gain some experience working with K-9 and Android.

Hi Archibald,

How's the bugfixing going?

> In the
> meantime, perhaps I can schedule a time to go on IRC to discuss about
> the Undo feature and how it should be implemented. For example, when
> selecting an e-mail on my phone there are 4 buttons (mark unread,
> trash, star and close) that appear in the bottom of the phone's
> screen, should Undo be included in the bar when the phone is not
> connected to the internet (send messages from the trash back to
> inbox), or when it is connected to the internet should Undo appear
> after an action is executed and then disappear after a timeout?
>

We don't schedule so much as just hang around. Please do show up and
chat with whomever's around if you haven't already.

I'd sort of expect that following google's lead and having a
light-yellow bar pop up at the top of the screen after you perform an
undo-able operation would make more sense than trying to shove it into
that button bar.

Best,
Jesse

[archie-sh]

> How's the bugfixing going?

Hi, I had gone on IRC and spoken to cketti which recommended this bug
https://code.google.com/p/k9mail/issues/detail?id=2996#makechanges. I
noticed that the Spam option has already been separated from the Star
option by Archive. So I set out to inlcude an AlertDialog with an: Are
you sure? and a checkbox to not show again. I setup an AVD and
debugging I noticed that the change would probably need to be made in
the onSpam method on line 1133 of the
com.fsck.k9.activity.MessageList class. Right now I have made some
changes and I am in the process of testing it. Over the next couple of
days I should have something simple to show, I will also start hanging
around on the IRC.

Regards,

Archie.

On Mar 28, 7:50 am, Jesse Vincent <jes...@gmail.com> wrote:
> On Mon 21.Mar'11 at 20:24:44 -0700, archie-sh wrote:
>
> > As a start, I forked the code for K-9 from GitHub and imported it to
> > Eclipse. In the next couple of days I hope to at least fix a bug in
> > order to gain some experience working with K-9 and Android.
>
> Hi Archibald,
>

>

[archie-sh]

Just a quick update on what I am trying to do, I have the following
code which was mostly taken from the Android Developers Guide
http://developer.android.com/guide/topics/ui/dialogs.html

private void onSpam(final MessageInfoHolder holder) {

if (!mController.isMoveCapable(holder.message)) {
Toast toast = Toast.makeText(this,
R.string.move_copy_cannot_copy_unsynced_message, Toast.LENGTH_LONG);
toast.show();
return;
}
new AlertDialog.Builder(this)
.setMessage("Are you sure?")
.setCancelable(false)
.setPositiveButton("Yes", new
DialogInterface.OnClickListener() {
public void onClick(DialogInterface dialog, int id)
{
onMoveChosen(holder,
holder.message.getFolder().getAccount().getSpamFolderName());
}
})
.setNegativeButton("No", new
DialogInterface.OnClickListener() {
public void onClick(DialogInterface dialog, int id)
{
dialog.cancel();
}
})
.show();

}

It works, but it seems I need to create a custom AlertDialog in order
to put a checkbox on the bottom for "never show this again" like this
one http://i.imgur.com/B2wvC.png . And that is what I am doing right
now.

Regards,

Archie.

On Mar 28, 11:49 am, archie-sh <archie.she...@gmail.com> wrote:
> > How's the bugfixing going?
>

> Hi, I had gone on IRC and spoken to cketti which recommended this bughttps://code.google.com/p/k9mail/issues/detail?id=2996#makechanges. I

[archie-sh]

Hi, last week I opened a pull request https://github.com/k9mail/k-9/pull/8
which I later fixed https://github.com/archie-sh/k-9/tree/Issue_2996
and would like to thank cketti for all his help,

This week, since the deadline for applying to a GSoC project is this
Friday, I would like to present my project proposal
http://dl.dropbox.com/u/1113492/GSoC%20Project%20Proposal.pdf before
making the official one with Google.

I would appreciate any feedback on the proposal so I can make it
better.

Thanks in advance,

Archie.