Fixed issue #3049

[Sahil Jolly]

 Hi, just wanted to know If I have pulled a request ( cause I fixed an issue(bug label)), I don't know if it has been submitted in a correct format , will I be informed or will that request wouldn't be added if it is in incorrect format ? 

[Philip Whitehouse]

You made the pull request in your own repository.

You need to make it in the K-9 repository.

> --
> --
> You received this message because you are subscribed to the K9 Mail
> Dev List.
> To post to this group, send email to k-9...@googlegroups.com
> To post an issue, go to http://code.google.com/p/k9mail/issues/list
> [1]
> To unsubscribe, email k-9-dev+u...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/k-9-dev [2]
>
> ---
> You received this message because you are subscribed to the Google
> Groups "K-9 Mail Developers List" group.
> To unsubscribe from this group and stop receiving emails from it,
> send an email to k-9-dev+u...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout [3].
>
>
> Links:
> ------
> [1] http://code.google.com/p/k9mail/issues/list
> [2] http://groups.google.com/group/k-9-dev
> [3] https://groups.google.com/d/optout

[Philip Whitehouse]

To clarify on how to do this:

https://github.com/k9mail/k-9/pulls

-> New pull request

-> Click 'compare across forks'

-> Select your repository in the 'head fork' drop down

-> Select your branch in the 'compare' drop down

-> Check the changes are the ones you want

-> Click 'Create pull request'

> --

[Sahil Jolly]

hi sir , thank you for notifying me ,How to pull request in K-9 repository ? If I can get help on that , it would be great 

[Sahil Jolly]

Thank you Sir, I hope now i have pulled a request in the correct repository. 

On Wednesday, February 14, 2018 at 9:24:34 PM UTC+5:30, Sahil Jolly wrote:

[Sahil Jolly]

Hi , is there any other bug ( similar to issue #3049) which I can work upon and will I get notified if my pull request is accepted (one patch rule) ?

On Wednesday, February 14, 2018 at 9:24:34 PM UTC+5:30, Sahil Jolly wrote:

[Philip Whitehouse]

If you're referring to GSoC where we have that requirement you should know that we aren't entered for this year.

But feel free to submit PRs for any issue you feel you can solve.

--

--
You received this message because you are subscribed to the K9 Mail Dev List.
To post to this group, send email to k-9...@googlegroups.com
To post an issue, go to http://code.google.com/p/k9mail/issues/list

To unsubscribe, email k-9-dev+u...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/k-9-dev

---
You received this message because you are subscribed to the Google Groups "K-9 Mail Developers List" group.
To unsubscribe from this group and stop receiving emails from it, send an email to k-9-dev+u...@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

[Sahil Jolly]

Okay sir ,thanks alot , also when will you close that issue(#3049)?  

On Wednesday, February 14, 2018 at 9:24:34 PM UTC+5:30, Sahil Jolly wrote:

[Philip Whitehouse]

One of the project maintainers will need to accept and merge your PR for that to happen.

--