Jupyterhub - custom authenticator - how to override default /login handler

[Carl Waldbieser]

I'm writing a custom authenticator for jupyterhub that assumes the hub is behind an authenticating proxy and and that the authenticated username will be present in an HTTP header (e.g. REMOTE_USER).

I have the authenticator working, but I am not sure how to arrange things so that the main "/login" resource triggers it.
Currently, my authenticator's `get_handlers()` method looks like this:

    def get_handlers(self, app):
        return [
            (r'/remote_user_login', RemoteUserLoginHandler),
        ]

I can browse to "/remote_user_login", and I am logged in by virtue of the REMOTE_USER header populated by my proxy.  But I'd like the default "/login" resource to invoke my login handler.

Thanks,
Carl Waldbieser

[MinRK]

Do you want to change the login URL for a reason? Why not use (r'/login', RemoteUserLoginHandler)? You can override the login url by overriding the login_url(base_url) method, but I suspect putting your login handler on the default URL is the right thing to do, instead.

-MinRK

​

[Carl Waldbieser]

I tried returning `(r'/login', RemoteUserHandler)` from my authenticator's `get_handlers()` method (currently is "/remote_user_login" [1]), but when I press the "logout" button, I get redirected to the original login form (not automatically logged in as I would expect).  I wasn't sure you could return `r'/login'` and expect it to be overridden.

Thanks,
Carl

[1] https://github.com/cwaldbieser/jhub_remote_user_authenticator/blob/master/remote_user/remote_user_auth.py

[MinRK]

On Wed, Nov 4, 2015 at 8:39 PM, Carl Waldbieser <cwald...@gmail.com> wrote:

I tried returning `(r'/login', RemoteUserHandler)` from my authenticator's `get_handlers()` method (currently is "/remote_user_login" [1]), but when I press the "logout" button, I get redirected to the original login form (not automatically logged in as I would expect).  I wasn't sure you could return `r'/login'` and expect it to be overridden.

It should work. Can you check with the latest version of JupyterHub?

-MinRK

 

Thanks,
Carl

[1] https://github.com/cwaldbieser/jhub_remote_user_authenticator/blob/master/remote_user/remote_user_auth.py

On Wednesday, November 4, 2015 at 5:02:04 AM UTC-5, Min RK wrote:

Do you want to change the login URL for a reason? Why not use (r'/login', RemoteUserLoginHandler)? You can override the login url by overriding the login_url(base_url) method, but I suspect putting your login handler on the default URL is the right thing to do, instead.

-MinRK

​

--
You received this message because you are subscribed to the Google Groups "Project Jupyter" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jupyter+u...@googlegroups.com.
To post to this group, send email to jup...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jupyter/e76a5902-e493-46da-9f3a-3f6f06ce3eef%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

[Carl Waldbieser]

I pull up to HEAD on master, and I still get the main login page instead of my custom authenticator redirecting.

Should I open an issue?

Thanks,
Carl

[Carl Waldbieser]

Actually, I found at the bottom of `jupyterhub/handlers/login.py` there is a bit of code:

# Only logout is a default handler.
default_handlers = [
    (r"/login", LoginHandler),
    (r"/logout", LogoutHandler),
]

The comment doesn't seem to match the code.  If I comment out the "/login" handler, my own "/login" handler is installed.  I can see in `app.py` where the default is installed *before* any handlers from the authenticator.

Thanks,
Carl

[MinRK]

Ah, you are right. I don't think that's quite how it should work. Right now, you would have to put your handler on a different URL *and* override the login_url method. I'll clean that up. Feel free to open an issue.

-MinRK

--
You received this message because you are subscribed to the Google Groups "Project Jupyter" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jupyter+u...@googlegroups.com.
To post to this group, send email to jup...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jupyter/e4103d7d-d83c-4d7b-a09f-9564797b8a97%40googlegroups.com.