Hi,
I've been spending a lot of time looking for a light-weight, team oriented code reviewing tool that doesn't leave breadcrumbs in reviewed files. I've toyed with Jupiter in the past but have not made a big push for the team I work with to adopt it. I am revisiting Jupiter now that I have more experience on this project and its development practices/processes.
We have our code base in SVN. It is a huge code base, and currently, is used by most of the development community and a giant monolithic monster single eclipse project. My personal (and that of several other team members) setup was to break it out into smaller individual projects. So we have a bit of a dichotomy that won't play well with the approach that Jupiter uses of having a .jupiter file in each Eclipse project.
What I want to be able to do is to have the .jupiter file and the reviews folder (and contents) be in a separate Eclipse code reviews project. This allows me to organize reviews centralized location and maintain them in a separate repository if I choose to (which is exactly what I want to do).
The changes to accommodate this don't appear to be horrible. The review file would need to include the Eclipse project in which the source file resides, rather than to assume it is in the same project as the review. So far, I don't see anything in the .jupiter file that requires it to be tied to the Eclipse source code project(s).
So here's how the flow would work. My source repository is SVN and my code review repository is Jazz SCM (similar to GIT).
- I create an eclipse code review project in my workspace and associate it with a Jazz SCM workspace I would use for our project's code reviews.
In fact, having it the project supported as a Jupiter code review project instead of some generic project would be ideal. - Define a new code review, specifying the defaults and the files to be reviewed. The files reviewed could be spread across a number of other eclipse projects. Here's the catch, those projects could have different names in the workspaces of the other reviewers on the team. So when a reviewer wants to review, they need to specify which project in their workspace should be used for each file or group of files. The Jupiter plugin needs to be able to handle this.
- Perform my review, making comments for the various files in the review.
- Integrate my review into the SCM for the code review project.
What do you think?