Re: [julia] fix #10186, `a[a] = x` (f8973cb)

Stefan Karpinski

unread,

Feb 14, 2015, 1:25:48 PM2/14/15

to JuliaLang/julia, Julia Backports

@JuliaBackports?

—
Reply to this email directly or view it on GitHub.

Ivar Nesje

unread,

Feb 14, 2015, 3:38:03 PM2/14/15

to JuliaLang/julia, Julia Backports

Yes, that seemed relevant. I labeled the issue so that we'll see this again.

Tony Kelman

unread,

Feb 14, 2015, 3:43:27 PM2/14/15

to JuliaLang/julia, Julia Backports

probably harmless enough to squeeze in before 0.3.6? hard to see how this could cause any trouble

Elliot Saba

unread,

Feb 14, 2015, 4:53:15 PM2/14/15

to JuliaLang/julia, Julia Backports

Agreed, let's just backport this.

Elliot Saba

unread,

Feb 14, 2015, 4:54:42 PM2/14/15

to JuliaLang/julia, Julia Backports

Cherry-picked in 723280c

Tim Holy

unread,

May 15, 2015, 8:55:16 AM5/15/15

to JuliaLang/julia, Julia Backports

Hmm, this commit made the loop type-unstable (I either has typeof(X) or its original type), which really kills performance.

Tim Holy

unread,

May 15, 2015, 8:56:42 AM5/15/15

to JuliaLang/julia, Julia Backports

I can fix later, if no one beats me to it, but I have other obligations first.

Matt Bauman

unread,

May 15, 2015, 9:25:03 AM5/15/15

to JuliaLang/julia, Julia Backports

I have the fix in #10525, too. I should have just pushed it to master right away.

Matt Bauman

unread,

May 15, 2015, 10:49:03 AM5/15/15

to JuliaLang/julia, Julia Backports

0ef256c

Reply all

Reply to author

Forward