Re: [julia] Check if argument is NULL in jl_f_apply. Fix #11772 (#11773)

22 views
Skip to first unread message

Yichao Yu

unread,
Jun 20, 2015, 11:50:09 AM6/20/15
to JuliaLang/julia, Julia Backports

@JuliaBackports ?


Reply to this email directly or view it on GitHub.

pao

unread,
Jun 22, 2015, 2:20:38 PM6/22/15
to JuliaLang/julia, Julia Backports

I think the tag is the "proper" way to add to the backport list now; I'm not sure anyone is actively watching the user account? We added both at about the same time because we weren't sure what was going to be most convenient. I'm honestly not sure, but since this has sat for a couple of days, let's give it a go.

Yichao Yu

unread,
Jun 22, 2015, 2:25:43 PM6/22/15
to JuliaLang/julia, Julia Backports

It is already backported in #11786.

pao

unread,
Jun 22, 2015, 3:57:19 PM6/22/15
to JuliaLang/julia, Julia Backports

Ah. Guess it didn't crossreference because the only mention of this issue number was in the title?

Tony Kelman

unread,
Jun 22, 2015, 4:00:59 PM6/22/15
to JuliaLang/julia, Julia Backports

I watch the julia-backports mailing list, but it's less visible than the label. I prefer people use the label when there's a corresponding issue or pull request that goes along with the proposed backport, and only ping the @juliabackports user for un-attached commits. Or for non-collaborators who don't have permissions to modify issue/pr labels.

I still need to write down my personal backporting policy to make it more formal.

Yichao Yu

unread,
Jun 22, 2015, 4:01:41 PM6/22/15
to JuliaLang/julia, Julia Backports

Ah. Guess it didn't crossreference because the only mention of this issue number was in the title?

Right. I always forgot about that, especially when refering a closed issue.... = = ................

pao

unread,
Jun 22, 2015, 4:02:38 PM6/22/15
to JuliaLang/julia, Julia Backports

No problem, @yuyichao. And I think that @tkelman's personal backporting policy is de facto the Julia backporting policy, so it would be cool to have that as a reference.

Tony Kelman

unread,
Jun 22, 2015, 4:07:30 PM6/22/15
to JuliaLang/julia, Julia Backports

If there isn't already an entry for the lack of cross-references from issue/pr titles at https://github.com/isaacs/github/issues, there should be

pao

unread,
Jun 22, 2015, 5:01:55 PM6/22/15
to JuliaLang/julia, Julia Backports

That doesn't seem like a particularly effective outlet, looking at the closed issue list. Contacting GitHub directly seems like a better choice (and it has worked for me in the past.)

Reply all
Reply to author
Forward
0 new messages