Adding modal dialog option for a "not ok" button

45 views
Skip to first unread message

willray

unread,
Aug 9, 2013, 12:48:49 PM8/9/13
to jstal...@googlegroups.com

Gus,

Could I impose upon you to add something like the following to JSTalk as distributed with VoodooPad?

(in JSTExtras.m)

- (NSInteger) displayDialog:(NSString*)msg withTitle:(NSString*)title withOK:(NSString*)oktxt withNOK:(NSString*)noktxt {

    

    NSAlert *alert = [NSAlert alertWithMessageText:title defaultButton:oktxt alternateButton:noktxt otherButton:nil informativeTextWithFormat:msg];

    

    NSInteger button = [alert runModal];

    

    return button;

}


I have a voodoopad application that I'm finally getting around to updating to VP5.  My VP4 version is running a private hacked JSTalk with that tweak to give me dialogs that a user can cancel, as well as accept.  I'd like to distribute what I've built in VoodooPad to a wider audience, but I'd rather not require them to install a custom JSTalk version into the software.


I'm not familiar/fluid enough with github to easily jump into the git model of development and send you a pull request, but if you'd like, I can fuddle through that to get the edit up to you in-place.




If I can get this all working in a default installation of VoodooPad, I'm happy to share the base application (a rather deeply automated lab-notebook type diary) with the community.


Will Ray


August Mueller

unread,
Aug 9, 2013, 11:46:06 PM8/9/13
to jstal...@googlegroups.com
Yea, I can see about getting that in there.  If you want to add a patch to JSTExtras.m on the mocha branch, that'll get it added faster.  Though I do really want to get some time to work on JSTalk 2.0, which this could easily go into.

-gus


--
You received this message because you are subscribed to the Google Groups "JSTalk Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jstalk-dev+...@googlegroups.com.
To post to this group, send email to jstal...@googlegroups.com.
Visit this group at http://groups.google.com/group/jstalk-dev.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

willray

unread,
Aug 14, 2013, 4:34:33 PM8/14/13
to jstal...@googlegroups.com
Can you give me a real-quick-like pointer to how I find, and patch, the mocha branch?

I'm a dinosaur.  I speak SCCS, and can muddle my way along with some pain in systems as modern as SVN, but git confuses me.

I'm happy to contribute to your JSTalk/etc development efforts where I can - I have quite a lot of plans for what I'd like to do with VoodooPad, and hacking additional functionality into JSTalk will certainly help with that.   I'm pretty crappy with modern source-control systems, but code, that I grok...

Will

August Mueller

unread,
Aug 15, 2013, 7:54:43 PM8/15/13
to jstal...@googlegroups.com
On Aug 14, 2013, at 1:34 PM, willray <wil...@mac.com> wrote:

Can you give me a real-quick-like pointer to how I find, and patch, the mocha branch?

I'm a dinosaur.  I speak SCCS, and can muddle my way along with some pain in systems as modern as SVN, but git confuses me.

cd jstalk
git checkout Mocha

Now you're working on the Mocha branch!

You can also use GitHub's Mac client which might be a bit fancier:

So you can fork JSTalk, then check out your guy, switch branches, and then push them back to your fork and send me a pull request.

-gus


willray

unread,
Aug 19, 2013, 3:33:49 PM8/19/13
to jstal...@googlegroups.com

Well, let's see if that does it.

I'm still a little fuzzy on my understanding of the branches and forks concepts, but I think I've got edits in the right file, and pushed back up to github...

Will

Reply all
Reply to author
Forward
0 new messages