question about @MvcBinding
16 views
Skip to first unread message
RPE Colorado
Apr 11, 2018, 2:32:27 PM4/11/18
to MVC 1.0 Users Mailing List
Hi everyone,
Looking back in the list archives I can see that parameter binding and @MvcBinding was discussed not too long ago. I had a question regarding its implementation: Is there a reason why @MvcBinding is not allowed to be used on a method, such as a getter?
The main reason I'm asking is because I'm working on how to deal with some existing models that I'd like to create simple MVC CRUD forms for. These existing models have bean validation constraint annotations applied, but no decorations for JAX-RS or MVC. I'd like to subclass these existing models to add the necessary @FormParam and @MvcBinding annotations to have the subclasses work as my MVC models. Subclassing and adding @FormParam to a setter method works (see footnote below), but since @MvcBinding isn't allowed on a method I don't have a good way to bind the bean validation annotations on my superclass bean to the MVC subclass.
For example, in Ivar Grimstad's Ozark MVC examples repo on github, this is what the HelloBean model looks like in the hello example:
public class HelloBean {
@MvcBinding
@NotNull
@Size(min = 1, max = 16)
@FormParam("firstName")
private String firstName;
@MvcBinding
@NotNull
@Size(min = 1, max = 24)
@FormParam("lastName")
private String lastName;
public String getFirstName() {
return firstName;
}
public void setFirstName(String firstName) {
this.firstName = firstName;
}
public String getLastName() {
return lastName;
}
public void setLastName(String lastName) {
this.lastName = lastName;
}
}
What I'm trying to do is work with a base bean that looks like:
public class HelloCore {
private String firstName;
private String lastName;
@NotNull
@Size(min = 1, max = 16)
public String getFirstName() {
return firstName;
}
public void setFirstName(String firstName) {
this.firstName = firstName;
}
@NotNull
@Size(min = 1, max = 24)
public String getLastName() {
return lastName;
}
public void setLastName(String lastName) {
this.lastName = lastName;
}
}
And then extend that bean to be an MVC model like:
public class HelloBean extends HelloCore {
@Override
@MvcBinding
public String getFirstName() {
return super.getFirstName();
}
@Override
@FormParam("firstName")
public void setFirstName(String firstName) {
super.setFirstName(firstName);
}
@Override
@MvcBinding
public String getLastName() {
return super.getLastName();
}
@Override
@FormParam("lastName")
public void setLastName(String lastName) {
super.setLastName(lastName);
}
}
But I can't do that due to the restrictions on the @MvcBinding annotation.
I did a quick test, modifying the @MvcBinding annotation to also support methods, and then modifying org.mvcspec.ozark.binding.validate.ConstraintViolations to also check getter methods for @MvcBinding, and that got things working per my example above.
So that's why I'm asking if there is a reason why @MvcBinding isn't currently supported on methods? Or can you think of an alternate approach I should be taking for this sort of operation?
(Footnote about using @FormParam on the setter method like I do in my example - This may not always be portable, as the javadocs for @FormParam say that implementations are only required to support it on method parameters, and not for fields or methods. That said, I've tested with RESTeasy+Wildfly11 and Glassfish5 and both work fine.)
Thanks!
Chris
Christian Kaltepoth
Apr 12, 2018, 1:57:50 PM4/12/18
to MVC 1.0 Users
Hi Chris,
thanks a lot for bringing this up! Very good catch. I think I just missed to include ElementType.METHOD back then. IMO it absolutely makes sense to support @MvcBinding on the same element types as the @*Param annotations of JAX-RS.
I just created a pull request for the spec to add ElementType.METHOD:
I hope to get this one merged really soon. If you already experimented with the required changes in Ozark's ConstraintViolations, I would be more than happy if you could provide a pull request.
Christian
--
You received this message because you are subscribed to the Google Groups "MVC 1.0 Users Mailing List" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jsr371-users...@googlegroups.com.
To post to this group, send email to jsr371...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jsr371-users/aeb9083e-e297-419b-93fc-6637c49be438%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
RPE Colorado
Apr 12, 2018, 2:54:10 PM4/12/18
to jsr371...@googlegroups.com
Hi Christian,
Thanks for the reply! I figured it was just an oversight, but wanted to be sure. I'll get a PR with my changes created here in the next hour or two.
Chris
To unsubscribe from this group and stop receiving emails from it, send an email to jsr371-users+unsubscribe@googlegroups.com.
To post to this group, send email to jsr371...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jsr371-users/aeb9083e-e297-419b-93fc-6637c49be438%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--
--
You received this message because you are subscribed to the Google Groups "MVC 1.0 Users Mailing List" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jsr371-users+unsubscribe@googlegroups.com.
To post to this group, send email to jsr371...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jsr371-users/CAEXeC6yVGNmcB0ufi%2BKLQXNAB0d6fwn8VnB%3Dmf3W4rryjv%2B-dQ%40mail.gmail.com.
Christian Kaltepoth
Apr 13, 2018, 2:02:15 AM4/13/18
to MVC 1.0 Users
Awesome! Thanks a lot! I'll take a look at the PR ASAP.
To unsubscribe from this group and stop receiving emails from it, send an email to jsr371-users...@googlegroups.com.
To post to this group, send email to jsr371...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jsr371-users/aeb9083e-e297-419b-93fc-6637c49be438%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--
--
You received this message because you are subscribed to the Google Groups "MVC 1.0 Users Mailing List" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jsr371-users...@googlegroups.com.
To post to this group, send email to jsr371...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jsr371-users/CAEXeC6yVGNmcB0ufi%2BKLQXNAB0d6fwn8VnB%3Dmf3W4rryjv%2B-dQ%40mail.gmail.com.
--
You received this message because you are subscribed to the Google Groups "MVC 1.0 Users Mailing List" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jsr371-users...@googlegroups.com.
To post to this group, send email to jsr371...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jsr371-users/CAK75t5uVxecaNpQJx1%3DA9vW0no13FKGvxwOX-kK9Vp1kDjqm3w%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
Reply all
Reply to author
Forward
0 new messages