CheckForSigned is misnamed

47 views
Skip to first unread message

Elliotte Harold

unread,
Aug 16, 2008, 1:32:40 PM8/16/08
to jsr...@googlegroups.com
The @CheckForSigned annotation is misnamed. According to the comments, it is

Used to annotate a value that may be negative; uses of it should check
for negative values before using it in a way that requires the value to
be nonnegative


Clearly the name shoudl be @CheckForNegative, not @CheckForSigned.
Alternately, if it really is a sign check, then the comment needs to be
improved.

--
Elliotte Rusty Harold elh...@metalab.unc.edu
Refactoring HTML Just Published!
http://www.amazon.com/exec/obidos/ISBN=0321503635/ref=nosim/cafeaulaitA

Bill Pugh

unread,
Aug 25, 2008, 12:56:46 AM8/25/08
to jsr...@googlegroups.com
The way the type qualifiers and when attributes work, it really means
that the element labeled will contain both elements in the set
Nonnegative and elements in the complement of Nonnegative.

So the annotation name is correct, I'll fix the documentation.

Bill

Reply all
Reply to author
Forward
0 new messages