DOM 1.6.0. Uncaught TypeError: Cannot read property 'tagName' of null

[Wojciech Makowiecki]

1. Hi,

I'm getting this in the newest dev version.

1. 
   
2. Uncaught TypeError: Cannot read property 'tagName' of null dom.jsPlumb-1.6.0.js:909
1. _eachdom.jsPlumb-1.6.0.js:909
2. _unbinddom.jsPlumb-1.6.0.js:891
3. Mottle.offdom.jsPlumb-1.6.0.js:994
4. jsPlumb.extend.offdom.jsPlumb-1.6.0.js:11117
5. window.jsPlumbInstance.unregisterListenerdom.jsPlumb-1.6.0.js:4970
6. window.jsPlumbInstance.unmakeSourcedom.jsPlumb-1.6.0.js:4782
7. window.jsPlumbInstance.unmakeEverySourcedom.jsPlumb-1.6.0.js:4794
3. 
   Best,
4. Wojciech

[Simon Porritt]

This isn't very useful without some context....

[Simon Porritt]

...but of course the stack shows the original call. Ok. I will take a look.

[Simon Porritt]

i cant reproduce in my unit tests. perhaps you could post a test case?

[Wojciech Makowiecki]

It's difficult to put it in the fiddle

so let me describe what I'm doing.

1. I'm detaching all connections that have a source or target at #node_id

element by using jsPlumb.detach(connection);

2. I'm deleting that node from DOM $("#node_id").remove();

3. I'm using jsPlumb.unmakeEverySource(); // and here comes the error

It worked fine on previous versions of jsPlumb,

so it has to do with 1.6.0. DOM

On Fri, Feb 28, 2014 at 8:56 PM, Simon Porritt <simon....@gmail.com> wrote:

i cant reproduce in my unit tests. perhaps you could post a test case?

--
You received this message because you are subscribed to the Google Groups "jsPlumb" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jsplumb+u...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Simon Porritt]

If you’re not using jsPlumb.remove, which you should do when you want to remove an element from the DOM and have it cleaned up, then yes, jQuery-based versions of jsPlumb would not have thrown the error, as jQuery’s selector stuff glosses over the case that you try to perform an operation on an empty set. Well perhaps “glosses over” is unfair, because in most cases it’s very useful. Either way, it doesn’t crash.

In this case you’ve removed the element from the DOM and then subsequently asked jsPlumb to unregister a bunch of event listeners from it (that’s what unmakeSource does, basically). Since it doesn’t exist anymore, and Mottle - the new library I’m using for events - doesn’t expect null as an argument, you see this error.

I will update Mottle to gracefully handle null input. But I’d recommend to you to switch to using jsPlumb.remove anyway.

[Wojciech Makowiecki]

Aha! Thank you Simon! 

No, I wasn't using jsPlumb.remove,

I will update my code and let you know how that goes!

--

[Wojciech Makowiecki]

So I used:

jsPlumb.remove($(elem_to_remove));

It removed the element, all of its connections and even arrows pointing to labels of these connections, which is all very good,

but I'm still getting exactly the same error as before when I use jsPlumb.unmakeEverySource();

after running jsPlumb.remove();

Would you have other suggestions ?

[Simon Porritt]

I've updated the beta versions of 1.6.0. Grab the latest...

[Wojciech Makowiecki]

Great, thanks!

On Sat, Mar 1, 2014 at 10:33 PM, Simon Porritt <simon....@gmail.com> wrote:

I've updated the beta versions of 1.6.0. Grab the latest...

--

[Wojciech Makowiecki]

Hm, I'm getting the same error :(

[Simon Porritt]

You might have to put together a fiddle then.

[Wojciech Makowiecki]

I'll see what I can do, but for now will just catch the error,

as I have one deadline approaching.

On Sat, Mar 1, 2014 at 10:52 PM, Simon Porritt <simon....@gmail.com> wrote:

You might have to put together a fiddle then.

--

[Simon Porritt]

No problem.

[Wojciech Makowiecki]

I'm getting the same error by calling another function (different stack as well)

1. Uncaught TypeError: Cannot read property 'tagName' of null dom.jsPlumb-1.6.0.js:3338
1. _getParentFromParamsdom.jsPlumb-1.6.0.js:3338
2. _newEndpointdom.jsPlumb-1.6.0.js:3353
3. addEndpointdom.jsPlumb-1.6.0.js:3599

On Sunday, March 2, 2014 12:49:29 AM UTC+1, simon....@gmail.com wrote:

No problem.

[Wojciech Makowiecki]

I figured out that this happened because I was trying to add an endpoint

to a div that didn't exist at that time.

--