Merge jShoulda into JsUnitTest

[Dr Nic]

I use jShoulda all the time now. I'm annoyed now at my own jsunittest
generators (found in newjs) that start with TestCase instances; when I
then just rip them out and put in context blocks.

Are you interested/happy in merging jShoulda into JsUnitTest + create
a JsUnitTest 2.0 and do a big release. We could/would also merge the
tmbundles etc. We'd also merge in the ajax mocking code + simulated
clicking from another library I have.

JsUnitTest used to be a clone of Unittest from PrototypeJS, but a year
later I think it could take on its own persona.

Thoughts? Or would you prefer they were two projects?

[Choan Gálvez]

Hi Dr Nic.

Nice to know you're using jShoulda :)

On Feb 22, 2009, at 08:05 , Dr Nic wrote:

> I use jShoulda all the time now. I'm annoyed now at my own jsunittest
> generators (found in newjs) that start with TestCase instances; when I
> then just rip them out and put in context blocks.

There's a patched repo at <http://github.com/choan/newjs/tree/
jshoulda> with added support for generating tests using jShoulda.

> Are you interested/happy in merging jShoulda into JsUnitTest + create
> a JsUnitTest 2.0 and do a big release. We could/would also merge the
> tmbundles etc. We'd also merge in the ajax mocking code + simulated
> clicking from another library I have.
>
> JsUnitTest used to be a clone of Unittest from PrototypeJS, but a year
> later I think it could take on its own persona.
>
> Thoughts? Or would you prefer they were two projects?

Not sure, I'd like to hear users opinions. These are my objections:

* jShoulda is currently a wrapper compatible with both JsUnitTest and
Prototype-UnitTest. (There is a TODO item telling me that somewhere in
time I had plans to make it work on YUI Test too.) I'd like –though I
personally don't use Prototype-UnitTest– to keep the compatibility.
I'm not sure we can keep compatibility in case of merging. If jShoulda
continues living on its own, its library could still provide core-
jshoulda-syntax an provide wrappers to run on JsUnitTest, YUITest,
WadusTest, etc. (Or the other way around, a testing framework could
take the jshoulda-core and provide its wrapper.)

That's it, just one. But a strong one.

About the JsUnitTest project: nice to know you are working on it
again :) If I had to make a feature request, it would be "Oh, please,
decouple the logger". I will be happy to take that same request and
code it ;)

Best.
--
Choan

[Dr Nic Williams]

The newjs patch may solve my real problem - thanks for that - so perhaps they don't need to be merged. If you want to fix the logger issue, that's perfectly fine with me. I'll merge patches.

Having said that I have 35 unread github emails from the last 6 mths on various projects. I should to hire someone to clear them out :) I wonder if you can outsource that job on elance.com :)

Nic

--
Dr Nic Williams
Mocra - Premier iPhone and Ruby on Rails Consultants
w - http://mocra.com
e - dr...@mocra.com
p - +61 412 002 126 or +61 7 3102 3237
skype - nicwilliams

[Choan Gálvez]

On Feb 22, 2009, at 23:05 , Dr Nic Williams wrote:

> The newjs patch may solve my real problem - thanks for that - so
> perhaps
> they don't need to be merged.

Cool, though I'm afraid my patch is not in the better style :(... and
is dated... I'm afraid it includes an old version of jShoulda. I'll
try to repatch tomorrow.

> If you want to fix the logger issue, that's
> perfectly fine with me. I'll merge patches.

I'll do :)

> Having said that I have 35 unread github emails from the last 6 mths
> on
> various projects.

Sure, I sent at least 36 of them XD

Best.
--
Choan
<http://choangalvez.nom.es/>

[Dr Nic Williams]

Its ok, I'll figure out a way to automatically pull down latest versions of jsunittest + jshoulda into the generators. Probably via vendor/ submodules + a rake task. 

[nlloyds]

I was planning on creating a branch of jsunittest and adding the
Test.context from Scriptaculous, then I found jShoulda, so +1 and
merging them.

Thanks,

Nathan

[Choan Gálvez]

Hi Nathan.

I stated my only objection on a previous mail—I'd like to keep
compatibility with Prototype-UnitTest and maybe allow jShoulda to act
as a wrapper to other testing frameworks.

As I cannot see any real benefit from merging, I'm somewhat reluctant
to go on with the merge.

If you think of some visible benefit, please tell us and I'll
reevaluate my position.

Best.
--
Choan

[Dr Nic Williams]

newjs 1.7.0 now has nice jshoulda integration in its generators, thanks to Choan's efforts. It packages the latest jshoulda + jsunittest via some rake tasks.

Most newjs generators should now take the -j + --jshoulda option.

[nlloyds]

> I stated my only objection on a previous mail—I'd like to keep  
> compatibility with Prototype-UnitTest and maybe allow jShoulda to act  
> as a wrapper to other testing frameworks.

I think Prototype is using the regular JsUnitTest as a submodule in
the dev version now, but it would be cool to have other unit test
frameworks able to use it (though there are many, and I haven't seen
any I like as much as JsUnitTest.)

> As I cannot see any real benefit from merging, I'm somewhat reluctant  
> to go on with the merge.
>
> If you think of some visible benefit, please tell us and I'll  
> reevaluate my position.

Since they're both included with jShoulda, and newjs works with both,
I guess there's no good reason to. If someone else really wants to
there's no stopping them anyway.

Thanks,

Nathan