Test.Builder.TestResult

0 views
Skip to first unread message

Marvin Humphrey

unread,
Aug 23, 2007, 11:28:12 PM8/23/07
to jsan-a...@googlegroups.com
Greets,

I've been granted commit access to the Test.Simple repository, but
I'm still going to submit my patches to this list for review.

This one adds the Test.Builder.TestResult class. Though the patch is
larger than the last two, for the most part it is straightforward,
replacing what had been straight-up assignment/access operations with
set/get accessors.

One quirk: for the sake of consistency, the actual_ok/actualOK
controversy has been resolved in favor of actualOK. However, the
data structure provided by details() must include "actual_ok", as
that's what's documented in the public API -- so instead of providing
the raw TestResult objects, an export function is called which
preserves backwards compatibility.

Test.Builder.prototype.details = function () {
- return this.TestResults;
+ var details = new Array();
+ for (var i = 0; i < this.TestResults.length; i++) {
+ var result = this.TestResults[i];
+ details.push(result ? result.exportDetails() : null);
+ }
+ return details;
};

Patch is attached, but has already been committed as revision 518.

Marvin Humphrey
Rectangular Research
http://www.rectangular.com/

TestResult.diff

David E. Wheeler

unread,
Aug 28, 2007, 1:29:28 PM8/28/07
to jsan-a...@googlegroups.com
On Aug 23, 2007, at 20:28, Marvin Humphrey wrote:

> Patch is attached, but has already been committed as revision 518.

Looks good to me, Marvin. Thanks!

David

Reply all
Reply to author
Forward
0 new messages