how to run tests

[Ondrej Certik]

Hi,

here is how to run our tests:

$ git clone git://github.com/mattpap/py2js.git
$ cd py2js
$ ./run_tests.py
Testing the file: tests/test_builtins.js [OK]
Testing the file: tests/test_compile_js.py [OK]
Testing the file: tests/test_python.py [OK]
Testing the file: tests/test_run_js.py [OK]


You need to have a "js" binary in your PATH, in Ubuntu, just install
the spidermonkey-bin package:

apt-get install spidermonkey-bin

The tests/test_builtins.js tests the py-builtins.js library.
test_compile_js.py tests that the py2js can compile the stuff.
test_python.py tests our Python generator (that's an obsolete code, I
thought that I would have a translator both into python and js, using
opcodes, but I have abandoned this approach and just use a simple AST
and generate javascript).
And finally tests/test_run_js.py generates the JS, runs it through
the "js" interpreter (whatever you have installed) and then compares
the result, e.g. here is an example:


function dict3() {
var a = dict({});
a.__setitem__(1, 3);
a.__setitem__("s", 4);
var b = (a.__getitem__(1))+(a.__getitem__("s"));
return b;
}
assert(dict3() == 7);

where assert() raises an exception if it's not true, so if you run
this in "js", you can just check the exit code of the "js" using
os.system() and if it's 0, you are ok, if it's not 0, the test has
failed. That way you just check that everything works as it should and
we are fine. Advantage is that you don't need any web browser and in
principle you can test everything and you just run a simple script and
it tells you either [OK], or [FAIL], so you can immediately see if
your patch is ok, or if you broke something. No need to manually
examine some long output.


How can I run your tests? I tried:

python overview_tests.py

this returns some REST code. It seems that I have to manually examine
all tests. Right?

Then I tried to run:

$ bash unittest.sh
[lots and lots of errors]
[...]
======================================================================
FAIL: Executing: tests/libraries/xmlwriter
----------------------------------------------------------------------
Traceback (most recent call last):
File "py2js_test.py", line 121, in runTest
self.assertEqual(self.gtest.completed,True,"Generation Error:
"+self.gtest.error)
AssertionError: Generation Error: 'AttributeLookup' object has no
attribute 'first'

----------------------------------------------------------------------
Ran 120 tests in 1.823s

FAILED (failures=76)


so I must be doing something wrong.

Let's get this working first and then I'll port our py2js to satisfy your tests.

Ondrej

--
You received this message because you are subscribed to the Google Groups "JavaScript for Python programmers" group.
To post to this group, send an email to js...@googlegroups.com.
To unsubscribe from this group, send email to js4py+un...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/js4py?hl=en-GB.

[Peter Rust]

> How can I run your tests? I tried:
> python overview_tests.py
> this returns some REST code

I had a print of the generated wiki in there -- I removed and committed this
afternoon -- if you pull the latest, it should only show the tests that
passes (first), the test that fails (middle) and the test that passes
(last). These are documentation-example tests that check the "beauty" of the
generated code, character-for-character, to ensure it matches what we're
telling people on the wiki.

> $ bash unittest.sh
These are the original tests -- I haven't installed the spidermonkey
standalone engine yet, I'll take a look later this evening and see if I can
get them to run.

-- peter

[Ondrej Certik]

On Thu, Apr 29, 2010 at 3:52 PM, Peter Rust <pe...@cornerstonenw.com> wrote:
>> How can I run your tests? I tried:
>> python overview_tests.py
>> this returns some REST code
> I had a print of the generated wiki in there -- I removed and committed this
> afternoon -- if you pull the latest, it should only show the tests that
> passes (first), the test that fails (middle) and the test that passes
> (last). These are documentation-example tests that check the "beauty" of the
> generated code, character-for-character, to ensure it matches what we're
> telling people on the wiki.

I see and I agree.

>
>> $ bash unittest.sh
> These are the original tests -- I haven't installed the spidermonkey
> standalone engine yet, I'll take a look later this evening and see if I can
> get them to run.

Ok, cool, looking forward. Let me know if you manage to get them run.
I think this is extremely important.

[Ondrej Certik]

I took the latest py2js from js4py at googlecode, applied this change:


Index: unittest.sh
===================================================================
--- unittest.sh (revision 52)
+++ unittest.sh (working copy)
@@ -10,6 +10,6 @@
# setup PYTHONPATH
export PYTHONPATH=`pwd`/modules/python

-python py2js_test.py
+python2.5 py2js_test.py

cd $origd


and then run it:


$ bash unittest.sh
Generating...
...complete (0) errors.

Executing: tests/basic/break ... ok
Executing: tests/basic/trueorfalse ... ok
Executing: tests/basic/raise ... ok
Executing: tests/basic/class ... ok
Executing: tests/basic/del_attr ... ok
Executing: tests/basic/default ... ok
Executing: tests/basic/embedding ... ok
Executing: tests/basic/oo_inherit ... ok
Executing: tests/basic/nestedclass ... ok
Executing: tests/basic/vargs ... ok
Executing: tests/basic/listcomp2 ... ok
Executing: tests/basic/sumcomp ... ok
Executing: tests/basic/binaryops ... ok
Executing: tests/basic/globalvar ... ok
Executing: tests/basic/oo_static_inherit ... ok
Executing: tests/basic/vars ... ok
Executing: tests/basic/del_local ... ok
Executing: tests/basic/del_slice ... ok
Executing: tests/basic/closure ... ok
Executing: tests/basic/augassign ... ok
Executing: tests/basic/for_xrange ... ok
Executing: tests/basic/logicalops ... ok
Executing: tests/basic/fib ... ok
Executing: tests/basic/for_step ... ok
Executing: tests/basic/oo ... ok
Executing: tests/basic/del_dict ... ok
Executing: tests/basic/continue ... ok
Executing: tests/basic/for_in ... ok
Executing: tests/basic/tuple ... ok
Executing: tests/basic/del_array ... ok
Executing: tests/basic/print ... ok
Executing: tests/basic/scope ... ok
Executing: tests/basic/oo_diamond ... ok
Executing: tests/basic/kwargs ... FAIL
Executing: tests/basic/assign_slice ... ok
Executing: tests/basic/try ... ok
Executing: tests/basic/literals ... ok
Executing: tests/basic/lambda ... ok
Executing: tests/basic/dictionary ... ok
Executing: tests/basic/keys ... ok
Executing: tests/basic/docstring ... ok
Executing: tests/basic/helloworld ... ok
Executing: tests/basic/del_global ... ok
Executing: tests/basic/list ... ok
Executing: tests/basic/multiassign ... ok
Executing: tests/basic/super ... ok
Executing: tests/basic/valueerror ... ok
Executing: tests/basic/while ... ok
Executing: tests/basic/generator ... ok
Executing: tests/basic/float2int ... ok
Executing: tests/basic/pass ... ok
Executing: tests/basic/none ... ok
Executing: tests/functions/lshift ... ok
Executing: tests/functions/sort ... ok
Executing: tests/functions/divfloor ... ok
Executing: tests/functions/len ... ok
Executing: tests/functions/or ... ok
Executing: tests/functions/rshift ... ok
Executing: tests/functions/int ... ok
Executing: tests/functions/sort_cmp ... ok
Executing: tests/functions/bitxor ... ok
Executing: tests/functions/pop ... ok
Executing: tests/functions/in ... ok
Executing: tests/functions/and ... ok
Executing: tests/functions/bitor ... ok
Executing: tests/functions/bitand ... ok
Executing: tests/functions/ubitcomp ... ok
Executing: tests/functions/gtge ... ok
Executing: tests/functions/sort23 ... ok
Executing: tests/functions/uminus ... ok
Executing: tests/functions/floatdiv ... ok
Executing: tests/functions/append ... ok
Executing: tests/functions/ltle ... ok
Executing: tests/functions/aug ... ok
Executing: tests/functions/isinstance ... ok
Executing: tests/functions/uplus ... ok
Executing: tests/functions/float ... ok
Executing: tests/functions/ne ... ok
Executing: tests/functions/str ... ok
Executing: tests/strings/ulcase ... ok
Executing: tests/strings/string_format_d ... ok
Executing: tests/strings/splitlines ... ok
Executing: tests/strings/string_format_o ... ok
Executing: tests/strings/string_format_efg ... ok
Executing: tests/strings/find ... ok
Executing: tests/strings/replace ... ok
Executing: tests/strings/lstrip0 ... ok
Executing: tests/strings/rfind ... ok
Executing: tests/strings/rstrip1 ... ok
Executing: tests/strings/string_format_u ... ok
Executing: tests/strings/strip1 ... ok
Executing: tests/strings/string_format_i ... ok
Executing: tests/strings/split ... ok
Executing: tests/strings/strip ... ok
Executing: tests/strings/string_format_x ... ok
Executing: tests/strings/zipstring ... ok
Executing: tests/strings/count ... ok
Executing: tests/strings/lstrip1 ... ok
Executing: tests/strings/rstrip0 ... ok
Executing: tests/lists/sum ... ok
Executing: tests/lists/filter ... ok
Executing: tests/lists/min ... ok
Executing: tests/lists/map ... ok
Executing: tests/lists/in ... ok
Executing: tests/lists/extend ... ok
Executing: tests/lists/zip ... ok
Executing: tests/lists/reduce ... ok
Executing: tests/lists/xrange ... ok
Executing: tests/lists/max ... ok
Executing: tests/modules/import ... ok
Executing: tests/modules/import_diamond ... ok
Executing: tests/modules/import_alias ... ok
Executing: tests/modules/classname ... ok
Executing: tests/modules/import_class ... ok
Executing: tests/modules/from_import ... ok
Executing: tests/modules/import_global ... ok
Executing: tests/modules/module_name ... ok
Executing: tests/modules/rng ... ok
Executing: tests/modules/import_multi ... ok
Executing: tests/libraries/xmlwriter ... ok

======================================================================
FAIL: Executing: tests/basic/kwargs

----------------------------------------------------------------------
Traceback (most recent call last):

File "py2js_test.py", line 133, in runTest
self.assertEqual(jscontents,pycontents,"different output")
AssertionError: different output

----------------------------------------------------------------------
Ran 120 tests in 2.325s

FAILED (failures=1)



and as you can see, all tests pass just fine, except one. So I think
that the original version almost works, so it must have been caused by
your later modifications.

[Peter Rust]

> I think that the original version almost works,
> so it must have been caused by your later modifications

That sounds right. I'll see if I can fix it this evening.

BTW: I think Jonathan and Niall are in the UK, so I think they're 8hrs ahead
of us (nearing 1am, their time).

-- peter

-----Original Message-----
From: js...@googlegroups.com [mailto:js...@googlegroups.com] On Behalf Of
Ondrej Certik

[Ondrej Certik]

On Thu, Apr 29, 2010 at 4:49 PM, Peter Rust <pe...@cornerstonenw.com> wrote:
>> I think that the original version almost works,
>> so it must have been caused by your later modifications
> That sounds right. I'll see if I can fix it this evening.
>
> BTW: I think Jonathan and Niall are in the UK, so I think they're 8hrs ahead
> of us (nearing 1am, their time).

Yes, London is +8h from us.

[Ondrej Certik]

On Thu, Apr 29, 2010 at 3:41 PM, Ondrej Certik <ond...@certik.cz> wrote:
> Hi,
>
> here is how to run our tests:
>
> $ git clone git://github.com/mattpap/py2js.git
> $ cd py2js
> $ ./run_tests.py
> Testing the file: tests/test_builtins.js                                    [OK]
> Testing the file: tests/test_compile_js.py                                  [OK]
> Testing the file: tests/test_python.py                                      [OK]
> Testing the file: tests/test_run_js.py                                      [OK]

I have ported tests from js4py and started to test them using our
py2js. So far this runs:

$ ./run_tests.py
Testing the file: tests/test_builtins.js [OK]

Testing the file: tests/test_python.py [OK]
Testing the file: tests/test_run_js.py [OK]
Testing the file: tests/test_compile_js.py [OK]

tests/basic/augassign.py [4]: .... [OK]
tests/basic/binaryops.py [4]: .... [OK]
tests/basic/break.py [4]: .... [OK]
tests/basic/class.py [4]: .... [OK]
tests/basic/closure.py [4]: .... [OK]
tests/basic/continue.py [4]: .... [OK]
tests/basic/default.py [4]: .... [OK]
tests/basic/dictionary.py [4]: .... [OK]
tests/basic/embedding.py [4]: .... [OK]
tests/basic/fib.py [4]: .... [OK]
tests/basic/for_in.py [4]: .... [OK]
tests/basic/for_step.py [4]: .... [OK]
tests/basic/for_xrange.py [4]: .... [OK]
tests/basic/globalvar.py [4]: .... [OK]
tests/basic/helloworld.py [4]: .... [OK]
tests/basic/keys.py [4]: .... [OK]
tests/basic/list.py [4]: .... [OK]
tests/basic/literals.py [4]: .... [OK]
tests/basic/logicalops.py [4]: .... [OK]
tests/basic/multiassign.py [4]: .... [OK]
tests/basic/none.py [4]: .... [OK]
tests/basic/pass.py [4]: .... [OK]
tests/basic/print.py [4]: .... [OK]
tests/basic/scope.py [4]: .... [OK]
tests/basic/trueorfalse.py [4]: .... [OK]
tests/basic/tuple.py [4]: .... [OK]
tests/basic/while.py [4]: .... [OK]
tests/functions/and.py [4]: .... [OK]
tests/functions/append.py [4]: .... [OK]
tests/functions/bitand.py [4]: .... [OK]
tests/functions/bitor.py [4]: .... [OK]
tests/functions/bitxor.py [4]: .... [OK]
tests/functions/divfloor.py [4]: .... [OK]
tests/functions/float.py [4]: .... [OK]
tests/functions/gtge.py [4]: .... [OK]
tests/functions/in.py [4]: .... [OK]
tests/functions/int.py [4]: .... [OK]
tests/functions/len.py [4]: .... [OK]
tests/functions/lshift.py [4]: .... [OK]
tests/functions/ltle.py [4]: .... [OK]
tests/functions/or.py [4]: .... [OK]
tests/functions/pop.py [4]: .... [OK]
tests/functions/rshift.py [4]: .... [OK]
tests/functions/sort.py [4]: .... [OK]
tests/functions/str.py [4]: .... [OK]
tests/functions/ubitcomp.py [4]: .... [OK]
tests/functions/uminus.py [4]: .... [OK]
tests/functions/uplus.py [4]: .... [OK]




I don't do any modifications to the tests, e.g. I take them as they
are. In the coming days, I'll try to fix py2js and our py-builtins.js,
so that everything passes and then we can easily merge it with your
py2js.

[Jonathan Fine]

I'm delighted, Peter and Ondrej, that you're focussed on the tests and on getting them working.

I'd like us to have 100% test success before we start the merge, even if it means disabling some tests.

As I said in another thread, I think getting a shared test suite is a good place to start the merge.

--
Jonathan

[Ondrej Certik]

On Thu, Apr 29, 2010 at 10:20 PM, Jonathan Fine
<jonatha...@googlemail.com> wrote:
> I'm delighted, Peter and Ondrej, that you're focussed on the tests and on
> getting them working.
>
> I'd like us to have 100% test success before we start the merge, even if it
> means disabling some tests.

Exactly. I think that we should try to get most of the original js4py
tests running, in both of our codebases.

So I ported the tests to our code base, and this is what works now:

$ ./run_tests.py
Testing the file: tests/test_builtins.js [OK]
Testing the file: tests/test_compile_js.py [OK]
Testing the file: tests/test_python.py [OK]
Testing the file: tests/test_run_js.py [OK]

tests/algorithms/sqrt.py [4]: .... [OK]
tests/algorithms/triangulation.py [4]: .... [OK]

tests/lists/in.py [4]: .... [OK]
tests/lists/map.py [4]: .... [OK]
tests/lists/xrange.py [4]: .... [OK]
tests/lists/zip.py [4]: .... [OK]
tests/strings/zipstring.py [4]: .... [OK]





and this is all tests including the failing ones:


$ ./run_tests.py --run-all

Testing the file: tests/test_builtins.js [OK]
Testing the file: tests/test_compile_js.py [OK]
Testing the file: tests/test_python.py [OK]
Testing the file: tests/test_run_js.py [OK]

tests/algorithms/sqrt.py [4]: .... [OK]
tests/algorithms/triangulation.py [4]: .... [OK]
tests/basic/assign_slice.py [4]: ... known to [FAIL]

tests/basic/augassign.py [4]: .... [OK]
tests/basic/binaryops.py [4]: .... [OK]
tests/basic/break.py [4]: .... [OK]
tests/basic/class.py [4]: .... [OK]
tests/basic/closure.py [4]: .... [OK]
tests/basic/continue.py [4]: .... [OK]
tests/basic/default.py [4]: .... [OK]

tests/basic/del_array.py [4]: .. known to [FAIL]
tests/basic/del_attr.py [4]: .. known to [FAIL]
tests/basic/del_dict.py [4]: .. known to [FAIL]
tests/basic/del_global.py [4]: .. known to [FAIL]
tests/basic/del_local.py [4]: .. known to [FAIL]
tests/basic/del_slice.py [4]: .. known to [FAIL]
tests/basic/dictionary.py [4]: .... [OK]
tests/basic/docstring.py [4]: .... known to [FAIL]

tests/basic/embedding.py [4]: .... [OK]
tests/basic/fib.py [4]: .... [OK]

tests/basic/float2int.py [4]: .... known to [FAIL]

tests/basic/for_in.py [4]: .... [OK]
tests/basic/for_step.py [4]: .... [OK]
tests/basic/for_xrange.py [4]: .... [OK]

tests/basic/generator.py [4]: .. known to [FAIL]

tests/basic/globalvar.py [4]: .... [OK]
tests/basic/helloworld.py [4]: .... [OK]
tests/basic/keys.py [4]: .... [OK]

tests/basic/kwargs.py [4]: .. known to [FAIL]
tests/basic/lambda.py [4]: .. known to [FAIL]
tests/basic/list.py [4]: .... [OK]
tests/basic/listcomp2.py [4]: .. known to [FAIL]

tests/basic/literals.py [4]: .... [OK]
tests/basic/logicalops.py [4]: .... [OK]
tests/basic/multiassign.py [4]: .... [OK]

tests/basic/nestedclass.py [4]: .. known to [FAIL]
tests/basic/none.py [4]: .... [OK]
tests/basic/oo.py [4]: .. known to [FAIL]
tests/basic/oo_diamond.py [4]: ... known to [FAIL]
tests/basic/oo_inherit.py [4]: .. known to [FAIL]
tests/basic/oo_static_inherit.py [4]: .. known to [FAIL]

tests/basic/pass.py [4]: .... [OK]
tests/basic/print.py [4]: .... [OK]

tests/basic/raise.py [4]: .. known to [FAIL]
tests/basic/scope.py [4]: .... [OK]
tests/basic/sumcomp.py [4]: .. known to [FAIL]
tests/basic/super.py [4]: .. known to [FAIL]
tests/basic/trueorfalse.py [4]: .... [OK]
tests/basic/try.py [4]: .. known to [FAIL]
tests/basic/tuple.py [4]: .... [OK]
tests/basic/valueerror.py [4]: .. known to [FAIL]
tests/basic/vargs.py [4]: .. known to [FAIL]
tests/basic/vars.py [4]: .. known to [FAIL]
tests/basic/while.py [4]: .... [OK]
tests/errors/decorator.py [4]: .. known to [FAIL]

tests/functions/and.py [4]: .... [OK]
tests/functions/append.py [4]: .... [OK]

tests/functions/aug.py [4]: .. known to [FAIL]

tests/functions/bitand.py [4]: .... [OK]
tests/functions/bitor.py [4]: .... [OK]
tests/functions/bitxor.py [4]: .... [OK]
tests/functions/divfloor.py [4]: .... [OK]
tests/functions/float.py [4]: .... [OK]

tests/functions/floatdiv.py [4]: .. known to [FAIL]

tests/functions/gtge.py [4]: .... [OK]
tests/functions/in.py [4]: .... [OK]
tests/functions/int.py [4]: .... [OK]

tests/functions/isinstance.py [4]: .... known to [FAIL]

tests/functions/len.py [4]: .... [OK]
tests/functions/lshift.py [4]: .... [OK]
tests/functions/ltle.py [4]: .... [OK]

tests/functions/ne.py [4]: .. known to [FAIL]

tests/functions/or.py [4]: .... [OK]
tests/functions/pop.py [4]: .... [OK]
tests/functions/rshift.py [4]: .... [OK]
tests/functions/sort.py [4]: .... [OK]

tests/functions/sort23.py [4]: .... known to [FAIL]
tests/functions/sort_cmp.py [4]: .... known to [FAIL]

tests/functions/str.py [4]: .... [OK]
tests/functions/ubitcomp.py [4]: .... [OK]
tests/functions/uminus.py [4]: .... [OK]
tests/functions/uplus.py [4]: .... [OK]

tests/lists/extend.py [4]: ... known to [FAIL]
tests/lists/filter.py [4]: .. known to [FAIL]
tests/lists/in.py [4]: .... [OK]
tests/lists/map.py [4]: .... [OK]
tests/lists/max.py [4]: ... known to [FAIL]
tests/lists/min.py [4]: ... known to [FAIL]
tests/lists/reduce.py [4]: ... known to [FAIL]
tests/lists/sum.py [4]: .. known to [FAIL]
tests/lists/xrange.py [4]: .... [OK]
tests/lists/zip.py [4]: .... [OK]
tests/strings/count.py [4]: ... known to [FAIL]
tests/strings/find.py [4]: ... known to [FAIL]
tests/strings/lstrip0.py [4]: ... known to [FAIL]
tests/strings/lstrip1.py [4]: ... known to [FAIL]
tests/strings/replace.py [4]: .... known to [FAIL]
tests/strings/rfind.py [4]: ... known to [FAIL]
tests/strings/rstrip0.py [4]: ... known to [FAIL]
tests/strings/rstrip1.py [4]: ... known to [FAIL]
tests/strings/split.py [4]: .... known to [FAIL]
tests/strings/splitlines.py [4]: ... known to [FAIL]
tests/strings/string_format_d.py [4]: .... known to [FAIL]
tests/strings/string_format_efg.py [4]: .... known to [FAIL]
tests/strings/string_format_i.py [4]: .... known to [FAIL]
tests/strings/string_format_o.py [4]: .... known to [FAIL]
tests/strings/string_format_u.py [4]: .... known to [FAIL]
tests/strings/string_format_x.py [4]: .... known to [FAIL]
tests/strings/strip.py [4]: ... known to [FAIL]
tests/strings/strip1.py [4]: ... known to [FAIL]
tests/strings/ulcase.py [4]: ... known to [FAIL]
tests/strings/zipstring.py [4]: .... [OK]




So as you can see, we don't have a string implementation yet, we can't
do things like "del a[3:5]" yet (things like "a = b[3:5]" works) and
we only have very simple support for classes, with no inheritance yet.
And we don't support modules yet. I am now fixing these things.

Can you give me your github accounts so that I can add you as
collaborators to our py2js repo?

I have also pushed into your py2js two more tests, that pass using our
py2js, but fail in your py2js. Especially the triangulation.py is a
real life example that we need in our group to work.

I suggest we now do our best to get most of the tests working. Then we
should again sit down together and compare the approaches and think
what the best way to merge the projects is.

Ondrej

[Peter Rust]

Ondrej,

> I have also pushed into your py2js two more tests, that pass using our
> py2js, but fail in your py2js. Especially the triangulation.py

Thank you!

> Can you give me your github accounts so that I can add you as
> collaborators to our py2js repo?

My github account is "prust". Had to search a while to find the password,
but I added it to KeePass now, so I can quickly login.

> I suggest we now do our best to get most of the tests working. Then we
> should again sit down together and compare the approaches

Agreed. I need to watch myself so I don't spend all my time writing emails
and not have time to write code and fix bugs :-) I made a lot of good
progress last night getting the test suite to run using Microsoft's Jscript
and fixing bugs so more of them would pass. Hopefully I'll be able to do
more over the weekend.

-- peter

-----Original Message-----
From: js...@googlegroups.com [mailto:js...@googlegroups.com] On Behalf Of
Ondrej Certik
Sent: Friday, April 30, 2010 11:59 AM
To: js...@googlegroups.com
Subject: Re: how to run tests

[Ondrej Certik]

On Fri, Apr 30, 2010 at 12:21 PM, Peter Rust <pe...@cornerstonenw.com> wrote:
> Ondrej,
>
>> I have also pushed into your py2js two more tests, that pass using our
>> py2js, but fail in your py2js. Especially the triangulation.py
> Thank you!
>
>> Can you give me your github accounts so that I can add you as
>> collaborators to our py2js repo?
> My github account is "prust". Had to search a while to find the password,
> but I added it to KeePass now, so I can quickly login.

You should be in.

>
>> I suggest we now do our best to get most of the tests working. Then we
>> should again sit down together and compare the approaches
> Agreed. I need to watch myself so I don't spend all my time writing emails
> and not have time to write code and fix bugs :-)   I made a lot of good
> progress last night getting the test suite to run using Microsoft's Jscript
> and fixing bugs so more of them would pass. Hopefully I'll be able to do
> more over the weekend.

Cool. I just discovered that spidermonkey-bin is not in Ubuntu Lucid
(latest version of Ubuntu), so I tried rhino and discovered, that I
have some name clashes with the reserved keywords, so I am fixing it
now in our py2js.

In anycase, the plan is clear now, we just have to do it. :)

[Jonathan Fine]

On Fri, Apr 30, 2010 at 8:21 PM, Peter Rust <pe...@cornerstonenw.com> wrote:

Ondrej,

> I have also pushed into your py2js two more tests, that pass using our
> py2js, but fail in your py2js. Especially the triangulation.py

Thank you!

> Can you give me your github accounts so that I can add you as
> collaborators to our py2js repo?

My github account is "prust".

On github I am jonathanfine.  There's already a jfine on githhub, bit he is not me.

> I suggest we now do our best to get most of the tests working. Then we
> should again sit down together and compare the approaches

Agreed. I need to watch myself so I don't spend all my time writing emails
and not have time to write code and fix bugs :-)  

That's a good point.  Perhaps if we used the issue tracker more that would help.


--
Jonathan

[Ondrej Certik]

On Fri, Apr 30, 2010 at 12:42 PM, Jonathan Fine
<jonatha...@googlemail.com> wrote:
>
>
> On Fri, Apr 30, 2010 at 8:21 PM, Peter Rust <pe...@cornerstonenw.com> wrote:
>>
>> Ondrej,
>>
>> > I have also pushed into your py2js two more tests, that pass using our
>> > py2js, but fail in your py2js. Especially the triangulation.py
>> Thank you!
>>
>> > Can you give me your github accounts so that I can add you as
>> > collaborators to our py2js repo?
>> My github account is "prust".
>
> On github I am jonathanfine.  There's already a jfine on githhub, bit he is
> not me.

We just added you too.

Ondrej