Ticket #4629 Dialog events not being triggered

6 views
Skip to first unread message

Jörn Zaefferer

unread,
Jul 9, 2009, 10:16:00 AM7/9/09
to jquery-ui-dev
If I get that correct, dialog uses draggable and resizable, but
doesn't let the related events bubble up to the dialog widget itself:
http://dev.jqueryui.com/ticket/4629
The events are documented for dialog (with inconsistent naming as he
mentions), but is that really the desired behaviour? The specification
doesn't mention these at all: http://wiki.jqueryui.com/Dialog

Jörn

Scott González

unread,
Jul 9, 2009, 1:35:51 PM7/9/09
to jquery...@googlegroups.com
There's a thread related to that ticket; I'll track it down and link it to the ticket.  I can fix this and update the docs.

Scott González

unread,
Jul 10, 2009, 4:01:15 PM7/10/09
to jquery...@googlegroups.com
Fixed in trunk.  I'll update the docs now.


On Thu, Jul 9, 2009 at 10:16 AM, Jörn Zaefferer <joern.z...@googlemail.com> wrote:

Jörn Zaefferer

unread,
Jul 10, 2009, 4:38:56 PM7/10/09
to jquery...@googlegroups.com
Is the mixed camelcase intended? "dialogdragStart"? Shouldn't that be
"dialogdragstart" or "dialogDragStart"?

Jörn

2009/7/10 Scott González <scott.g...@gmail.com>:

Scott González

unread,
Jul 10, 2009, 7:50:45 PM7/10/09
to jquery...@googlegroups.com
It was a side effect of the existing callback option being named
dragStart and the method we use for naming events from option names. I
agree that dialogdragStart is odd. We could have _trigger lowercase
the event name automatically; does anyone object?

Jörn Zaefferer

unread,
Jul 10, 2009, 8:02:29 PM7/10/09
to jquery...@googlegroups.com
As the events weren't triggered at all previously, we don't really
have a compability issue here. Should be fine to fix it now!

Jörn

2009/7/11 Scott González <scott.g...@gmail.com>:

Scott González

unread,
Jul 10, 2009, 8:32:04 PM7/10/09
to jquery...@googlegroups.com
Fixed.

Ticket: http://dev.jqueryui.com/ticket/4668
Commit: http://dev.jqueryui.com/changeset/2912

Thanks for bringing this up.
Reply all
Reply to author
Forward
0 new messages