#4973 Build fails on non-Windows OS

[Kevin Wells]

Hi,

I don't have permission to re-open #4896 so I created a duplicate
#4973 and took the liberty of assigning the same priority and
milestone as #4896.

The changes included in r3445 cause the build to complete, but the
`prepend-header` target does not work correctly. I confirmed this by
building jquery-ui on Windows and on Ubuntu and comparing the content
of the `dist` directory (modulo line endings). Look at
`jquery.effects.*.min.js` for example.

I've attached a patch to #4973 that resolves the problem for me. The
patch has been tested on Windows 7 and Ubuntu 9.10.

[Scott González]

Hey Kevin,

I noticed the build wasn't fully working, but the specific bug seemed to have been fixed. I notified Richard Worth about it finishing, but not really working after I committed the previous fix because I wasn't sure what was actually going on. I'll try out your fix tomorrow night and see if it works for me on OS X.

Thanks.

--

You received this message because you are subscribed to the Google Groups "jQuery UI Development" group.
To post to this group, send email to jquery...@googlegroups.com.
To unsubscribe from this group, send email to jquery-ui-de...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/jquery-ui-dev?hl=en.

[Scott González]

I just committed this fix. When I ran the build it didn't properly build the docs, but that's a separate issue.

On Tue, Nov 24, 2009 at 2:45 PM, Kevin Wells <wells...@yahoo.co.nz> wrote:

[Kevin Wells]

Thanks for looking into this so quickly Scott.

I noticed the documentation produced when building from
http://jquery-ui.googlecode.com/svn/tags/1.7.2 on Windows 7 was
different to the documentation obtained from
http://jqueryui.com/download/jquery-ui-1.7.2.custom.zip. I assumed
this was because building from source results in more up-to-date
documentation, rather than using a 1.7.2 "snapshot".

When comparing the documentation built using Windows vs Ubuntu the
only differences I noticed in the documentation were in lines like
this:

Pre-expand include size: 30823 bytes
Post-expand include size: 55377 bytes
Template argument size: 33300 bytes

and this:

<!-- Saved in parser cache with key jqdocs_docs:pcache:idhash:
3345-1!1!0!!en!2 and timestamp 20091123160122 -->

I assumed the differences between platforms were because of
differences in line-endings between platforms.

Kevin

> > jquery-ui-de...@googlegroups.com<jquery-ui-dev%2Bunsu...@googlegroups.com>
> > .

[Scott González]

The problem I had was that the docs were all blank (actually contained
the text MediaWiki displays on a page that doesn't exist).

I haven't attempted another build yet, I'll see if the problem still
exists for me. This worked last time I did a build and nothing has
changed since then so it may have just been an intermittent problem.
Either way I don't think this problem was related to your patch.

> To unsubscribe from this group, send email to jquery-ui-de...@googlegroups.com.