Single quote (apostrophe) in file name causes trouble with download

[Nick C]

When a single quote exists in a filename or folder path, the download doesn't work.  I think this applies to all versions?

After using jPlayer for years, I'm using it in a site I'm developing and noticed that I can't download files with a single quote / apostrophe in the filename.  I think I could fix it by using a add slashes (or something) function in the jplayer.playlist.js or the jquery.jplayer.js, but thought I'd check in and make sure no one else had any ideas.

Here's the site streamer I'm developing where I noticed the issue (can't download any file since they have the album title in the name and it has an apostrophe in it):

http://yaheard.us/sitestreamer/?page=http%3A%2F%2Fwww.tedsu.com%2Feastwest%2F

My version does have a few, minor, variations...but I don't think any of them are related to this issue.

Thanks!

[Sean Miller]

Surely easier to rename the files?

File names shouldn't have punctuation... plays havoc with different browsers...

Sean

--
You received this message because you are subscribed to the Google Groups "jPlayer: HTML5 Audio & Video for jQuery" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jplayer+u...@googlegroups.com.
To post to this group, send email to jpl...@googlegroups.com.
Visit this group at http://groups.google.com/group/jplayer.
For more options, visit https://groups.google.com/groups/opt_out.

[Nick C]

True.  I'm developing a site that references older code and in my test case, the site uses single quotes (apostrophes) in the linked album and/or track title.  I thought addressing the resulting issue would be better, but certainly see an argument for citing the problem source as non-adherence to web standards on the site's developer. You can't account for every bad practice in existence, I guess.

Thanks for the feedback!

nc

On Wednesday, December 4, 2013 2:24:10 AM UTC-5, Sean Miller wrote:

Surely easier to rename the files?

File names shouldn't have punctuation... plays havoc with different browsers...

Sean

On Wednesday, 4 December 2013, Nick C wrote:

When a single quote exists in a filename or folder path, the download doesn't work.  I think this applies to all versions?

After using jPlayer for years, I'm using it in a site I'm developing and noticed that I can't download files with a single quote / apostrophe in the filename.  I think I could fix it by using a add slashes (or something) function in the jplayer.playlist.js or the jquery.jplayer.js, but thought I'd check in and make sure no one else had any ideas.

Here's the site streamer I'm developing where I noticed the issue (can't download any file since they have the album title in the name and it has an apostrophe in it):

http://yaheard.us/sitestreamer/?page=http%3A%2F%2Fwww.tedsu.com%2Feastwest%2F

My version does have a few, minor, variations...but I don't think any of them are related to this issue.

Thanks!

--
You received this message because you are subscribed to the Google Groups "jPlayer: HTML5 Audio & Video for jQuery" group.

To unsubscribe from this group and stop receiving emails from it, send an email to jplayer+unsubscribe@googlegroups.com.

[Sean Miller]

Trying to solve "resulting issue"s will be far harder... you can't test in every browser/platform and/or version of browsers/platforms...

The number of times I've had people say to me "it's odd, my friends can't see my site but I can" to find that the URLs in the HTML are all "c:\my documents\pictures\fred.jpg"... FAIL!!

Keep the filenames simple, keep the code simple, and you maximise your chances that everybody will be able to enjoy the music you're seeking to get to them.

Sean

[Nick C]

I failed to mention a couple of things:

1 - Sadly...I have no access to filenames (I'm making a tool that allows parsing of other websites).

2 - My curiosity was peeked because the poorly named files play successfully, but the download links don't work...I assumed a 'fix' was implemented in one area (the code that handles playing files with spaces in path/filenames) but not another (the area that handles the downloads).  Though maybe there never was a fix in one area...the problem only occurs in the download code or something...

Thanks!