jopenid interface dependent on ServletRequest
11 views
Skip to first unread message
dodtsair
Jul 11, 2010, 12:43:18 AM7/11/10
to JOpenID Discussion Group
I like your api. It is nice and clean. It gives your users the
freedom to implement their openid integration the way they choose.
One thing seems to stand out. The use of ServletRequest in the APIs.
Doing a quick look at the source code it looks like you could remove
this dependency by taking a map as the parameter instead. I really
only see the source call request.getParameter. Your users could
easily call request.getParameterMap and hand that off to you.
Mike Power
freedom to implement their openid integration the way they choose.
One thing seems to stand out. The use of ServletRequest in the APIs.
Doing a quick look at the source code it looks like you could remove
this dependency by taking a map as the parameter instead. I really
only see the source call request.getParameter. Your users could
easily call request.getParameterMap and hand that off to you.
Mike Power
Erwin Quinto
Jul 14, 2010, 6:31:27 AM7/14/10
to jopenid-disc...@googlegroups.com
Cool suggestion there. We'll sure include it on our next release.
Reply all
Reply to author
Forward
0 new messages