Duplicate Language files

146 views
Skip to first unread message

brian teeman

unread,
Jan 21, 2015, 8:27:05 PM1/21/15
to joomla-...@googlegroups.com
Can someone explain the logic behind 16 of the language files being duplicated in their own folder as well as the main /languages folder  (list at end)
This has resulted in them being out of sync with each other. I can sync them back again but I don't know the logic behindthe language files existing in two place and why these files are not others.

I also checked two translations (fr and nl) and the files are not duplicated - so why are they in core. Are they never used? If they are then when? And will you only ever see them in en-GB in those cases/

Finally there are two language files that only exist outside of the language folders
  1. ./libraries/cms/html/language/en-GB/en-GB.jhtmldate.ini
    Strings are duplicate in en-GB.lib_joomla.ini

  2. . /libraries/joomla/filesystem/meta/language/en-GB/en-GB.lib_joomla_filesystem_patcher.ini
    Strings do not appear anywhere else so if they are used they are only ever in english


List of duplicated files
./administrator/modules/mod_multilangstatus/language/en-GB/en-GB.mod_multilangstatus.ini
./administrator/modules/mod_multilangstatus/language/en-GB/en-GB.mod_multilangstatus.sys.ini
./administrator/language/en-GB/en-GB.mod_multilangstatus.ini
./administrator/language/en-GB/en-GB.mod_multilangstatus.sys.ini
./administrator/modules/mod_stats_admin/language/en-GB.mod_stats_admin.ini
./administrator/modules/mod_stats_admin/language/en-GB.mod_stats_admin.sys.ini
./administrator/language/en-GB/en-GB.mod_stats_admin.ini
./administrator/language/en-GB/en-GB.mod_stats_admin.sys.ini
./administrator/modules/mod_version/language/en-GB/en-GB.mod_version.ini
./administrator/modules/mod_version/language/en-GB/en-GB.mod_version.sys.ini
./administrator/language/en-GB/en-GB.mod_version.ini
./administrator/language/en-GB/en-GB.mod_version.sys.ini
./administrator/templates/hathor/language/en-GB/en-GB.tpl_hathor.ini
./administrator/templates/hathor/language/en-GB/en-GB.tpl_hathor.sys.ini
./administrator/language/en-GB/en-GB.tpl_hathor.ini
./administrator/language/en-GB/en-GB.tpl_hathor.sys.ini
./administrator/templates/isis/language/en-GB/en-GB.tpl_isis.ini
./administrator/templates/isis/language/en-GB/en-GB.tpl_isis.sys.ini
./administrator/language/en-GB/en-GB.tpl_isis.ini
./administrator/language/en-GB/en-GB.tpl_isis.sys.ini
./templates/beez3/language/en-GB/en-GB.tpl_beez3.ini
./templates/beez3/language/en-GB/en-GB.tpl_beez3.sys.ini
./language/en-GB/en-GB.tpl_beez3.ini
./language/en-GB/en-GB.tpl_beez3.sys.ini
./templates/protostar/language/en-GB/en-GB.tpl_protostar.ini
./templates/protostar/language/en-GB/en-GB.tpl_protostar.sys.ini
./language/en-GB/en-GB.tpl_protostar.ini
./language/en-GB/en-GB.tpl_protostar.sys.ini
./plugins/system/languagecode/language/en-GB/en-GB.plg_system_languagecode.ini
./plugins/system/languagecode/language/en-GB/en-GB.plg_system_languagecode.sys.ini
./administrator/language/en-GB/en-GB.plg_system_languagecode.ini
./administrator/language/en-GB/en-GB.plg_system_languagecode.sys.ini

brian teeman

unread,
Jan 21, 2015, 8:40:19 PM1/21/15
to joomla-...@googlegroups.com
I have checked the documentation for creating translations and there is no mention of these duplicated files so I can only assume they are not being used anywhere

As for the two library files I assume that 
  1. ./libraries/cms/html/language/en-GB/en-GB.jhtmldate.ini can be removed as its strings are in the main library files
  2. . /libraries/joomla/filesystem/meta/language/en-GB/en-GB.lib_joomla_filesystem_patcher.ini the strings for this need copy to the main library files and can then be deleted as well
I can create a PR to do all of this but I want to make sure I've not missed some special reason that these files exist

Michael Babker

unread,
Jan 21, 2015, 8:53:48 PM1/21/15
to joomla-...@googlegroups.com
The files in libraries date back to the Platform days and needing a location to store language strings for those components.  Those files are dated and can be removed.

The duplicated files IMO can be consolidated to the language folder and removed.

--
You received this message because you are subscribed to the Google Groups "Joomla! CMS Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to joomla-dev-cm...@googlegroups.com.
To post to this group, send email to joomla-...@googlegroups.com.
Visit this group at http://groups.google.com/group/joomla-dev-cms.
For more options, visit https://groups.google.com/d/optout.

Bakual

unread,
Jan 22, 2015, 4:20:25 AM1/22/15
to joomla-...@googlegroups.com
The duplicated files can be removed. They are never loaded anyway as long as there is a file with the same name in the global language folder.

I guess this dates back to when we introduced the extension language folder.
The extension folder would actually be the correct location for a language file. The global language folder would be the override place.

With the decoupling of the extensions, that is one thing we need to do eventually. But it's postponed till we have an accepted adjusted workflow for the translation teams which allows them to easily track and package the language changes in the decoupled extensions.


Am Donnerstag, 22. Januar 2015 02:53:48 UTC+1 schrieb Michael Babker:
The files in libraries date back to the Platform days and needing a location to store language strings for those components.  Those files are dated and can be removed.

The duplicated files IMO can be consolidated to the language folder and removed.
On Wed, Jan 21, 2015 at 8:40 PM, brian teeman <joom...@googlemail.com> wrote:
I have checked the documentation for creating translations and there is no mention of these duplicated files so I can only assume they are not being used anywhere

As for the two library files I assume that 
  1. ./libraries/cms/html/language/en-GB/en-GB.jhtmldate.ini can be removed as its strings are in the main library files
  2. . /libraries/joomla/filesystem/meta/language/en-GB/en-GB.lib_joomla_filesystem_patcher.ini the strings for this need copy to the main library files and can then be deleted as well
I can create a PR to do all of this but I want to make sure I've not missed some special reason that these files exist

--
You received this message because you are subscribed to the Google Groups "Joomla! CMS Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to joomla-dev-cms+unsubscribe@googlegroups.com.
To post to this group, send email to joomla-dev-cms@googlegroups.com.

brian teeman

unread,
Jan 22, 2015, 11:07:59 AM1/22/15
to joomla-...@googlegroups.com
OK Thanks I will do a PR to remove the duplicates AND to copy the strings from /en-GB.lib_joomla_filesystem_patcher.ini to  en-GB.lib_joomla.ini

infograf768

unread,
Jan 23, 2015, 3:04:30 AM1/23/15
to joomla-...@googlegroups.com

As far as I remember, this was done to let a user re-install (including the lang files) an extension accidentally uninstalled.
If it is nevertheless decided to delete these, the related xmls would also need to be corrected as they include the language/ folder in the path.

brian teeman

unread,
Jan 23, 2015, 4:32:20 AM1/23/15
to joomla-...@googlegroups.com
I can see the point of them if we were consistent and did it for all unprotected modules/templates and plugins - but we dont.

Removing them now makes everything consistent (many of the strings are out of date anyway)

Moving forward we can look at a way to handle re-installing any core extension that is not protected and can be uninstalled etc

I have updated the xml files in the PR to remove the reference to the language files

brian teeman

unread,
Jan 23, 2015, 6:04:14 AM1/23/15
to joomla-...@googlegroups.com
I closed the PR - cant be bothered with debating with people who want to maintain useless code that is out of cate and not consistent.

I thought we had move on - I was wrong 
Reply all
Reply to author
Forward
0 new messages