please review patch for com_newsfeeds admin

[pollen8]

Hi

I've added my first go at refractoring the com_newsfeeds admin
component.
Its in the tracker at this url
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=16972

If people could take a look and let me know if there are any changes
that need to be made that would be great. Go easy on me this is my
first attempt to write a j1.6 admin component so I may have missed
some blindingly obvious stuff!

Thanks
Rob

[Gergő Erdősi]

Hi,

I'm reviewing your patch. Great job, thanks! If you have Skype, can
you please add me (gergo.erdosi)? Thanks!

--
Gergő Erdősi


2009/6/25 pollen8 <r...@pollen-8.co.uk>

[Gergő Erdősi]

Your refactored com_newsfeeds component is in the trunk now. You did
an excellent work! Thank you again!

--
Gergő Erdősi


2009/6/25 Gergő Erdősi <gergo....@joomline.org>

[Andrew Eddie]

Really good job Rob! Couple of little things you might like to add.

1. There's a helper now for the submenu bar to get the categories to
work properly. Copy off com_content/helpers/content.php

2. The category and published state filters have changed slightly.
Steal the format from com_content/view/articles/tmpl/default.php

3. I standardised a few language strings for the list headings and
form fields for the more common uses. Maybe have a go a teasing them
out of com_content as well.

4. Have a go at providing the integrated trash management like we have
in com_content or com_weblinks and also have a go at supporting the
save-to-copy function (see com_content/controllers/article.php - save
method for that one).

But over all, very good effort. Really appreciate the help with the
refactoring :)

Regards,
Andrew Eddie
http://www.theartofjoomla.com - the art of becoming a Joomla developer




2009/6/26 Gergő Erdősi <gergo....@joomline.org>:

[pollen8]

@Gergo

I already have you in skype, my username is rob_clayburn

@Andrew - no worries, will take a look at the points you raised. A lot
of the language stuff had changed since I first started refractoring,
I'll take a look at com_content to get some more ideas.

Rob

On 25 June, 23:43, Andrew Eddie <mambob...@gmail.com> wrote:
> Really good job Rob!  Couple of little things you might like to add.
>
> 1. There's a helper now for the submenu bar to get the categories to
> work properly.  Copy off com_content/helpers/content.php
>
> 2. The category and published state filters have changed slightly.
> Steal the format from com_content/view/articles/tmpl/default.php
>
> 3. I standardised a few language strings for the list headings and
> form fields for the more common uses.  Maybe have a go a teasing them
> out of com_content as well.
>
> 4. Have a go at providing the integrated trash management like we have
> in com_content or com_weblinks and also have a go at supporting the
> save-to-copy function (see com_content/controllers/article.php - save
> method for that one).
>
> But over all, very good effort.  Really appreciate the help with the
> refactoring :)
>
> Regards,

> Andrew Eddiehttp://www.theartofjoomla.com- the art of becoming a Joomla developer
>
> 2009/6/26 Gergő Erdősi <gergo.erd...@joomline.org>:

>
>
>
> > Your refactored com_newsfeeds component is in the trunk now. You did
> > an excellent work! Thank you again!
>
> > --
> > Gergő Erdősi
>

> > 2009/6/25 Gergő Erdősi <gergo.erd...@joomline.org>

>
> >> Hi,
>
> >> I'm reviewing your patch. Great job, thanks! If you have Skype, can
> >> you please add me (gergo.erdosi)? Thanks!
>
> >> --
> >> Gergő Erdősi
>
> >> 2009/6/25 pollen8 <r...@pollen-8.co.uk>
>
> >> > Hi
>
> >> > I've added my first go at refractoring the com_newsfeeds admin
> >> > component.
> >> > Its in the tracker at this url

> >> >http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEd...

[Gergő Erdősi]

I'm sorry, you are right, you are on my contact list too. :) We've
just never talked in private, that's why I didn't remember. :)

--
Gergő Erdősi



2009/6/26 pollen8 <r...@pollen-8.co.uk>:

[pollen8]

I added the patch for the features suggested by Andrew, the patch is
called com_newsfeeds.zip and is located here:

http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=16972

[pollen8]

made a little mistake the correct patch is:

patch-newsfeeds2.zip