Manhattan router ignoring embedded elements

[James Connell]

The manhattan router seems to ignore (or draw a link straight through) elements that are embedded inside other elements.  However in the same drawing it will successfully route around top-level elements.   If an embedded element is connected to a top level element, the routing will also fail to 'see' any other elements, and draw the link right through them.  Is this a known issue?

[James Connell]

After doing some more research, it seems to behave better if I exclude the parent container elements, basically it seems to completely fail if the parent elements end up in set of elements to route around (fist one):

Occasionally it will still route through an element, is there any way to prevent this?

[Roman Bruckner]

Hi James,

you might try to increase `maximumLoops` on the router (https://github.com/DavidDurman/joint/blob/master/plugins/routers/joint.routers.manhattan.js#L24).

In the case that maximum number of loops is exceeded during routing algorithm a fallback route (some simple orthogonal route) is used instead.

e.g link.set('router', { name: 'manhattan', args: { maximumLoops: 1000 }});

Regards,

Roman

--

---
You received this message because you are subscribed to the Google Groups "JointJS" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jointjs+u...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--

Roman Brückner

CTO at client.io

+420 776 504 406

ro...@client.io

[James Connell]

Thank you-

Adjusting maximumLoops does seem to help reduce overlap in the working case- however when the parent elements are not excluded (in { args : { excludeTypes: ['foo','bar'] }}, the router always fails (ie  falls back to the basic L shaped route in image 1 ), even when maximumLoops is set to a very high number (10000).   It seems like it cant find an ideal route, because every point would have at least 2 obstacles (the parent elements)....

[Roman Bruckner]

Yeah, excluding the parent elements was definitely a good idea. So I would stick to that if possible.

link.set('router', { name: 'manhattan', args: { maximumLoops: 1000, excludeTypes: ['foo', 'bar'] }});

[James Connell]

Ok.  If I find time I might writeup a bug on github... seems it wouldn't be too hard to adjust the pathfinding to account for this;

[James Connell]

On a different topic, what is opt.draggingRoute for and how would it get used?

[Roman Bruckner]

Hi James,

the `draggingRoute` is an experimental option. However the idea is to provide a different routing for the links that does not connect 2 elements. (A link might connect a point and an element or 2 points).

mylink.set('router', { name: 'manhattan', args: { draggingRoute: function(p1, p2, opt) { return []; }}});

// And now try to drag an arrowhead of  'mylink'.