--
You received this message because you are subscribed to the Google Groups "joindin-developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to joindin-develop...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
+1 this feature, even as UG organiser. I still would like to receive feedback, especially if there are any issues, and if reporting anonymously makes that more likely then I am strongly in favour of this. Of course, it is probably down to the event organisers to publicise this feature, but it is a good thing to have.
I see Lorna's point about adding it in the usual comments stream - I agree, that would be terrible if a mistake was to happen & if other services hook into the API, how can you be sure they are filtering out the "private" messages and so on.
Nice idea Scott! :)
Thanks
James
Hi Scott
Just a quick one, I can't comment on the change as I'm on my mobile or something, but L120 introduces a vulnerability. If $request->url_elements[4] is NOT set (and I don't know if that is possible, but with security you should always assume it IS possible) then you will be bypassing the unauthorised exception.
I think the logic should be more like:
if (not set || (is set && not "messages"))
throw exception
I'll take a proper look later at the rest of the change :)
Thanks
James