Over-eager escaping of html entities - JOINDIN-432

14 views
Skip to first unread message

Mark Fee

unread,
Mar 1, 2014, 5:04:25 AM3/1/14
to joindin-d...@googlegroups.com
Hi,

This is my first leap into opensource contribution, please thank Michelle Sanver for this. I've checked out the code and managed to get a test vhost running and rather predictably picked the issue at the top of the list as my first issue. However, for me it seems like a non issue, no matter how hard I try I can't recreate the issue - markup in a title always seems to play ball and display just how you would expect it to. My guess is that there is a particular route somewhere that will escape the escaped string but I'm afraid I can't find it - I've even tried multiple repeat postings and everything works as you would expect. 
Even copying the actual escaped string from the html source and posting that back in as a title managed to NOT escape the already escaped text.

I've created an account on joindin.jira.com but it doesn't look like I can post, unless I'm being daft, so I'm posting my findings here instead. 

I hope this is helpful.

Clair

unread,
Mar 1, 2014, 1:27:10 PM3/1/14
to joindin-d...@googlegroups.com
Hi Mark - welcome to joind.in :)

That's interesting to hear. Maybe it's a bug with the old site that causes the characters to not be escaped, causing that particular talk to appear as <?php where properly escaped it should actually be &lt;php - which is what the API gives us?

So if everything works for you no matter what you try - that's good news. Thanks for checking it out!


It looks like your Jira account didn't have the correct permissions to be able to comment on the issues. I've now added you, and so you should be able to do so now if you try again!


Clair

Mark Fee

unread,
Mar 1, 2014, 2:47:54 PM3/1/14
to joindin-d...@googlegroups.com
Thanks Claire, 

LornaJane has followed this up also, and I have replied on the bug tracker. Looks like the issue may lie with the API so I'll have a look there next.

Mark
Reply all
Reply to author
Forward
0 new messages