API nginx compatibility

[Adam Dear]

Hi all,

I'm just starting to work on JOINDIN-475, so I'm setting up the api locally on an nginx virtual machine.  I know there is a README file for what needs to be done to get it running on nginx. I'm wondering if there would be any objection to making the changes necessary to run on nginx part of the project so that it comes ready to run on nginx out of the box.

I'm happy to do a pull request for the changes to get it up and going, but I wanted to make sure there weren't any objections or  some underlying reason why this work hasn't already been done. The changes needed are fairly minor.

Thanks.

[Kevin Bowman]

Hi Adam,

 

Sounds great!  Bear in mind that the live, test and most dev servers run Apache so it'll need to keep working on that as well; if you want someone to check that your changes keep working on Apache then just shout.

 

Kevin

--

You received this message because you are subscribed to the Google Groups "joindin-developers" group.

To unsubscribe from this group and stop receiving emails from it, send an email to joindin-develop...@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

 

[Adam Dear]

I can spin up an Apache machine to test, but an extra set of eyes would be great. The branch with the changes is here: https://github.com/adear11/joindin-api/tree/nginx-compat

To unsubscribe from this group and stop receiving emails from it, send an email to joindin-developers+unsub...@googlegroups.com.

[Lorna Mitchell]

Hello

We don't have nginx support because I don't think anyone runs it on nginx (yet!) - we have a dev VM which most people use, and the live platforms are Apache as well.  I am happy to have the project adapted to work for nginx too though.

Feel free to open a pull request for your changes and share the link in this thread - I'm not sure which of the maintainers are running nginx but hopefully someone else on this list (Kevin maybe!) will be able to help us test it.

Thanks :)

Lorna

To unsubscribe from this group and stop receiving emails from it, send an email to joindin-develop...@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--
Lorna Mitchell
http://lornajane.net

[Adam Dear]

I just opened a pull request for this. It is at https://github.com/joindin/joindin-api/pull/105

Please let me know what else I need to do.

Adam

[Kevin Bowman]

Hi Adam,

 

Thanks for this; I've been switching between Apache and Nginx and can't see any problems.  I've commented a such on the PR.  One other thing: this makes the "README.NGINX.md" file redundant?  If so, it's probably worth deleting that in your PR as well.

 

Kevin