Any Appitite for a Notify on Success option?

[Dean Roker]

Hi,

Thank you for creating jobber. It is a nice piece of work.

I am writing a dash web app and companion error handler that posts the results of the jobber run to a rest api.

It would be nice to have a positive confirmation that a job has actually been attempted and succeeded from a central place without manually checking each machine.

Is there any appetite for me to add a notify on success option and submit a pull request?

Thanks

Dean

[C. Dylan Shearer]

Sure!  Thank you for the kind words, and for the PR!

Best,

Dylan

--
You received this message because you are subscribed to the Google Groups "Jobber" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jobber-proj...@googlegroups.com.
To post to this group, send email to jobbe...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jobber-proj/3574f2e3-bfa5-4ac4-8d34-3a0fc1e84c8b%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Dean Roker]

Cool I'll get started.

[Dean Roker]

I think I have done it, I would like to write a unit test to see if it works, but I am struggling.

Could someone have a go at writing a unit test, I added a unit test to make sure the jobber file got imported correctly.

Thanks

Dean

[Dean Roker]

I cant push to your repo so to submit the pull request, this is my first one and Im not sure what to do.

Thanks

Dean

[Dean Roker]

I submitted a pull request from my fork, but it failed the build test due to a perl http module failing a check

Rpmdb checksum is invalid: dCDPT(pkg checksums): perl-HTTP-Tiny.noarch 0:0.033-3.el7 - u

I don't think my code caused that?

Thanks

Dean

[C. Dylan Shearer]

Yeah I see that.  It is definitely not your fault — the same thing was happening on master.  I’ve fixed it.

To view this discussion on the web visit https://groups.google.com/d/msgid/jobber-proj/110e9824-3858-43c5-871d-52a6bdc4386e%40googlegroups.com.