jmeter-plugins-webdriver Manual Proxy Configuration Errors

[George Li]

I'm trying to use the jmeter-plugins-webdriver plugin v4.13.0.0 with a manual proxy configuration but to keep running into this error:

```log

2024-06-28 18:11:11,735 ERROR o.a.j.t.JMeterThread: Error calling threadStarted

org.openqa.selenium.SessionNotCreatedException: Could not start a new session. Response code 400. Message: invalid argument: entry 0 of 'firstMatch' is invalid

from invalid argument: cannot parse capability: proxy

from invalid argument: 'socksVersion' must be between 0 and 255

```

Looking at the source code, the plugin is not setting the socksVersion value (the config element is not collecting this value):

``` java

public Proxy getManualProxy(ProxyHostPort httpProxy, ProxyHostPort httpsProxy, ProxyHostPort ftpProxy, ProxyHostPort socksProxy, String noProxy) {
        return new Proxy()
            .setProxyType(Proxy.ProxyType.MANUAL)
            .setHttpProxy(httpProxy.toUnifiedForm())
            .setSslProxy(httpsProxy.toUnifiedForm())
            .setFtpProxy(ftpProxy.toUnifiedForm())
            .setSocksProxy(socksProxy.toUnifiedForm())
            .setNoProxy(noProxy);
    }

```

https://github.com/undera/jmeter-plugins-webdriver/blob/3f2db6074aa3e0cce56b656e0397f524117aa8dc/src/main/java/com/googlecode/jmeter/plugins/webdriver/proxy/ProxyFactory.java#L29

And in the underlying Selenium package the socksVersion default value is null:

```java

private ProxyType proxyType = ProxyType.UNSPECIFIED;
  private boolean autodetect = false;
  private String ftpProxy;
  private String httpProxy;
  private String noProxy;
  private String sslProxy;
  private String socksProxy;
  private Integer socksVersion;
  private String socksUsername;
  private String socksPassword;
  private String proxyAutoconfigUrl;

```

https://github.com/SeleniumHQ/selenium/blob/66b3a2ade201458b21fa71f92f137417b81faade/java/src/org/openqa/selenium/Proxy.java#L84

A somewhat related issue is that there's no way to selectively set proxies when going the manual route - it seems to be an all or nothing approach:

```java

public Proxy createProxy() {
switch (getProxyType()) {
case PROXY_PAC:
return proxyFactory.getConfigUrlProxy(getProxyPacUrl());
case DIRECT:
return proxyFactory.getDirectProxy();
case AUTO_DETECT:
return proxyFactory.getAutodetectProxy();
case MANUAL:
if (isUseHttpSettingsForAllProtocols()) {
ProxyHostPort proxy = new ProxyHostPort(getHttpHost(), getHttpPort());
return proxyFactory.getManualProxy(proxy, proxy, proxy, proxy, getNoProxyHost());
}
ProxyHostPort http = new ProxyHostPort(getHttpHost(), getHttpPort());
ProxyHostPort https = new ProxyHostPort(getHttpsHost(), getHttpsPort());
ProxyHostPort ftp = new ProxyHostPort(getFtpHost(), getFtpPort());
ProxyHostPort socks = new ProxyHostPort(getSocksHost(), getSocksPort());
return proxyFactory.getManualProxy(http, https, ftp, socks, getNoProxyHost());
default:
return proxyFactory.getSystemProxy();
}
}

```

https://github.com/undera/jmeter-plugins-webdriver/blob/3f2db6074aa3e0cce56b656e0397f524117aa8dc/src/main/java/com/googlecode/jmeter/plugins/webdriver/config/WebDriverConfig.java#L251

Examples of why I would want this would be not setting the FTP proxy for Firefox/Gecko driver because: "org.openqa.selenium.SessionNotCreatedException: Could not start a new session. Response code 500. Message: Since Firefox 90 'ftpProxy' is no longer supported"