JHipster 7 Beta 2?

121 views
Skip to first unread message

Matt Raible

unread,
Jan 29, 2021, 12:38:07 AM1/29/21
to JHipster dev team
Howdy JHipsters, 🤠

I think we’ve made good progress on migrating Spring Boot to v2.4.2 and I’d like to share it with the wider community. Is it possible to include it in a v7 beta release?


This PR depends on a JHipster BOM PR:


I propose the following:

1. Merge spring-boot-2.4 in both jhipster-bom and generator-jhipster repositories
2. Release beta2 in the next week or so with Spring Boot 2.4 support
3. Fix bugs, publish another beta or a release candidate
4. Fix bugs, another RC, or 7.0.0

It’d be fun to release 7.0.0 on or just before Valentine's Day! 

Here in the US, It’s a Hallmark holiday, but still fun if you celebrate it! ❤️

Cheers,

Matt

Pascal GRIMAUD

unread,
Jan 29, 2021, 1:22:41 PM1/29/21
to Matt Raible, JHipster dev team
Ok, let's merge Spring Boot 2.4 branch.
Then, I can prepare the beta2 in 1 or 2 weeks.

Pascal


--
You received this message because you are subscribed to the Google Groups "JHipster dev team" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jhipster-dev...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jhipster-dev/EDDB1E00-90D0-4D9E-B6D4-6F2D78D268F7%40raibledesigns.com.

Pascal GRIMAUD

unread,
Feb 1, 2021, 12:20:28 PM2/1/21
to Matt Raible, JHipster dev team
Hello,

For your information, all JDL microservices builds failed, since Spring Boot 2.4

The reason is the Registry is not ready yet and the app failed, instead of waiting and retry.
Something has changed with the new behaviour which replaced bootstrap.yml
2 solutions:
- add more sleep for our Docker Compose (which is not really nice as it looks a little hack)
- find the good property with retry

So at the moment, we need to fix this before doing a new beta release.

Pascal


-

Matt Raible

unread,
Feb 1, 2021, 1:08:34 PM2/1/21
to Pascal GRIMAUD, JHipster dev team
I did see this issue when working on the Spring Boot 2.4 PR. I thought it was because Spring Cloud Config’s retry feature wasn’t working, so I sent this to Spencer Gibb.

Hey Spencer,

I’m trying to upgrade JHipster to use Spring Boot 2.4.2. Tonight, I discovered y’all released Spring Cloud Config 3.0.1 to fix some retry issues.

I have the following in my application-prod.yml:

cloud:
 config:
   retry:
     initial-interval: 1000
     max-interval: 2000
     max-attempts: 100
   uri: http://admin:${jhipster.registry.password}@localhost:8761/config
   # name of the config server's property source (file.yml) that we want to use
   name: reactiveGateway
   profile: prod
   label: main # toggle to switch to a different version of the configuration as stored in git
   # it can be set to any label, branch or commit of the configuration source Git repository
config:
 import: 'configserver:’

However, the retry doesn’t seem to happen. It just fails on startup. I do have spring-retry in my classpath.

$ mvn dependency:tree | grep spring-retry
[INFO] +- org.springframework.retry:spring-retry:jar:1.3.1:compile

Any advice would be great.

Thanks!

Matt

He never replied, but we discovered that disabling testcontainers for the failing jobs fixed them. It also seems the failure happens connecting to Eureka, not Spring Cloud Config.

Cheers,

Matt 

Matt Raible

unread,
Feb 1, 2021, 1:36:23 PM2/1/21
to Pascal GRIMAUD, JHipster dev team
Another thought that struck me when I saw this happening earlier is that the app is trying to connect to the wrong profile on Spring Cloud Config. I say this because I think pre-Spring Boot 2.4, we were connecting to a “dev” profile on Spring Cloud Config in these tests. 

From https://github.com/hipster-labs/jhipster-daily-builds/runs/1804354193?check_suite_focus=true#step:15:243:

crm_1                | Caused by: org.springframework.web.client.ResourceAccessException: I/O error on GET request for "http://jhipster-registry:8761/config/crm/prod/main": Connection refused (Connection refused); nested exception is java.net.ConnectException: Connection refused (Connection refused)

If you run your app with the “prod” profile, it tries to connect to the “prod” profile on Spring Cloud Config. Is this always available? The JHipster Registry’s docker container always seems to start with the “dev” profile since it’s hard-coded in the Docker Compose file.


Cheers,

Matt

Pascal GRIMAUD

unread,
Feb 1, 2021, 4:54:59 PM2/1/21
to Matt Raible, JHipster dev team

Matt Raible

unread,
Feb 1, 2021, 5:02:09 PM2/1/21
to Pascal GRIMAUD, JHipster dev team
I just restarted one of the builds to see if there’s a change for JDLMS Redis MariaDB.


If it doesn’t fix things, we can always revert to the previous bootstrap mechanism like we had before.

It looks like Consul still needs a similar fix when using import.

Pascal GRIMAUD

unread,
Feb 1, 2021, 5:07:48 PM2/1/21
to Matt Raible, JHipster dev team
Just created the ticket here

So we can discuss there, instead of the ML :)

Pascal

Pascal GRIMAUD

unread,
Feb 5, 2021, 12:03:07 PM2/5/21
to Matt Raible, JHipster dev team
Hi team,


It seems all our Microservices Architecture is broken since the Spring Boot 2.4 migration.
The gateway can't communicate with other microservices.
So for now, we are stuck for a new release beta.2 until it is fixed.

Any help would be really welcome.
Thanks in advance, and don't hesitate to ask for more bounty on this, if needed.

Pascal

Reply all
Reply to author
Forward
0 new messages