Spring Boot 2.3, JHipster 7 and Couchbase

[Aurélien Mino]

Hi team!

I'm back from holidays and I saw that a lot of refactoring has been merged in the main generator.

Thus the spring-boot-2.3 branch now has a lot of conflicts with master.

The current status of Spring Boot 2.3 upgrade is that everything should work, except Couchbase.

Spring Data Couchbase 4.0, pulled by SB 2.3, suffers from a lot of issues, as reported in comments of SB 2.3 announcement: https://spring.io/blog/2020/05/15/spring-boot-2-3-0-available-now#comment-4918821080

I've myself reported a few bugs, some were fixed, some are still open: https://jira.spring.io/browse/DATACOUCH-588 and https://jira.spring.io/browse/DATACOUCH-589.

So Couchbase support is stuck, I don't have the energy to continue working on it (I already spent so much time :( on it). The draft PR is here: https://github.com/jhipster/generator-jhipster/pull/11845 and a generated project is also available: https://github.com/murdos/react-maven-couchbase-caffeine-sb23 if anyone want to work on it.

So the question is how do we move forward with the SB 2.3 upgrade?

IMO the branch should be merged soon in master, because the more we wait, the more conflicts we'll have. I'm inclined to fix the conflicts once, but I won't do it again and again.

Should we temporarily disable Couchbase and try to fix it before release of JHipster 7? Or should we remove it from JHipster 7?

Aurélien

[Matt Raible]

I’d say we upgrade to Spring Boot 2.3 and leave Couchbase behind. We can leave an issue open for it and put a bug bounty on it. If it’s not fixed before 7.0 GA is released, oh well. We can advertise that it’s not included in alpha and beta releases, hopefully encouraging someone to help. 

We can always add it back in after 7.0 is released if it’s fixed.

Cheers,

Matt

--
You received this message because you are subscribed to the Google Groups "JHipster dev team" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jhipster-dev...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jhipster-dev/CACXN3_gAVJTJpuyTCppU_xBJs8jqRKsN5M9weOErJ%2ByCefFL%2BA%40mail.gmail.com.

[Pascal GRIMAUD]

Hello,

I'm in favor of disabling Couchbase if no one wants to help to keep the option:

- remove it from prompt or mention "broken"

- remove it from CI

Then, if it's not fixed in a few weeks/months, let's simply remove it.

As already said, we have really too many options.

Lot of people are happy to have it, but when it's time to help/fix the bugs, there is a strange silence...

Pascal

--

[Frederik Hahne]

Let's disable and the option for now. I guess when spring data has ironed out the issues it might be easy to add again. So let's move forward with 2.3.

To view this discussion on the web visit https://groups.google.com/d/msgid/jhipster-dev/CALUG8VvVCytDg82ubtfso5PyHz3ytfW8X6-bfO1iiw3%3Dju9A4Q%40mail.gmail.com.

[Julien Dubois]

Hey, just when I’m discussing with Couchbase so they sponsor the project 🤣

Well, it might show that we need support from them! Anyway, I agree with the decision, we can’t postpone Spring Boot 2.3 just for one option.

Julien Dubois 

To view this discussion on the web visit https://groups.google.com/d/msgid/jhipster-dev/CACh2FPSd93bLE51j7_ged5G3mC6u-4e3s3_Ee7D8id_r34gj%3DA%40mail.gmail.com.

--

Julien Dubois

Twitter: @juliendubois

[Anthony Viard]

My bad, I forgot to reply All :D

---------- Forwarded message ---------
De : Anthony Viard <anth....@gmail.com>
Date: ven. 28 août 2020 à 16:54
Subject: Re: Spring Boot 2.3, JHipster 7 and Couchbase
To: Aurélien Mino <aureli...@gmail.com>, Julien Dubois <julien...@gmail.com>

Hi Aurélien,
now we've just finished adding Cypress to the generator, I wonder if you need help to move forward on Spring Boot 2.3. 
For the v7, it will be awesome to merge Spring boot 2.3, I think it's a must have.

@Julien Dubois Have we some news about Couchbase issues and help that we can have from them?

Do we, finally, disable this option for the moment?

Regards, 

Anthony

Le dim. 23 août 2020 à 19:02, Aurélien Mino <aureli...@gmail.com> a écrit :

--

[Julien Dubois]

Hey,

No reply from Couchbase yet... I don't believe this option is used by a lot of people, so we shouldn't make everybody wait just for this. Please remove the option, but not the code: if we don't find a solution in the next 6-12 months then we'll also remove the code, but there's no need to rush and I have good confidence we will have something.

Julien

To view this discussion on the web visit https://groups.google.com/d/msgid/jhipster-dev/CAPEJTRdCKZtw6TMjEWsHkPf-rxcnarkseqNisZBZUHyJ8cCwPQ%40mail.gmail.com.

[Aurélien Mino]

Hi Anthony,

Couchbase CI tests have been disabled in the spring-boot-2.3 branch and the option labelled as broken.

I've currently 2 issues:

- backend tests for react-gradle-psql-es-noi18n-mapsid are failing on CI, but I don't reproduce locally. My only hint right now is to check if it's related to the previous CI step that starts docker containers.

- there's seems to be an issue with webflux tests that don't run at all with GithubActions - they should however been green

If you have time to help with these issues, that would be great ;-)

I'll try to work on it too during week-end.

Aurélien

To view this discussion on the web visit https://groups.google.com/d/msgid/jhipster-dev/CAPEJTRdCKZtw6TMjEWsHkPf-rxcnarkseqNisZBZUHyJ8cCwPQ%40mail.gmail.com.

[Zs.]

My guess is that here the condition is only true, when the commit message contains the "[webflux]" string.

Zsombor

To view this discussion on the web visit https://groups.google.com/d/msgid/jhipster-dev/CACXN3_i0W2%2BDrV1S-yMzxubWBfp8uRoRFm4XjynWkW6qeN8CYA%40mail.gmail.com.

[Anthony Viard]

I've failed another time (I must choose "reply all" next time :)). 

---------- Forwarded message ---------
De : Anthony Viard <anth....@gmail.com>

Date: sam. 29 août 2020 à 01:18

Subject: Re: Spring Boot 2.3, JHipster 7 and Couchbase

To: Zsombor G <gzso...@gmail.com>

Oh yes! This had been added recently to avoid amount of builds when we open a PR. Since reactive is still in alpha, we suppose that you must enable explicitly the webflux builds by adding the keyword in the commit message. 

[Daniel Franco]

Hello,

Pascal did it on purpose.

See #12156:

Webflux is ignored by default, as it is still in beta and some of these options are not used enough:

• if you want to trigger Webflux build, add [webflux] in your commit message

To view this discussion on the web visit https://groups.google.com/d/msgid/jhipster-dev/CAOO3hRA26nO8XVC6_kzki5mwyoMsKiN2mJuSMboBwzZpAmX9WQ%40mail.gmail.com.

[Aurélien Mino]

Hi,

Regarding issue with react-gradle-psql-es-noi18n-mapsid, it seems to be related to Gradle (it works fine with Maven) that loads hazelcast 3 rather than hazelcast 4:

https://github.com/murdos/generator-jhipster/runs/1048707371?check_suite_focus=true

Description:

An attempt was made to call a method that does not exist. The attempt was made from the following location:

io.github.jhipster.sample.config.CacheConfiguration.initializeDefaultMapConfig(CacheConfiguration.java:93)

The following method did not exist:

'com.hazelcast.config.EvictionConfig com.hazelcast.config.MapConfig.getEvictionConfig()'

The method's class, com.hazelcast.config.MapConfig, is available from the following locations:

jar:file:/home/runner/.gradle/caches/modules-2/files-2.1/com.hazelcast/hazelcast/3.12.8/c92dd8dd1bdd8ed0733aa6e0827761acec46cb6/hazelcast-3.12.8.jar!/com/hazelcast/config/MapConfig.class

The class hierarchy was loaded from the following locations:

com.hazelcast.config.MapConfig: file:/home/runner/.gradle/caches/modules-2/files-2.1/com.hazelcast/hazelcast/3.12.8/c92dd8dd1bdd8ed0733aa6e0827761acec46cb6/hazelcast-3.12.8.jar

I've added a call to the :dependencies task on CI that shows that Hazelcast 4 is detected and should be used, and I don't have the issue locally, so I'm a bit puzzled here.

If anyone has an idea on the way to solve that...

Aurélien

[Vishal Mahajan]

In job logs, I can see the version being picked up as 3.12.8 instead of 4.0.1

2020-08-30T22:17:30.6828124Z |    +--- com.hazelcast:hazelcast:4.0.1 -> 3.12.8 (c)
2020-08-30T22:17:30.6828883Z |    +--- com.hazelcast:hazelcast-spring:4.0.1 -> 3.12.8 (c)

I am not a gradle expert, but, can try to take a quick look over here.

Cheers,

Vishal

To view this discussion on the web visit https://groups.google.com/d/msgid/jhipster-dev/CACXN3_gEW3oizRh%2ByyYywLp-Ljt1Bph9bnMfVPpRdmKpNnzaFw%40mail.gmail.com.

[Fredrik Hahne]

I won't have time before 4th (need to finish a print article about jhipster) so if you have some time please go ahead.

To view this discussion on the web visit https://groups.google.com/d/msgid/jhipster-dev/CAG2s5vNgTMN%3DjTsr2E4i7GLEwYmYJSr4VhFfmNoxzmEhxm1ydg%40mail.gmail.com.

[Vishal Mahajan]

I have created a PR to fix - https://github.com/jhipster/generator-jhipster/pull/12368

Cheers,

Vishal

To view this discussion on the web visit https://groups.google.com/d/msgid/jhipster-dev/d1cf4bcf-ef62-7df4-82d5-90d0fbd830a2%40gmail.com.