Setting up CORS Configuration for a bucket

[jump...@gmail.com]

Hi,

I want to change CORS Configuration of newly created bucket using JetS3t. I could not find any api for this. I want to change the configuration to support cross origin access.

Can anyone help?

Pankaj

[James Murty]

Hi,

JetS3t doesn't support applying CORS settings [1] to a bucket but you can use the AWS Management Console to do this [2].

[1]: http://docs.aws.amazon.com/AmazonS3/latest/dev/cors.html

[2]: http://docs.aws.amazon.com/AmazonS3/latest/UG/EditingBucketPermissions.html

---
jamesmurty.com

--
You received this message because you are subscribed to the Google Groups "JetS3t Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jets3t-users...@googlegroups.com.
To post to this group, send email to jets3t...@googlegroups.com.
Visit this group at http://groups.google.com/group/jets3t-users.
For more options, visit https://groups.google.com/d/optout.

[Paul Gregoire]

James,

If you'd like to point me in the right direction code-wise, I'd be glad to see if I can get CORS support added in. I created an enhancement request for this very feature: https://bitbucket.org/jmurty/jets3t/issues/238/add-support-for-cors

Paul

[James Murty]

Hi Paul,

It would be great if you could submit a pull request for the CORS feature. There's very little chance I will get to it any time soon.

The REST API documentation to set/get/delete the CORS config is here: http://docs.aws.amazon.com/AmazonS3/latest/dev/EnableCorsUsingREST.html

To implement it the best course is probably to:

* copy the *BucketPolicyImpl methods in RestS3Service which work with bucket policy documents, which is almost the same thing. Adjust the new methods to work with CORS documents and the "cors" resource instead

* also copy the *BucketPolicy methods in S3Service which invoke the implementation methods

* add the "cors" request parameter name to the list returned by RestS3Service#getResourceParameterNames so the parameter is treated specially as a resource identifier

* add some unit tests. The existing TestRestS3Service#testLifecycleConfiguration is probably a good one to duplicate and adjust to test the CORS feature.

That should be about it...

 I assume the methods will take a corsXmlDocument string parameter or similar, and it's up to the caller to generate that somehow. In other cases like the `LifecycleConfig` class JetS3t provides helpers to build XML documents, but that would involve a lot more work and I doubt it's worth it for this case?

The java-xmlbuilder library already required/included with JetS3t might be useful for building CORS documents for testing.

Good luck with it. Let me know if you get stuck and I'll help as best I can.

Regards,

James

To unsubscribe from this group and stop receiving emails from it, send an email to jets3t-users+unsubscribe@googlegroups.com.

To post to this group, send email to jets3t...@googlegroups.com.

Visit this group at https://groups.google.com/group/jets3t-users.

[Mondain]

Outstanding! I'll see what I can do, time permitting of course.

Visit this group at https://groups.google.com/group/jets3t-users.

For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to a topic in the Google Groups "JetS3t Users" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jets3t-users/HR9Zi4tUcvQ/unsubscribe.
To unsubscribe from this group and all its topics, send an email to jets3t-users...@googlegroups.com.

To post to this group, send email to jets3t...@googlegroups.com.

[Mondain]

I've done all the initial code work + unit test (passing!); I should have a diff patch later today for your review if all goes well. I am attaching an image showing unit test failures in other areas, only so that you're aware.

Paul

[Mondain]

James,

Attached you'll find the working patch to support AWS S3 CORS. One thing I am having an issue with is the build, ant nor maven properly create the jets3 jar similar to whats found on maven central; if there is a profile or special step, please let me know, thanks!

Best Regards,

Paul

[James Murty]

Hi Paul,

I realise I hadn't gotten back to you about this patch, sorry about that.

I haven't had time to look at the patch or look into the test failures, but it is on my radar.

Cheers,

James

To unsubscribe from this group and stop receiving emails from it, send an email to jets3t-users+unsubscribe@googlegroups.com.

To post to this group, send email to jets3t...@googlegroups.com.

Visit this group at https://groups.google.com/group/jets3t-users.

For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to a topic in the Google Groups "JetS3t Users" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jets3t-users/HR9Zi4tUcvQ/unsubscribe.

To unsubscribe from this group and all its topics, send an email to jets3t-users+unsubscribe@googlegroups.com.

To post to this group, send email to jets3t...@googlegroups.com.
Visit this group at https://groups.google.com/group/jets3t-users.
For more options, visit https://groups.google.com/d/optout.

--

You received this message because you are subscribed to the Google Groups "JetS3t Users" group.

To unsubscribe from this group and stop receiving emails from it, send an email to jets3t-users+unsubscribe@googlegroups.com.

[Mondain]

Its all good James, I'm sure most of us are pretty busy these days and that's a good thing. I'm using a build of the patched source in our private maven repo for now, so whenever you get to it is fine.

Regards,

Paul

Visit this group at https://groups.google.com/group/jets3t-users.

For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to a topic in the Google Groups "JetS3t Users" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jets3t-users/HR9Zi4tUcvQ/unsubscribe.

To unsubscribe from this group and all its topics, send an email to jets3t-users...@googlegroups.com.

To post to this group, send email to jets3t...@googlegroups.com.

Visit this group at https://groups.google.com/group/jets3t-users.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "JetS3t Users" group.

To unsubscribe from this group and stop receiving emails from it, send an email to jets3t-users...@googlegroups.com.
To post to this group, send email to jets3t...@googlegroups.com.

Visit this group at https://groups.google.com/group/jets3t-users.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to a topic in the Google Groups "JetS3t Users" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jets3t-users/HR9Zi4tUcvQ/unsubscribe.

To unsubscribe from this group and all its topics, send an email to jets3t-users...@googlegroups.com.

To post to this group, send email to jets3t...@googlegroups.com.

[Mondain]

Hello James,

It's been a couple years now since we last coordinated and I'd like to put the modified source in a public github repo, so that I can provide maintenance. Do you have any issue with this course? Full creator attribution etc will remain as well as any links back to your repo.

Best Regards,

Paul

[James Murty]

Hi Paul,

It’s fine by me for you to put JetS3t code on GitHub with your improvements. 

When you say you will provide maintenance, do you mean just for your changes or for the project as a whole? 

I am not able to spend time on it any more so if you are willing and/or planning to take over ownership of the project I would be completely in favour. It’s basically moribund as is. 

Let me know what you are thinking and I’ll try to help out as best I can if needed. 

Cheers,

James

[Mondain]

Yes, I'm cool with taking the helm as I have to make adjustments for my corporate work and I want those fixes to be available to the opensource public.

Best Regards,

Paul

[David Kocher]

We are also maintaining a fork of Jets3t at https://github.com/iterate-ch/jets3t

– David

> On 25 Oct 2018, at 11:06, James Murty <ja...@murty.co> wrote:
>
> Hi Paul,
>

[Mondain]

James, 

I put up a repo here https://github.com/mondain/jets3t and started the Maven work; if you see anything not to your liking, let me know. I have not added my CORS patch yet.

Regards,

Paul

[James Murty]

Hi Paul,

I have applied the TXT record to jets3t.org in what I hope is the correct format. See for example https://mxtoolbox.com/SuperTool.aspx?action=txt%3ajets3t.org&run=toolpage#

Like every time I have dealt with Sonatype, it's unclear exactly what I am supposed to do and I can't find any useful documentation. I guess the next step is to ask them to confirm the TXT record and see if your request proceeds.

I also posted a notification about you taking on the maintainer role to the JetS3t Users mailing list, to help kick of this transition more formally and to hopefully get you some contributors to help out – https://groups.google.com/forum/#!topic/jets3t-users/GoErNkCYiyE

Regards,

James