Re: Digest for jenkinsrb@googlegroups.com - 3 Messages in 1 Topic

[Michael Dodge]

On Sun, Jan 1, 2012 at 3:25 AM, <jenk...@googlegroups.com> wrote:

  Today's Topic Summary

Group: http://groups.google.com/group/jenkinsrb/topics

• Request for comment: Descriptor change [3 Updates]

 Request for comment: Descriptor change

Kohsuke Kawaguchi <kkawa...@cloudbees.com> Dec 31 01:28PM -0800  

I've posted my proposed chage to jenkins-plugin-runtime.rb at
https://github.com/jenkinsci/jenkins-plugin-runtime.rb/pull/1
 
This is also documented at [2].
 
If someone (I'm mostly looking at Charles) can take a look at it and see
if the general direction is OK, that'd be greatly appreciated.
(This came up in the context of supporting RVM as a matrix axis.)
 
 
One thing I notice is the asymmetry in associating various proxy objects
(see describe_as/descriptor_is/JPP::register in [1]) I wonder if we
should be better off just having one method that does all the
association in one go, like
 
 
register self, J::P::P::AxisProxy, J::P::P::AxisDescriptorProxy,
Java.hudson.matrix.Axis
 
?
 
The other thing I notice is the name overlaps. In the current naming
convention, we've got three "Builder"s --- one Java class,
Jenkins::Plugin::Proxies::Builder, and Jenkins::Tasks::Builder. I'd like
to suggest that proxies have the "Proxy" suffix (that is,
Jenkins::Plugin::Proxies::BuilderProxy) to reduce the confusion.
 
 
 
 
[1] https://github.com/jenkinsci/rvm-plugin/blob/axis/models/axis.rb
[2] https://wiki.jenkins-ci.org/display/JENKINS/Ruby+glue+layer
--
Kohsuke Kawaguchi | CloudBees, Inc. | http://cloudbees.com/
Try Nectar, our professional version of Jenkins


 

Kohsuke Kawaguchi <kkawa...@cloudbees.com> Dec 31 05:01PM -0800  

And I've added another pull request [1] needed for adding the matrix
support in the RVM plugin.
 
[1] https://github.com/jenkinsci/jenkins-plugin-runtime.rb/pull/2
 
On 12/31/2011 01:28 PM, Kohsuke Kawaguchi wrote:
 
--
Kohsuke Kawaguchi | CloudBees, Inc. | http://cloudbees.com/
Try Nectar, our professional version of Jenkins


 

"R. Tyler Croy" <ty...@monkeypox.org> Dec 31 05:07PM -0800  

I'm not sure if Jorgen is on the jenkinsrb list, so I'm going to pull him in on
this thread since he'll likely be interested in this as well :)
 
 
On Sat, 31 Dec 2011, Kohsuke Kawaguchi wrote:
 
> >Jenkins::Plugin::Proxies::BuilderProxy) to reduce the confusion.
 
> >[1] https://github.com/jenkinsci/rvm-plugin/blob/axis/models/axis.rb
> >[2] https://wiki.jenkins-ci.org/display/JENKINS/Ruby+glue+layer
 
- R. Tyler Croy
--------------------------------------
Code: http://github.com/rtyler
Chatter: http://twitter.com/agentdero
rty...@jabber.org


 

You received this message because you are subscribed to the Google Group jenkinsrb.
You can post via email.
To unsubscribe from this group, send an empty message.
For more options, visit this group.