[Pipeline Maven Plugin] Naming convention for the configuration attributes?

14 views
Skip to first unread message

Cyrille Le Clerc

unread,
Aug 16, 2016, 4:05:48 AM8/16/16
to Jenkins Users, Alvaro Andres Lobato Moreno
Hello,

I would like to have a discussion on the naming convention of the configuration attributes before we release the first "non experimental" version of the plugin.

I have identified the following configuration attributes:
  • jdk 
  • mavenInstallation
  • mavenLocalRepo
  • mavenSettingsConfig
  • mavenSettingsFilePath
  • mavenOpts
I like the "maven" prefix for all the attributes that are related to Maven.

I am not totally comfortable with the fact that we don't have the same convention for the two configuration attributes related to tool installations.
For the installation of Maven, we suffix the configuration attribute name by "installation" using "mavenInstallation" when for the JDK, we don't use a suffix and we use the name "jdk".

Wouldn't it be more consistent to rename the attribute "jdk" into "jdkInstallation"?

Cyrille
Reply all
Reply to author
Forward
0 new messages