[github-oauth-plugin] JENKINS-50122: Authorization should work with basic Workflow jobs

[Jonathan Pigree]

Hi everyone. I have a bug in the github plugin which is already referenced by a ticket and a PR:

- https://issues.jenkins-ci.org/browse/JENKINS-50122

- https://github.com/jenkinsci/github-oauth-plugin/pull/99/files

However, the PR is nearly 1 year old and I am trying to figure out how to fix it to make it mergeable and propagate it to my jenkins installation.

From my understanding, the whole problem comes from the assumption that we want only WorkflowJob which have the "BranchJobProperty" set.

However, I grepped the whole workflow-job-plugin code without finding any trace of that property. The workflow-multibranch-plugin however does set this property.

So basically, this code is false. We need to use a way to fetch the branch name which is compatible for both workflow job and multibranch workflow jobs.

In the PR, I think the reviewer didn't understood what was the problem so it went nowhere. can someone review it again? I think the changes proposed by masterzen are valid but if they aren't I am willing to help fixing it.

Thanks.

[Jonathan Pigree]

UPDATE: I dug into the problem deeper and the previous PR was based on very old code so I made a new one from latest master.

https://github.com/jenkinsci/github-oauth-plugin/pull/114

Hope it will be reviewed soon.