[JIRA] (JENKINS-49141) P4 plugin removed BOM from utf8 files

14 views
Skip to first unread message

pallen@perforce.com (JIRA)

unread,
Feb 13, 2018, 7:11:02 AM2/13/18
to jenkinsc...@googlegroups.com
Paul Allen updated an issue
 
Jenkins / Bug JENKINS-49141
P4 plugin removed BOM from utf8 files
Change By: Paul Allen
Labels: P4_B
Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
Atlassian logo

peanderson@ea.com (JIRA)

unread,
Feb 26, 2018, 5:40:03 AM2/26/18
to jenkinsc...@googlegroups.com
peter anderson commented on Bug JENKINS-49141
 
Re: P4 plugin removed BOM from utf8 files

Hey Paul Allen, any chance you will be able to take a look at this in the near future?

Although its not a "blocker" as such, I don't feel comfortable upgrading when the plugin behaviour is so different to the exe behaviour 

kwirth@perforce.com (JIRA)

unread,
Feb 26, 2018, 5:51:03 AM2/26/18
to jenkinsc...@googlegroups.com
Karl Wirth updated an issue
 
Change By: Karl Wirth
Labels: P4_B P4_SUPPORT

kwirth@perforce.com (JIRA)

unread,
Feb 26, 2018, 5:52:02 AM2/26/18
to jenkinsc...@googlegroups.com
Karl Wirth commented on Bug JENKINS-49141
 
Re: P4 plugin removed BOM from utf8 files

Will work with Peter on this.

peanderson@ea.com (JIRA)

unread,
Feb 26, 2018, 8:56:02 AM2/26/18
to jenkinsc...@googlegroups.com

p4 ticket: RE: Perforce Jenkins Plugin Bug     ref:_00DA09M15._5000G1RiJb9:ref 

 

The guys at p4 have reproduced the bug and will work with Paul Allen to fix it. 

kwirth@perforce.com (JIRA)

unread,
Feb 27, 2018, 4:45:03 AM2/27/18
to jenkinsc...@googlegroups.com
Karl Wirth updated an issue
Change By: Karl Wirth
Attachment: test.ps1

kwirth@perforce.com (JIRA)

unread,
Feb 27, 2018, 4:45:04 AM2/27/18
to jenkinsc...@googlegroups.com
Karl Wirth commented on Bug JENKINS-49141
 
Re: P4 plugin removed BOM from utf8 files

Reproduction steps:

  1. Submit *.ps1 with BOM on Windows.
  2. Sync on Windows BOM still in file.
  3. Sync on Linux BOM still in file.
  4. Sync via P4Jenkins BOM removed but visible contents of the file looks the same.
  5. Expected behavior BOM remains.

File before submitting (attached test.ps1):

$ od -h test.ps1
0000000 bbef 54bf 6968 2073 7369 6120 7420 7365
0000020 2e74 0a20 6e55 6369 646f 2065 6164 6873
0000040 203a 80e2 0a94 6e41 2064 6e61 6120 6373
0000060 6969 6420 7361 3a68 2d20 000a
0000073

kwirth@perforce.com (JIRA)

unread,
Feb 27, 2018, 4:46:02 AM2/27/18
to jenkinsc...@googlegroups.com
Karl Wirth updated an issue
Change By: Karl Wirth
Labels: P4_B P4_SUPPORT P4_VERIFY

kwirth@perforce.com (JIRA)

unread,
Feb 27, 2018, 5:12:03 AM2/27/18
to jenkinsc...@googlegroups.com
Karl Wirth edited a comment on Bug JENKINS-49141
 
Re: P4 plugin removed BOM from utf8 files
*Reproduction steps:*
# Submit *.ps1 with BOM on Windows.
# Sync on Windows BOM still in file.
# Sync on Linux BOM still in file.
# Sync via P4Jenkins BOM removed but visible contents of the file looks the same.
# Expected behavior BOM remains.


File before submitting (attached test.ps1):
{code:java}

$ od -h test.ps1
0000000 bbef 54bf 6968 2073 7369 6120 7420 7365
0000020 2e74 0a20 6e55 6369 646f 2065 6164 6873
0000040 203a 80e2 0a94 6e41 2064 6e61 6120 6373
0000060 6969 6420 7361 3a68 2d20 000a
0000073
{code}
Workaround of setting
{code:java}
JAVA_ARGS="-Dcom.perforce.p4java.filesys.utf8bom=1 {code}
in JAVA in  '/etc/default/jenkins' does not solve problem when syncing on the master.

 

kwirth@perforce.com (JIRA)

unread,
Mar 1, 2018, 6:36:03 AM3/1/18
to jenkinsc...@googlegroups.com

Hi Paul Allen. FYI - Causing another customers builds (compilation) to fail.

nvamsicharan@gmail.com (JIRA)

unread,
Mar 5, 2018, 4:14:02 AM3/5/18
to jenkinsc...@googlegroups.com

Jenkins Version: Jenkins ver. 1.651.3

P4 Plugin Version: 1.8.3

If I sync the source code from Windows based PV4 client, build will load on the simulator without any issue.

Build using Perforce source sync using Jenkins p4 fails to load the application on to the simulator.

Karl Wirth has confirmed that on of our files BOM characters have been stripped.

 

We run the Linux based builds. Without the fix for this issue, we have to sustain syncing manually using windows client and run the build on the Linux servers.

 

pallen@perforce.com (JIRA)

unread,
Mar 15, 2018, 11:35:02 AM3/15/18
to jenkinsc...@googlegroups.com
Paul Allen updated an issue
 
Change By: Paul Allen
Labels: P4_B P4_VERIFY

kwirth@perforce.com (JIRA)

unread,
Mar 19, 2018, 9:01:04 AM3/19/18
to jenkinsc...@googlegroups.com
Karl Wirth commented on Bug JENKINS-49141
 
Re: P4 plugin removed BOM from utf8 files

Updating this to keep it at top of list - Still an important problem for multiple customers.

scm_issue_link@java.net (JIRA)

unread,
Mar 20, 2018, 7:59:03 AM3/20/18
to jenkinsc...@googlegroups.com

Code changed in jenkins
User: Paul Allen
Path:
UNICODE.md
docs/images/node-advanced.png
docs/images/node-jvmoptions.png
src/main/java/org/jenkinsci/plugins/p4/client/ConnectionFactory.java
http://jenkins-ci.org/commit/p4-plugin/b45fa1f221622efda37713a85cd278a6798eea57
Log:
Leave the filesys.utf8bom property unset.

Updated docs to explain how to set the undoc configurable for builds
slaves.

JENKINS-49141

wbasu@perforce.com (JIRA)

unread,
Mar 21, 2018, 1:29:04 PM3/21/18
to jenkinsc...@googlegroups.com
W Basu updated an issue
 
Change By: W Basu
Labels: P4_B P4_A

wbasu@perforce.com (JIRA)

unread,
Mar 21, 2018, 1:32:02 PM3/21/18
to jenkinsc...@googlegroups.com
W Basu started work on Bug JENKINS-49141
 
Change By: W Basu
Status: Open In Progress

pallen@perforce.com (JIRA)

unread,
Mar 21, 2018, 1:35:02 PM3/21/18
to jenkinsc...@googlegroups.com
Paul Allen resolved as Fixed
 

Ready for release.
Change By: Paul Allen
Status: In Progress Resolved
Resolution: Fixed

pallen@perforce.com (JIRA)

unread,
Apr 3, 2018, 7:08:05 AM4/3/18
to jenkinsc...@googlegroups.com
Paul Allen closed an issue as Fixed
 

Released in 1.8.8
Change By: Paul Allen
Status: Resolved Closed
Assignee: Paul Allen

ramkrishna67@yahoo.com (JIRA)

unread,
May 8, 2020, 6:24:02 AM5/8/20
to jenkinsc...@googlegroups.com
ram Shukla commented on Bug JENKINS-49141
 
Re: P4 plugin removed BOM from utf8 files

am facing the the same issue on P4Plugin version 1.10.4 and jenkins version 2.190.3
error CNDL0104 : Not a valid source file; detail: Data at the root level is invalid. Line 1, position 1.
This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)
Atlassian logo

ramkrishna67@yahoo.com (JIRA)

unread,
May 8, 2020, 6:24:04 AM5/8/20
to jenkinsc...@googlegroups.com
ram Shukla edited a comment on Bug JENKINS-49141
am facing the the same issue on P4Plugin version 1.10. 4 6 and jenkins version 2.190.3

error CNDL0104 : Not a valid source file; detail: Data at the root level is invalid. Line 1, position 1.

kwirth@perforce.com (JIRA)

unread,
May 11, 2020, 3:45:03 AM5/11/20
to jenkinsc...@googlegroups.com

Hi ram Shukla - Please provide a screenshot of where you are seeing this error. Is it with the file you synced when you try to use it or when running the job?
Reply all
Reply to author
Forward
0 new messages