[JIRA] (JENKINS-59827) Wrong commit link to GitLab

27 views
Skip to first unread message

theirix@gmail.com (JIRA)

unread,
Oct 17, 2019, 11:19:03 AM10/17/19
to jenkinsc...@googlegroups.com
Eugene Seliverstov created an issue
 
Jenkins / Bug JENKINS-59827
Wrong commit link to GitLab
Issue Type: Bug Bug
Assignee: Mark Waite
Components: git-plugin
Created: 2019-10-17 15:18
Environment: Jenkins LTS 2.190.1 (self-hosted), git plugin 3.12.1, GitLab 12
Priority: Minor Minor
Reporter: Eugene Seliverstov

Let we have a job that points to GitLab repository. Any Jenkins changes view with a list of commits provides a wrong link to GitLab commit (changeset).

 

Example page: https://JENKINS_URL/job/JOB_NAME/job/master/1/changes

Expected link: https://gitlab.com/OWNER/REPO/commit/HASH

Actual link: https://gitlab.com/commit/HASH

 

I suppose the `GitLab::getChangeSetLink` is broken since maybe gitlab 7. It should include repository information in the URL.
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo

mark.earl.waite@gmail.com (JIRA)

unread,
Nov 3, 2019, 8:03:02 PM11/3/19
to jenkinsc...@googlegroups.com
Mark Waite assigned an issue to Unassigned
Change By: Mark Waite
Assignee: Mark Waite

mark.earl.waite@gmail.com (JIRA)

unread,
Nov 4, 2019, 8:24:03 AM11/4/19
to jenkinsc...@googlegroups.com
Mark Waite updated an issue
Change By: Mark Waite
Attachment: 01-gitlab-browser-definition.png

mark.earl.waite@gmail.com (JIRA)

unread,
Nov 4, 2019, 8:25:02 AM11/4/19
to jenkinsc...@googlegroups.com
Mark Waite updated an issue
Change By: Mark Waite
Attachment: 02-gitlab-recent-changes-link.png

mark.earl.waite@gmail.com (JIRA)

unread,
Nov 4, 2019, 8:27:03 AM11/4/19
to jenkinsc...@googlegroups.com
Mark Waite updated an issue
Change By: Mark Waite
Attachment: 03-gitlab-destination-page.png

mark.earl.waite@gmail.com (JIRA)

unread,
Nov 4, 2019, 8:28:03 AM11/4/19
to jenkinsc...@googlegroups.com
Mark Waite updated an issue
Change By: Mark Waite
Attachment: 04-gitlab-build-3-build-page.png

mark.earl.waite@gmail.com (JIRA)

unread,
Nov 4, 2019, 8:29:03 AM11/4/19
to jenkinsc...@googlegroups.com
Mark Waite updated an issue
Change By: Mark Waite
Attachment: 05-gitlab-build-3-changes-page.png

mark.earl.waite@gmail.com (JIRA)

unread,
Nov 4, 2019, 8:29:03 AM11/4/19
to jenkinsc...@googlegroups.com
Mark Waite updated an issue
Change By: Mark Waite
Attachment: 05-2-gitlab-build-3-changes-page-diff-destination.png

mark.earl.waite@gmail.com (JIRA)

unread,
Nov 4, 2019, 8:29:03 AM11/4/19
to jenkinsc...@googlegroups.com
Mark Waite updated an issue
Change By: Mark Waite
Attachment: 05-1-gitlab-build-3-changes-page-README-destination.png

mark.earl.waite@gmail.com (JIRA)

unread,
Nov 4, 2019, 8:30:03 AM11/4/19
to jenkinsc...@googlegroups.com
Mark Waite edited a comment on Bug JENKINS-59827
 
Re: Wrong commit link to GitLab
I'm unable to duplicate the problem you're describing when I use one of my private repositories hosted on gitlab.com.

h2. Steps I took

# Define Freestyle job that uses a gitlab browser.  Define the URL for the gitlab repository browser as https://gitlab.com/MarkEWaite/bin (note that it is "gitlab" in the git plugin, not the "GitLab" browser.  The "GitLab" browser appears to be added by the GitLab Branch Source plugin and has a serious bug)
!01-gitlab-browser-definition.png|thumbnail!
# Build the job
# Push a change to the gitlab repository
# Build the job again
# Click the "Recent Changes" link  !02-gitlab-recent-changes-link.png|thumbnail!
# Confirm that the recent changes link opens gitlab.com  !03-gitlab-destination-page.png|thumbnail!
# Open the page for the specific build (build 3 in my case)  !04-gitlab-build-3-build-page.png|thumbnail!
# Open the changes page for the specific build (build 3 changes in my case)  !05-gitlab-build-3-changes-page.png|thumbnail!
# Confirm that the README link on the changes page opens gitlab.com correctly  !05-1-gitlab-build-3-changes-page-README-destination.png|thumbnail!
# Confirm that the diff link on the changes page opens gitlab.com correctly  !05-2-gitlab-build-3-changes-page-diff-destination.png|thumbnail!

Can you provide more details so that I understand the difference between the working environment that I see and your environment that is failing?

mark.earl.waite@gmail.com (JIRA)

unread,
Nov 4, 2019, 8:30:04 AM11/4/19
to jenkinsc...@googlegroups.com

I'm unable to duplicate the problem you're describing when I use one of my private repositories hosted on gitlab.com.

Steps I took

  1. Define Freestyle job that uses a gitlab browser. Define the URL for the gitlab repository browser as https://gitlab.com/MarkEWaite/bin (note that it is "gitlab" in the git plugin, not the "GitLab" browser. The "GitLab" browser appears to be added by the GitLab Branch Source plugin and has a serious bug)
  2. Build the job
  1. Push a change to the gitlab repository
  1. Build the job again
  2. Click the "Recent Changes" link
  3. Confirm that the recent changes link opens gitlab.com
  4. Open the page for the specific build (build 3 in my case)
  5. Open the changes page for the specific build (build 3 changes in my case)
  6. Confirm that the README link on the changes page opens gitlab.com correctly
  7. Confirm that the diff link on the changes page opens gitlab.com correctly

Can you provide more details so that I understand the difference between the working environment that I see and your environment that is failing?

mark.earl.waite@gmail.com (JIRA)

unread,
Nov 4, 2019, 8:31:02 AM11/4/19
to jenkinsc...@googlegroups.com
Mark Waite edited a comment on Bug JENKINS-59827
I'm unable to duplicate the problem you're describing when I use one of my private repositories hosted on gitlab.com.

h2. Steps I took

# Define Freestyle job that uses a gitlab browser.  Define the URL for the gitlab repository browser as https://gitlab.com/MarkEWaite/bin (note that it is "gitlab" in the git plugin, not the "GitLab" browser.  The "GitLab" browser appears to be added by the GitLab Branch Source plugin and has a serious bug)
!01-gitlab-browser-definition.png|thumbnail!
# Build the job
# Push a change to the gitlab repository
# Build the job again
# Click the "Recent Changes" link   
   !02-gitlab-recent-changes-link.png|thumbnail!
# Confirm that the recent changes link opens gitlab.com   
   !03-gitlab-destination-page.png|thumbnail!
# Open the page for the specific build (build 3 in my case)   
   !04-gitlab-build-3-build-page.png|thumbnail!
# Open the changes page for the specific build (build 3 changes in my case)   
   !05-gitlab-build-3-changes-page.png|thumbnail!
# Confirm that the README link on the changes page opens gitlab.com correctly   
   !05-1-gitlab-build-3-changes-page-README-destination.png|thumbnail!
# Confirm that the diff link on the changes page opens gitlab.com correctly   
   !05-2-gitlab-build-3-changes-page-diff-destination.png|thumbnail!

Can you provide more details so that I understand the difference between the working environment that I see and your environment that is failing?

mark.earl.waite@gmail.com (JIRA)

unread,
Nov 4, 2019, 8:31:05 AM11/4/19
to jenkinsc...@googlegroups.com
Mark Waite assigned an issue to Eugene Seliverstov
 
Change By: Mark Waite
Assignee: Eugene Seliverstov

theirix@gmail.com (JIRA)

unread,
Nov 4, 2019, 8:46:02 AM11/4/19
to jenkinsc...@googlegroups.com
Eugene Seliverstov commented on Bug JENKINS-59827
 
Re: Wrong commit link to GitLab

Could you please post links (1) and (2) from step 8 so I check with the failing environment?

mark.earl.waite@gmail.com (JIRA)

unread,
Nov 4, 2019, 8:55:02 AM11/4/19
to jenkinsc...@googlegroups.com
Mark Waite edited a comment on Bug JENKINS-59827
I'm unable to duplicate the problem you're describing when I use one of my private repositories hosted on gitlab.com.

h2. Steps I took

# Define Freestyle job that uses a gitlab browser.  Define the URL for the gitlab repository browser as https://gitlab.com/MarkEWaite/bin (note that it is "gitlab" in the git plugin, not the "GitLab" browser.  The "GitLab" browser appears to be added by the GitLab Branch Source plugin and has a serious bug)
!01-gitlab-browser-definition.png|thumbnail!
# Build the job
# Push a change to the gitlab repository
# Build the job again
# Click the "Recent Changes" link  
!02-gitlab-recent-changes-link.png|thumbnail!
# Confirm that the recent changes link opens gitlab.com  
!03-gitlab-destination-page.png|thumbnail!
# Open the page for the specific build (build 3 in my case)  
!04-gitlab-build-3-build-page.png|thumbnail!
# Open the changes page for the specific build (build 3 changes in my case)  
!05-gitlab-build-3-changes-page.png|thumbnail!
# Confirm that the README link on the changes page opens gitlab.com correctly   
!05-1-gitlab-build-3-changes-page-README-destination.png|thumbnail!
# Confirm that the diff link on the changes page opens gitlab.com correctly   
!05-2-gitlab-build-3-changes-page-diff-destination.png|thumbnail!

Can you provide more details so that I understand the difference between the working environment that I see and your environment that is failing?

theirix@gmail.com (JIRA)

unread,
Nov 4, 2019, 9:17:01 AM11/4/19
to jenkinsc...@googlegroups.com

Thanks for detailed explanations! I figured out that a repository configuration in step (1) must contain the path to a repository after the Gitlab domain. I thought before it can be decided by Jenkins from the repository and domain URL.

So it is not a bug.

theirix@gmail.com (JIRA)

unread,
Nov 4, 2019, 9:20:02 AM11/4/19
to jenkinsc...@googlegroups.com
Eugene Seliverstov closed an issue as Not A Defect
 

not a bug
Change By: Eugene Seliverstov
Status: Open Closed
Resolution: Not A Defect
Reply all
Reply to author
Forward
0 new messages