[JIRA] (JENKINS-60194) Separate injector for test resources

mez.pahlan@gmail.com (JIRA)

unread,

Nov 18, 2019, 4:32:03 AM11/18/19

to jenkinsc...@googlegroups.com

Mez Pahlan created an issue

Jenkins /

JENKINS-60194

Separate injector for test resources

Issue Type:	Improvement
Assignee:	Mez Pahlan
Components:	appcenter-plugin
Created:	2019-11-18 09:31
Priority:	Minor
Reporter:	Mez Pahlan

Dagger has helped this project a lot but at the moment there is a hard coded dependency on the production DaggerComponent. This limits what we can do with tests.

Acceptance Criteria:

AppCenterRecorder class does not refer directly to production Dagger Component.
Test Dagger Component is available.
Integration tests are updated to reference the Test Dagger Component.
Additional tests are added for Integration tests that attempt to parse the APK but fail because we don't supply a valid APK in tests.
Optionally: Remove the set base url in the AppCenterRecorder. This is only here for testing purposes but if it could be injected that would be ideal.