[JIRA] (JENKINS-37828) Pipeline Model: Steps at peer level to parallel below stage cause compilation error

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer created an issue

Jenkins / JENKINS-37828 Pipeline Model: Steps at peer level to parallel below stage cause compilation error Issue Type: Bug Assignee: Andrew Bayer Components: pipeline-model-definition-plugin Created: 2016/Aug/30 10:24 PM Environment: Pipeline Model 0.1 Priority: Minor Reporter: Andrew Bayer This is a fun side effect of ParallelStep not having a DataBoundConstructor - theoretically, it should be possible to have both parallel and other steps directly within a stage, but the attempt to validate the arguments to parallel goes wrong due to that missing DataBoundConstructor. The ModelParser does look for parallel and treat it differently if it's the only step under the stage, but we're not looking for that in JSONParser at all, and we're not rejecting parallel in other cases in the first place. So...need to think about this some. Add Comment

This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer started work on JENKINS-37828

Change By: Andrew Bayer Status: Open In Progress

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer commented on JENKINS-37828

Re: Pipeline Model: Steps at peer level to parallel below stage cause compilation error PR up at https://github.com/jenkinsci/pipeline-model-definition-plugin/pull/2

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer updated JENKINS-37828

Jenkins / JENKINS-37828

Pipeline Model: Steps at peer level to parallel below stage cause compilation error

Change By: Andrew Bayer Status: In Progress Review

Add Comment

[scm_issue_link@java.net (JIRA)]

SCM/JIRA link daemon commented on JENKINS-37828

Re: Pipeline Model: Steps at peer level to parallel below stage cause compilation error Code changed in jenkins User: Andrew Bayer Path: src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/ast/ModelASTStep.groovy src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/validator/ModelValidator.groovy src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/ValidatorTest.java src/test/resources/errors/rejectParallelMixedInSteps.groovy http://jenkins-ci.org/commit/pipeline-model-definition-plugin/cb86d2ba560a5d89005495876376d549fc6a1b44 Log: [FIXED JENKINS-37828] Properly reject parallel. More notably, reject it when it's not the only step in a block. In the JSON representation, we don't even use the term parallel - we just have multiple branches. In the groovy parsing, we look for parallel as the only step in a stage and treat it differently (resulting in multiple branches). So any time we see parallel as a step by the time we get to validation, well, it's wrong. So, yeah.

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer updated JENKINS-37828

Will be released in Pipeline Model Definition 0.2

Jenkins / JENKINS-37828

Pipeline Model: Steps at peer level to parallel below stage cause compilation error

Change By: Andrew Bayer Status: In Review Resolved Resolution: Fixed

Add Comment

[bitwiseman@gmail.com (JIRA)]

Liam Newman closed an issue as Fixed

Bulk closing resolved issues.

Jenkins / JENKINS-37828 Pipeline Model: Steps at peer level to parallel below stage cause compilation error

Change By: Liam Newman Status: Resolved Closed

Add Comment

This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)