[JIRA] [ws-cleanup] (JENKINS-24824) Asynchronous cleanup not removing renamed workspace directories on slaves

[tom.moore@cadillacjack.com (JIRA)]

Tom Moore created JENKINS-24824 Asynchronous cleanup not removing renamed workspace directories on slaves Issue Type: Bug Assignee: vjuranek Components: ws-cleanup Created: 23/Sep/14 12:10 PM Description: After upgrading to ws-cleanup 0.24 in order to get the asynchronous cleanup function we noticed the workspaces on our slaves getting renamed to the form of ${WORKSPACE}ws-cleanup${TIMESTAMP}. (ie, job1 would become job1_ws-cleanup_1411197183394). The expected behavior under ws-cleanup 0.24 is that these were temporary to support asynchronous processing and would be deleted. However, these directories never get removed from the slave. Over time, the slave hard drives filled up resulting in build failures. Environment: Jenkins 1.579 ws-cleanup 0.24 Project: Jenkins Priority: Major Reporter: Tom Moore

This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira

[vjuranek@java.net (JIRA)]

vjuranek commented on JENKINS-24824

Asynchronous cleanup not removing renamed workspace directories on slaves

Hi, any idea how to reproduce it? Everything works fine on my machine. Do you use any "Advanced" options? If so, which one? What is the OS of the slave where ws is not deleted? Thanks

[tom.moore@cadillacjack.com (JIRA)]

Tom Moore commented on JENKINS-24824

Asynchronous cleanup not removing renamed workspace directories on slaves

The slaves are running on a VM that is running Windows 7 Enterprise, Service Pack 1. The slaves start their Jenkins connection via slave command line. Running as a Windows service is not an option as the build process must be subordinate to an active login session due to compiler restrictions. No advanced options were set.

[ogondza@gmail.com (JIRA)]

Oliver Gondža commented on JENKINS-24824

Asynchronous cleanup not removing renamed workspace directories on slaves

I expect the deletion can fail for some reason even after we successfully renamed the directory. I see several ways to improve current situation: Retry the deletion until it succeeds - it should not block the build but can as well run for unpredictable amount of time Introduce a periodic task to clean up such dangling directories Pass Future from FilePath.actAsync to some "collector" task that would retry and/or report in case some deletion fails.* I guess this might be the only way to find out why it failed on the first place as it seems that FilePath.actAsync does not log exceptions.

[ogondza@gmail.com (JIRA)]

Oliver Gondža edited a comment on JENKINS-24824

Asynchronous cleanup not removing renamed workspace directories on slaves

I expect the deletion can fail for some reason even after we successfully renamed the directory. I see several ways to improve current situation:

Retry the deletion until it succeeds - it should not block the build but can as well run for unpredictable amount of time Introduce a periodic task to clean up such dangling directories Pass Future from FilePath.actAsync to some "collector" task that would retry and/or report in case some deletion fails.*

[*] I guess this might be the only way to find out why it failed on the first place as it seems that FilePath.actAsync does not log exceptions.