[JIRA] (JENKINS-42498) Declarative Pipeline serialization errors when XStreamPickle is used

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer updated an issue

Jenkins / JENKINS-42498 Declarative Pipeline serialization errors when XStreamPickle is used Change By: Andrew Bayer Summary: Declarative Pipeline serialization errors when -> expression fails XStreamPickle is used Add Comment

This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer commented on JENKINS-42498

Re: Declarative Pipeline serialization errors when XStreamPickle is used PR up at https://github.com/jenkinsci/pipeline-model-definition-plugin/pull/131

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer updated JENKINS-42498

Jenkins / JENKINS-42498

Declarative Pipeline serialization errors when XStreamPickle is used

Change By: Andrew Bayer Status: In Progress Review

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer commented on JENKINS-42498

Re: Declarative Pipeline serialization errors when XStreamPickle is used After initial review, I tried an alternate approach, which is up at https://github.com/jenkinsci/pipeline-model-definition-plugin/pull/132

Add Comment

[scm_issue_link@java.net (JIRA)]

SCM/JIRA link daemon commented on JENKINS-42498

Re: Declarative Pipeline serialization errors when XStreamPickle is used

Code changed in jenkins User: Andrew Bayer Path: pipeline-model-api/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/ast/AbstractModelASTCodeBlock.java pipeline-model-api/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/ast/ModelASTArgumentList.java pipeline-model-api/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/ast/ModelASTNamedArgumentList.java pipeline-model-api/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/ast/ModelASTPositionalArgumentList.java pipeline-model-api/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/ast/ModelASTSingleArgument.java pipeline-model-api/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/ast/ModelASTWhenContent.java pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/Utils.groovy pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/model/StageConditionals.groovy pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/validator/ModelValidatorImpl.groovy pipeline-model-definition/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/when/impl/BranchConditional.java pipeline-model-definition/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/when/impl/EnvironmentConditional.java pipeline-model-definition/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/when/impl/ExpressionConditional.java pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/ClosureModelTranslator.groovy pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/ModelInterpreter.groovy pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/when/impl/BranchConditionalScript.groovy pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/when/impl/EnvironmentConditionalScript.groovy pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/when/impl/ExpressionConditionalScript.groovy pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/SerializationTest.java pipeline-model-definition/src/test/resources/serializationWhenEnvGString.groovy http://jenkins-ci.org/commit/pipeline-model-definition-plugin/5cd7237782bf16c24ba4939cf4a8d3013f883ccc Log: [FIXED JENKINS-42498] Stop evaluating when conditions at runtime Pull the when conditions in by translating them from the AST model, which does require some evaluation of strings here and there, but avoids having any Closures in the Describables.

Add Comment

[scm_issue_link@java.net (JIRA)]

SCM/JIRA link daemon commented on JENKINS-42498

Re: Declarative Pipeline serialization errors when XStreamPickle is used

Code changed in jenkins User: Andrew Bayer Path:

pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/SerializationTest.java pipeline-model-definition/src/test/resources/serializationAgentGString.groovy pipeline-model-definition/src/test/resources/serializationAgentNestedGString.groovy pipeline-model-definition/src/test/resources/serializationEnvGString.groovy pipeline-model-definition/src/test/resources/serializationJobPropsGString.groovy pipeline-model-definition/src/test/resources/serializationLibrariesGString.groovy pipeline-model-definition/src/test/resources/serializationParametersGString.groovy pipeline-model-definition/src/test/resources/serializationTriggersGString.groovy pipeline-model-definition/src/test/resources/serializationWhenBranchGString.groovy http://jenkins-ci.org/commit/pipeline-model-definition-plugin/0a0b0d7a8a74f3a14ce2bbdbffe0e755708c168b Log: JENKINS-42498 Failure test for JENKINS-42498 serialization

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer updated JENKINS-42498

Jenkins / JENKINS-42498

Declarative Pipeline serialization errors when XStreamPickle is used

Change By: Andrew Bayer Status: In Review Resolved Resolution: Fixed

Add Comment

[bitwiseman@gmail.com (JIRA)]

Liam Newman closed an issue as Fixed

Bulk closing resolved issues.

Jenkins / JENKINS-42498 Declarative Pipeline serialization errors when XStreamPickle is used

Change By: Liam Newman Status: Resolved Closed

Add Comment

This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)