[JIRA] (JENKINS-61398) Source Code Management for build job is forgotten on save

29 views
Skip to first unread message

martin.breistein@cgi.com (JIRA)

unread,
Mar 9, 2020, 10:06:03 AM3/9/20
to jenkinsc...@googlegroups.com
Martin Breistein created an issue
 
Jenkins / Bug JENKINS-61398
Source Code Management for build job is forgotten on save
Issue Type: Bug Bug
Assignee: Mark Waite
Attachments: SourceCodeManagement.png
Components: core, git-plugin, mercurial-plugin
Created: 2020-03-09 14:05
Environment: Running direct install of jenkins, on CentOS Linux 7.
Accessed through chrome v.79.0.3945.130.

Plugin List:
org.jenkins-ci.main:jenkins-war:2.224
org.jenkins-ci:crypto-util:1.1
commons-httpclient:commons-httpclient:3.1-jenkins-1
aopalliance:aopalliance:1.0
com.google.code.findbugs:annotations:3.0.0
commons-beanutils:commons-beanutils:1.9.3
com.google.inject:guice:4.0
org.springframework:spring-dao:1.2.9
org.kohsuke.stapler:stapler-jrebel:1.258
org.codehaus.groovy:groovy-all:2.4.12
org.jenkins-ci:constant-pool-scanner:1.2
org.jenkins-ci.modules:windows-slave-installer:1.12
org.connectbot.jbcrypt:jbcrypt:1.0.0
org.ow2.asm:asm-commons:5.0.3
org.jenkins-ci:symbol-annotation:1.1
org.slf4j:slf4j-api:1.7.26
commons-digester:commons-digester:2.1
org.kohsuke:libpam4j:1.11
com.github.jnr:jnr-posix:3.0.45
org.jvnet.winp:winp:1.28
org.apache.commons:commons-compress:1.19
org.jenkins-ci.modules:instance-identity:2.2
org.kohsuke:asm6:6.2
net.sf.kxml:kxml2:2.3.0
org.kohsuke:libzfs:0.8
org.jenkins-ci.main:remoting:4.2
org.jenkins-ci.modules:sshd:2.6
org.kohsuke:access-modifier-annotation:1.16
org.jenkins-ci.modules:slave-installer:1.7
org.kohsuke.stapler:json-lib:2.4-jenkins-2
org.jfree:jfreechart:1.0.19
org.slf4j:slf4j-jdk14:1.7.26
org.jvnet.robust-http-client:robust-http-client:1.2
org.ow2.asm:asm:5.0.3
com.github.jnr:jnr-ffi:2.1.8
com.github.jnr:jnr-constants:0.9.9
org.kohsuke.stapler:stapler-adjunct-timeline:1.5
org.jvnet.hudson:commons-jelly-tags-define:1.0.1-hudson-20071021
commons-lang:commons-lang:2.6
org.springframework:spring-jdbc:1.2.9
org.codehaus.woodstox:wstx-asl:3.2.9
org.springframework:spring-core:2.5.6.SEC03
org.springframework:spring-aop:2.5.6.SEC03
org.jfree:jcommon:1.0.23
org.samba.jcifs:jcifs:1.3.17-kohsuke-1
net.java.dev.jna:jna:5.3.1
net.i2p.crypto:eddsa:0.3.0
org.jenkins-ci:winstone:5.8
com.sun.solaris:embedded_su4j:1.1
com.github.jnr:jffi:1.2.17
javax.inject:javax.inject:1
org.jenkins-ci.modules:upstart-slave-installer:1.1
args4j:args4j:2.33
org.fusesource.jansi:jansi:1.11
org.springframework:spring-beans:2.5.6.SEC03
net.java.sezpoz:sezpoz:1.13
javax.xml.stream:stax-api:1.0-2
org.jvnet.hudson:activation:1.1.1-hudson-1
commons-jelly:commons-jelly-tags-fmt:1.0
org.slf4j:log4j-over-slf4j:1.7.26
oro:oro:2.0.8
org.jenkins-ci:commons-jexl:1.1-jenkins-20111212
org.jenkins-ci.plugins.icon-shim:icon-set:1.0.5
org.apache.ant:ant-launcher:1.9.14
stax:stax-api:1.0.1
com.google.code.findbugs:jsr305:2.0.1
org.kohsuke:windows-package-checker:1.2
org.acegisecurity:acegi-security:1.0.7
org.slf4j:jcl-over-slf4j:1.7.26
commons-fileupload:commons-fileupload:1.3.1-jenkins-2
org.jenkins-ci.modules:launchd-slave-installer:1.2
org.jenkins-ci:annotation-indexer:1.12
jline:jline:2.12
commons-codec:commons-codec:1.12
org.jenkins-ci:task-reactor:1.5
org.kohsuke.stapler:stapler-adjunct-zeroclipboard:1.3.5-1
commons-io:commons-io:2.6
org.kohsuke.stapler:stapler-adjunct-codemirror:1.3
org.ow2.asm:asm-util:5.0.3
org.jenkins-ci:bytecode-compatibility-transformer:2.0-beta-2
org.apache.sshd:sshd-core:1.7.0
org.kohsuke.stapler:stapler-jelly:1.258
org.kohsuke:akuma:1.10
org.jenkins-ci.main:jenkins-core:2.223
javax.mail:mail:1.4.4
org.hamcrest:hamcrest-core:1.3
org.springframework:spring-context-support:2.5.6.SEC03
com.google.guava:guava:11.0.1
org.jenkins-ci.modules:ssh-cli-auth:1.7
org.jvnet.hudson:jtidy:4aug2000r7-dev-hudson-1
org.jenkins-ci:version-number:1.6
org.jenkins-ci:commons-jelly:1.1-jenkins-20120928
org.jenkins-ci.ui:handlebars:1.1.1
org.springframework:spring-context:2.5.6.SEC03
org.jvnet.localizer:localizer:1.26
org.jenkins-ci.ui:jquery-detached:1.2.1
org.ow2.asm:asm-analysis:5.0.3
io.github.stephenc.crypto:self-signed-cert-generator:1.0.0
javax.servlet.jsp.jstl:javax.servlet.jsp.jstl-api:1.2.1
commons-discovery:commons-discovery:0.4
com.github.jnr:jffi:1.2.16
org.jenkins-ci:memory-monitor:1.9
org.jenkins-ci.modules:systemd-slave-installer:1.1
org.jvnet.hudson:xstream:1.4.7-jenkins-1
org.jvnet:tiger-types:2.2
com.sun.xml.txw2:txw2:20110809
org.springframework:spring-web:2.5.6.SEC03
org.kohsuke.jinterop:j-interop:2.0.6-kohsuke-1
io.jenkins.stapler:jenkins-stapler-support:1.1
org.jenkins-ci.main:cli:2.223
org.jruby.ext.posix:jna-posix:1.0.3-jenkins-1
org.kohsuke.stapler:stapler-groovy:1.258
javax.annotation:javax.annotation-api:1.2
org.kohsuke.jinterop:j-interopdeps:2.0.6-kohsuke-1
com.infradna.tool:bridge-method-annotation:1.13
org.ow2.asm:asm-tree:5.0.3
org.kohsuke:asm5:5.0.1
antlr:antlr:2.7.6
relaxngDatatype:relaxngDatatype:20020414
com.jcraft:jzlib:1.1.3-kohsuke-1
org.jenkins-ci.ui:bootstrap:1.3.2
commons-collections:commons-collections:3.2.2
junit:junit:4.12
net.sf.ezmorph:ezmorph:1.0.6
org.kohsuke.stapler:stapler:1.258
org.springframework:spring-webmvc:2.5.6.SEC03
com.github.jnr:jnr-x86asm:1.0.2
xpp3:xpp3:1.1.4c
jaxen:jaxen:1.1-beta-11
org.apache.ant:ant:1.9.14
org.dom4j:dom4j:2.1.1
commons-jelly:commons-jelly-tags-xml:1.1
Labels: SCM Git-plugin
Priority: Minor Minor
Reporter: Martin Breistein

 Source Code Management for build, seems to be forgotten when saving or applying and then leaving page. All other changes on page seem to be correctly stored, but when reloading page SCM is reset to None. This error is not git specific, and also is present for mercurial.

Issue is present on v.2.224 but not on v.2.223.
Fixed issue by rolling back to previous version.
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)
Atlassian logo

martin.breistein@cgi.com (JIRA)

unread,
Mar 9, 2020, 10:07:02 AM3/9/20
to jenkinsc...@googlegroups.com
Martin Breistein updated an issue
Change By: Martin Breistein
Attachment: after load.PNG

mark.earl.waite@gmail.com (JIRA)

unread,
Mar 9, 2020, 10:48:05 AM3/9/20
to jenkinsc...@googlegroups.com
Mark Waite updated an issue
Change By: Mark Waite
Priority: Minor Blocker

mark.earl.waite@gmail.com (JIRA)

unread,
Mar 9, 2020, 10:48:05 AM3/9/20
to jenkinsc...@googlegroups.com
Mark Waite updated an issue
Change By: Mark Waite
Component/s: git-plugin
Component/s: mercurial-plugin

mark.earl.waite@gmail.com (JIRA)

unread,
Mar 9, 2020, 10:49:02 AM3/9/20
to jenkinsc...@googlegroups.com
Mark Waite assigned an issue to Tim Jacomb
Change By: Mark Waite
Assignee: Mark Waite Tim Jacomb

mark.earl.waite@gmail.com (JIRA)

unread,
Mar 9, 2020, 11:10:03 AM3/9/20
to jenkinsc...@googlegroups.com
Mark Waite assigned an issue to Mark Waite
Change By: Mark Waite
Assignee: Tim Jacomb Mark Waite

dbeck@cloudbees.com (JIRA)

unread,
Mar 9, 2020, 11:10:03 AM3/9/20
to jenkinsc...@googlegroups.com
Daniel Beck updated an issue
Change By: Daniel Beck
Labels: Git-plugin SCM regression

o.v.nenashev@gmail.com (JIRA)

unread,
Mar 9, 2020, 11:19:04 AM3/9/20
to jenkinsc...@googlegroups.com
Oleg Nenashev commented on Bug JENKINS-61398
 
Re: Source Code Management for build job is forgotten on save

JENKINS-51495 is suspected to be the root cause, because it modifies descriptorRadioList  being used in SCM configuration sections

mark.earl.waite@gmail.com (JIRA)

unread,
Mar 9, 2020, 11:36:02 AM3/9/20
to jenkinsc...@googlegroups.com

Thanks Oleg Nenashev. I've confirmed that I can duplicate the problem with the tip of the master branch and it is no longer visible if I revert the JENKINS-51495 change. Should I submit a pull request to revert the change or would you prefer to approach it differently?

jglick@cloudbees.com (JIRA)

unread,
Mar 9, 2020, 12:34:04 PM3/9/20
to jenkinsc...@googlegroups.com
Change By: Jesse Glick
Status: In Progress Review

jglick@cloudbees.com (JIRA)

unread,
Mar 9, 2020, 12:34:04 PM3/9/20
to jenkinsc...@googlegroups.com
Jesse Glick started work on Bug JENKINS-61398
 
Change By: Jesse Glick
Status: Open In Progress

timjacomb1@gmail.com (JIRA)

unread,
Mar 9, 2020, 12:42:03 PM3/9/20
to jenkinsc...@googlegroups.com
Tim Jacomb updated an issue
Change By: Tim Jacomb
Attachment: screenshot-1.png

timjacomb1@gmail.com (JIRA)

unread,
Mar 9, 2020, 12:43:03 PM3/9/20
to jenkinsc...@googlegroups.com
Tim Jacomb updated an issue
Change By: Tim Jacomb
Attachment: screenshot-2.png

timjacomb1@gmail.com (JIRA)

unread,
Mar 9, 2020, 12:43:03 PM3/9/20
to jenkinsc...@googlegroups.com
Tim Jacomb commented on Bug JENKINS-61398
 
Re: Source Code Management for build job is forgotten on save

Looking at it in a debugger:

String descriptorId = config.getString("value");

is equal to 1

'this' returns a list with a null scm and a git scm

getting the id on the git scm returns the class name

timjacomb1@gmail.com (JIRA)

unread,
Mar 9, 2020, 12:43:03 PM3/9/20
to jenkinsc...@googlegroups.com
Tim Jacomb updated an issue
Change By: Tim Jacomb
Attachment: this.png

timjacomb1@gmail.com (JIRA)

unread,
Mar 9, 2020, 12:44:03 PM3/9/20
to jenkinsc...@googlegroups.com
Tim Jacomb edited a comment on Bug JENKINS-61398
Looking at it in a debugger:

!screenshot-1.png|thumbnail!

String descriptorId = config.getString("value");

is equal to 1

!this.png|thumbnail!

'this' returns a list with a null scm and a git scm


!screenshot-2.png|thumbnail!

getting the id on the git scm returns the class name



and
1 is not equal to hudson.plugins.git.GitSCM

so the check fails and it defaults to the first item in the list (nullscm)

timjacomb1@gmail.com (JIRA)

unread,
Mar 9, 2020, 12:54:02 PM3/9/20
to jenkinsc...@googlegroups.com

PR submitted: https://github.com/jenkinsci/jenkins/pull/4560

I had a look in core and couldn't see any other issues with this.

mark.earl.waite@gmail.com (JIRA)

unread,
Mar 9, 2020, 7:53:04 PM3/9/20
to jenkinsc...@googlegroups.com
Mark Waite updated Bug JENKINS-61398
 

Merged for Jenkins 2.225
Change By: Mark Waite
Status: In Review Fixed but Unreleased
Resolution: Fixed

o.v.nenashev@gmail.com (JIRA)

unread,
Mar 10, 2020, 5:57:03 AM3/10/20
to jenkinsc...@googlegroups.com
Change By: Oleg Nenashev
Status: Fixed but Unreleased Resolved
Released As: Jenkins 2.225
Reply all
Reply to author
Forward
0 new messages