[JIRA] (JENKINS-59459) ConnectionStrategy changes not backward compatible

egutierrez@cloudbees.com (JIRA)

unread,

Sep 20, 2019, 3:27:03 AM9/20/19

to jenkinsc...@googlegroups.com

Evaristo Gutierrez created an issue

Jenkins /

JENKINS-59459

ConnectionStrategy changes not backward compatible

Issue Type:	Bug
Assignee:	Evaristo Gutierrez
Components:	ec2-plugin
Created:	2019-09-20 07:26
Priority:	Major
Reporter:	Evaristo Gutierrez

[The changes|https://github.com/jenkinsci/ec2-plugin/pull/329] to deliver JENKINS-54329 declared the fields "usePrivateDnsName" and "connectUsingPublicIp" as deprecated but at the same time they were made transient, which changes the way they are exported (to the config.xml file for example) and make the template not to be backward compatible.

Reproduction steps

Setup a Jenkins instance with ec2 1.42.1 and configure a ec2 cloud where the two mentioned parameters are set to true (or one of them, the thing is there is a non default value for a boolean field, which would be true).
Verify they are exported into the config.xml file.
Update ec2 plugin to >1.43 version.
I open the cloud configuration, verify the connection strategy has been set accordingly to the previous boolean values, and re-save the configuration.
In the config.xml file, the two mentioned fields are now gone.
Revert ec2 plugin to 1.42.1
If I open the cloud configuration, both values are set to false (default value for a boolean field) given they were not present in the config.xml file.

Add Comment

This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)

egutierrez@cloudbees.com (JIRA)

unread,

Sep 20, 2019, 3:29:02 AM9/20/19

to jenkinsc...@googlegroups.com

Evaristo Gutierrez started work on

JENKINS-59459

Change By:	Evaristo Gutierrez
Status:	Open In Progress

Add Comment

egutierrez@cloudbees.com (JIRA)

unread,

Sep 20, 2019, 3:29:03 AM9/20/19

to jenkinsc...@googlegroups.com

Evaristo Gutierrez updated

JENKINS-59459

Jenkins /

JENKINS-59459

ConnectionStrategy changes not backward compatible

Change By:	Evaristo Gutierrez
Status:	In Progress Review

Add Comment

egutierrez@cloudbees.com (JIRA)

unread,

Sep 20, 2019, 3:31:03 AM9/20/19

to jenkinsc...@googlegroups.com

Evaristo Gutierrez commented on

JENKINS-59459

Re: ConnectionStrategy changes not backward compatible

https://github.com/jenkinsci/ec2-plugin/pull/400

Add Comment

egutierrez@cloudbees.com (JIRA)

unread,

Sep 20, 2019, 3:35:01 AM9/20/19

to jenkinsc...@googlegroups.com

Evaristo Gutierrez updated an issue

Jenkins /

JENKINS-59459

ConnectionStrategy changes not backward compatible

Change By:	Evaristo Gutierrez

[ [ The changes| |https://github.com/jenkinsci/ec2-plugin/pull/329] [https://github.com/jenkinsci/ec2-plugin/pull/329] [ ] |https://github.com/jenkinsci/ec2-plugin/pull/329] to deliver JENKINS-54329 declared the fields "usePrivateDnsName" and "connectUsingPublicIp" as deprecated but at the same time they were made transient, which changes the way they are exported (to the config.xml file for example) and make the template not to be backward compatible.

*Reproduction steps*
* Setup a Jenkins instance with ec2 1.42.1 and configure a ec2 cloud where the two mentioned parameters are set to true (or one of them, the thing is there is a non default value for a boolean field, which would be true).
* Verify they are exported into the config.xml file.
* Update ec2 plugin to >1.43 version.
* I open the cloud configuration, verify the connection strategy has been set accordingly to the previous boolean values, and re-save the configuration.
* In the config.xml file, the two mentioned fields are now gone.
* Revert ec2 plugin to 1.42.1
* If I open the cloud configuration, both values are set to false (default value for a boolean field) given they were not present in the config.xml file.